From: Gary R Hook <ghook@amd.com>
To: "Hook, Gary" <Gary.Hook@amd.com>,
"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
"herbert@gondor.apana.org.au" <herbert@gondor.apana.org.au>,
"davem@davemloft.net" <davem@davemloft.net>,
"Lendacky, Thomas" <Thomas.Lendacky@amd.com>
Subject: Re: [PATCH v2] crypto: ccp - memset structure fields to zero before reuse
Date: Thu, 11 Jul 2019 15:25:00 +0000 [thread overview]
Message-ID: <7a4dfdce-41ca-2047-f9f2-77e0b7abedb3@amd.com> (raw)
In-Reply-To: <20190711004617.GA628@sol.localdomain>
On 7/10/19 7:46 PM, Eric Biggers wrote:
>
> The generic implementation allows authentication tags of 4, 8, 12, 13, 14, 15,
> or 16 bytes. See crypto_gcm_setauthsize() in crypto/gcm.c, and see
> https://nvlpubs.nist.gov/nistpubs/Legacy/SP/nistspecialpublication800-38d.pdf
> section 5.2.1.2 "Output Data". If you disagree that this is the correct
> behavior, then we need to fix the generic implementation too.
It's been a while, and the refresher was needed, and is appreciated.
Our device only allows 16 byte tags. So I have to figure out how to set
up the driver to expose/enforce that limitation. That's where we go awry.
Thanks much!
next prev parent reply other threads:[~2019-07-11 15:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-10 0:09 [PATCH v2] crypto: ccp - memset structure fields to zero before reuse Hook, Gary
2019-07-10 1:57 ` Eric Biggers
2019-07-10 15:59 ` Gary R Hook
2019-07-10 20:34 ` Eric Biggers
2019-07-10 22:50 ` Gary R Hook
2019-07-11 0:46 ` Eric Biggers
2019-07-11 15:25 ` Gary R Hook [this message]
2019-07-12 2:20 ` Herbert Xu
2019-07-12 10:18 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7a4dfdce-41ca-2047-f9f2-77e0b7abedb3@amd.com \
--to=ghook@amd.com \
--cc=Gary.Hook@amd.com \
--cc=Thomas.Lendacky@amd.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.