From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:52897) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hGnfC-0007u2-R3 for qemu-devel@nongnu.org; Wed, 17 Apr 2019 12:43:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hGnfC-000231-0j for qemu-devel@nongnu.org; Wed, 17 Apr 2019 12:43:58 -0400 References: <20190413165343.9018-1-mreitz@redhat.com> <20190413165343.9018-8-mreitz@redhat.com> From: Max Reitz Message-ID: <7a624f61-a20c-1839-4493-f1ca62664d71@redhat.com> Date: Wed, 17 Apr 2019 18:43:51 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="7uUd2WrE6Am9eYfwLP7myMEBvmLc8SM0X" Subject: Re: [Qemu-devel] [PATCH v3 7/7] iotests: Test qemu-img convert -C --salvage List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladimir Sementsov-Ogievskiy , "qemu-block@nongnu.org" Cc: "qemu-devel@nongnu.org" , Andrey Shinkevich , Eric Blake , Kevin Wolf , Denis Lunev This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --7uUd2WrE6Am9eYfwLP7myMEBvmLc8SM0X From: Max Reitz To: Vladimir Sementsov-Ogievskiy , "qemu-block@nongnu.org" Cc: "qemu-devel@nongnu.org" , Andrey Shinkevich , Eric Blake , Kevin Wolf , Denis Lunev Message-ID: <7a624f61-a20c-1839-4493-f1ca62664d71@redhat.com> Subject: Re: [PATCH v3 7/7] iotests: Test qemu-img convert -C --salvage References: <20190413165343.9018-1-mreitz@redhat.com> <20190413165343.9018-8-mreitz@redhat.com> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 16.04.19 10:13, Vladimir Sementsov-Ogievskiy wrote: > 13.04.2019 19:53, Max Reitz wrote: >> We do not support this combination (yet), so this should yield an erro= r >> message. >> >> Signed-off-by: Max Reitz >=20 > Tested-by: Vladimir Sementsov-Ogievskiy > [only -qcow2, as -nfs -qcow2 is already broken] > Reviewed-by: Vladimir Sementsov-Ogievskiy >=20 > Hmm, interesting, that this test is defined as > _supported_fmt qcow2 > _supported_proto file nfs >=20 > And of course, it doesn't work for -qcow2 -nfs combination.. Of course, nobody ever tests nfs. :-) Thanks for reviewing! Max --7uUd2WrE6Am9eYfwLP7myMEBvmLc8SM0X Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEkb62CjDbPohX0Rgp9AfbAGHVz0AFAly3V8cACgkQ9AfbAGHV z0AZFgf/StLfuF93VjLoJ0nvwMqMFVHTXlkQNba4xjipehFm15tqHj7xvrqFVnni 4+zPUn7necsL9yqLk9Khg1bhHz/zbgJPOv7BzZYx2kL/szqqsHLDT4Ha7wgWCSqx DECcrK1Z/6qf1aSKYBAsFeoCWrF7on8AnGqI2+5go8aJy4X56HRWUGRPtY/4+MaW Auaf76ddIIVBNPSIYS5EcRCnI5GhlyqXDGyX3RUNB3sTs6vMz+JOb5gpyIPxILA8 z/1fxMtWQ2UJwYoyJbLLCvBZ1qwX3GHZYQUOdLJoUnFEXYEnEfsniYxLBTV75d7q 86CI14eeV3oXFZEq+e6Fm8rt1xbWzw== =Q6xL -----END PGP SIGNATURE----- --7uUd2WrE6Am9eYfwLP7myMEBvmLc8SM0X-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D43EC282DA for ; Wed, 17 Apr 2019 16:44:59 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6FD2920835 for ; Wed, 17 Apr 2019 16:44:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6FD2920835 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:56494 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hGngA-0008O9-QS for qemu-devel@archiver.kernel.org; Wed, 17 Apr 2019 12:44:58 -0400 Received: from eggs.gnu.org ([209.51.188.92]:52897) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hGnfC-0007u2-R3 for qemu-devel@nongnu.org; Wed, 17 Apr 2019 12:43:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hGnfC-000231-0j for qemu-devel@nongnu.org; Wed, 17 Apr 2019 12:43:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48466) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hGnf9-00020s-Jp; Wed, 17 Apr 2019 12:43:56 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C5416916C0; Wed, 17 Apr 2019 16:43:54 +0000 (UTC) Received: from dresden.str.redhat.com (ovpn-204-140.brq.redhat.com [10.40.204.140]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C10A45D71A; Wed, 17 Apr 2019 16:43:52 +0000 (UTC) To: Vladimir Sementsov-Ogievskiy , "qemu-block@nongnu.org" References: <20190413165343.9018-1-mreitz@redhat.com> <20190413165343.9018-8-mreitz@redhat.com> From: Max Reitz Openpgp: preference=signencrypt Autocrypt: addr=mreitz@redhat.com; prefer-encrypt=mutual; keydata= mQENBFXOJlcBCADEyyhOTsoa/2ujoTRAJj4MKA21dkxxELVj3cuILpLTmtachWj7QW+TVG8U /PsMCFbpwsQR7oEy8eHHZwuGQsNpEtNC2G/L8Yka0BIBzv7dEgrPzIu+W3anZXQW4702+uES U29G8TP/NGfXRRHGlbBIH9KNUnOSUD2vRtpOLXkWsV5CN6vQFYgQfFvmp5ZpPeUe6xNplu8V mcTw8OSEDW/ZnxJc8TekCKZSpdzYoxfzjm7xGmZqB18VFwgJZlIibt1HE0EB4w5GsD7x5ekh awIe3RwoZgZDLQMdOitJ1tUc8aqaxvgA4tz6J6st8D8pS//m1gAoYJWGwwIVj1DjTYLtABEB AAG0HU1heCBSZWl0eiA8bXJlaXR6QHJlZGhhdC5jb20+iQFTBBMBCAA9AhsDBQkSzAMABQsJ CAcCBhUICQoLAgQWAgMBAh4BAheABQJVzie5FRhoa3A6Ly9rZXlzLmdudXBnLm5ldAAKCRD0 B9sAYdXPQDcIB/9uNkbYEex1rHKz3mr12uxYMwLOOFY9fstP5aoVJQ1nWQVB6m2cfKGdcRe1 2/nFaHSNAzT0NnKz2MjhZVmcrpyd2Gp2QyISCfb1FbT82GMtXFj1wiHmPb3CixYmWGQUUh+I AvUqsevLA+WihgBUyaJq/vuDVM1/K9Un+w+Tz5vpeMidlIsTYhcsMhn0L9wlCjoucljvbDy/ 8C9L2DUdgi3XTa0ORKeflUhdL4gucWoAMrKX2nmPjBMKLgU7WLBc8AtV+84b9OWFML6NEyo4 4cP7cM/07VlJK53pqNg5cHtnWwjHcbpGkQvx6RUx6F1My3y52vM24rNUA3+ligVEgPYBuQEN BFXOJlcBCADAmcVUNTWT6yLWQHvxZ0o47KCP8OcLqD+67T0RCe6d0LP8GsWtrJdeDIQk+T+F xO7DolQPS6iQ6Ak2/lJaPX8L0BkEAiMuLCKFU6Bn3lFOkrQeKp3u05wCSV1iKnhg0UPji9V2 W5eNfy8F4ZQHpeGUGy+liGXlxqkeRVhLyevUqfU0WgNqAJpfhHSGpBgihUupmyUg7lfUPeRM DzAN1pIqoFuxnN+BRHdAecpsLcbR8sQddXmDg9BpSKozO/JyBmaS1RlquI8HERQoe6EynJhd 64aICHDfj61rp+/0jTIcevxIIAzW70IadoS/y3DVIkuhncgDBvGbF3aBtjrJVP+5ABEBAAGJ ASUEGAEIAA8FAlXOJlcCGwwFCRLMAwAACgkQ9AfbAGHVz0CbFwf9F/PXxQR9i4N0iipISYjU sxVdjJOM2TMut+ZZcQ6NSMvhZ0ogQxJ+iEQ5OjnIputKvPVd5U7WRh+4lF1lB/NQGrGZQ1ic alkj6ocscQyFwfib+xIe9w8TG1CVGkII7+TbS5pXHRxZH1niaRpoi/hYtgzkuOPp35jJyqT/ /ELbqQTDAWcqtJhzxKLE/ugcOMK520dJDeb6x2xVES+S5LXby0D4juZlvUj+1fwZu+7Io5+B bkhSVPb/QdOVTpnz7zWNyNw+OONo1aBUKkhq2UIByYXgORPFnbfMY7QWHcjpBVw9MgC4tGeF R4bv+1nAMMxKmb5VvQCExr0eFhJUAHAhVg== Message-ID: <7a624f61-a20c-1839-4493-f1ca62664d71@redhat.com> Date: Wed, 17 Apr 2019 18:43:51 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="7uUd2WrE6Am9eYfwLP7myMEBvmLc8SM0X" X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Wed, 17 Apr 2019 16:43:54 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 X-Content-Filtered-By: Mailman/MimeDel 2.1.21 Subject: Re: [Qemu-devel] [PATCH v3 7/7] iotests: Test qemu-img convert -C --salvage X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Andrey Shinkevich , "qemu-devel@nongnu.org" , Denis Lunev Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Message-ID: <20190417164351.qDrxb-S_z8042BCnY3bsQJ6_433I9uVIWRjULwItKuY@z> This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --7uUd2WrE6Am9eYfwLP7myMEBvmLc8SM0X From: Max Reitz To: Vladimir Sementsov-Ogievskiy , "qemu-block@nongnu.org" Cc: "qemu-devel@nongnu.org" , Andrey Shinkevich , Eric Blake , Kevin Wolf , Denis Lunev Message-ID: <7a624f61-a20c-1839-4493-f1ca62664d71@redhat.com> Subject: Re: [PATCH v3 7/7] iotests: Test qemu-img convert -C --salvage References: <20190413165343.9018-1-mreitz@redhat.com> <20190413165343.9018-8-mreitz@redhat.com> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 16.04.19 10:13, Vladimir Sementsov-Ogievskiy wrote: > 13.04.2019 19:53, Max Reitz wrote: >> We do not support this combination (yet), so this should yield an erro= r >> message. >> >> Signed-off-by: Max Reitz >=20 > Tested-by: Vladimir Sementsov-Ogievskiy > [only -qcow2, as -nfs -qcow2 is already broken] > Reviewed-by: Vladimir Sementsov-Ogievskiy >=20 > Hmm, interesting, that this test is defined as > _supported_fmt qcow2 > _supported_proto file nfs >=20 > And of course, it doesn't work for -qcow2 -nfs combination.. Of course, nobody ever tests nfs. :-) Thanks for reviewing! Max --7uUd2WrE6Am9eYfwLP7myMEBvmLc8SM0X Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEkb62CjDbPohX0Rgp9AfbAGHVz0AFAly3V8cACgkQ9AfbAGHV z0AZFgf/StLfuF93VjLoJ0nvwMqMFVHTXlkQNba4xjipehFm15tqHj7xvrqFVnni 4+zPUn7necsL9yqLk9Khg1bhHz/zbgJPOv7BzZYx2kL/szqqsHLDT4Ha7wgWCSqx DECcrK1Z/6qf1aSKYBAsFeoCWrF7on8AnGqI2+5go8aJy4X56HRWUGRPtY/4+MaW Auaf76ddIIVBNPSIYS5EcRCnI5GhlyqXDGyX3RUNB3sTs6vMz+JOb5gpyIPxILA8 z/1fxMtWQ2UJwYoyJbLLCvBZ1qwX3GHZYQUOdLJoUnFEXYEnEfsniYxLBTV75d7q 86CI14eeV3oXFZEq+e6Fm8rt1xbWzw== =Q6xL -----END PGP SIGNATURE----- --7uUd2WrE6Am9eYfwLP7myMEBvmLc8SM0X--