From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C73B134730; Thu, 25 Jan 2024 20:05:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706213145; cv=none; b=XfxHBL0xPIhv615+qqP55sFilt11Pi0Lo1UHbyC0C3t7eNhWdLts4uf+0vtXDJbT7N+jkvQ+JbepholezYduIhf8SfKZ/gaEJBEdiOo5R7wDdGTRPBfkYrK/WWR8g4OQBn4YmWvNYY2MZ69jTwhwIXA8n6c4CDwV/lQnMNWCP6w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706213145; c=relaxed/simple; bh=WBaEFU0HD/ZpYZcSyEk08bbjDIygWcVOBE8OjlEUd3I=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=oTMcybqrLfcJV4DDvcsHh/qfrjS2mF7xspYv6Fwl6xRh0MV7TQ+4WkaBoNBeDmXXwEcBZ9FsAUI1lX8/TDOaap+L1vg/PUZfJPmec1MQHWnDfXBG1ZI3+GHMWcnn7pqvWGr/ojN4nV2ZXb7KQNvZoIT51lby9Em64ktbOovrSBU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=Ch5/8b3f; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="Ch5/8b3f" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=PSP1mwXt7pbVQqCb1c1AUqEAyMaE5dkMskynL1tp6dg=; b=Ch5/8b3frcnqGViJrO55oIG1hK KCyHsGaAI2M2KL74z6fIm3tlvk2bgW8h1JTdxUdqjXUSl/LlZ8XgIJoHwGHw6hP5vIJEoIfgosfmy +FeuruMUTm2HxmCCFeGWn96d6zPTUdGwoCpS47jNJuQV7CtycTpMfVlXCt6p2holagKA=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1rT5yg-0067Ml-Ai; Thu, 25 Jan 2024 21:05:34 +0100 Date: Thu, 25 Jan 2024 21:05:34 +0100 From: Andrew Lunn To: Kathiravan Thirumoorthy Cc: Bjorn Andersson , Konrad Dybcio , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Richard Cochran , Catalin Marinas , Will Deacon , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v4 2/8] clk: qcom: ipq5332: enable few nssnoc clocks in driver probe Message-ID: <7a69a68d-44c2-4589-b286-466d2f2a0809@lunn.ch> References: <20240122-ipq5332-nsscc-v4-0-19fa30019770@quicinc.com> <20240122-ipq5332-nsscc-v4-2-19fa30019770@quicinc.com> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240122-ipq5332-nsscc-v4-2-19fa30019770@quicinc.com> On Mon, Jan 22, 2024 at 11:26:58AM +0530, Kathiravan Thirumoorthy wrote: > gcc_snoc_nssnoc_clk, gcc_snoc_nssnoc_1_clk, gcc_nssnoc_nsscc_clk are > enabled by default and it's RCG is properly configured by bootloader. Which bootloader? Mainline barebox? > Some of the NSS clocks needs these clocks to be enabled. To avoid > these clocks being disabled by clock framework, drop these entries > from the clock table and enable it in the driver probe itself. If they are critical clocks, i would expect a device to reference them. The CCF only disabled unused clocks in late_initcall_sync(), which means all drivers should of probed and taken a reference on any clocks they require. Please correctly describe the clock tree in device tree, not hide clocks because your DT description is not complete. Andrew --- pw-bot: cr From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7EECDC47258 for ; Thu, 25 Jan 2024 20:06:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=x2vfvHNkki41g2dKm5VpFW5uOXbnhLV/sRfTITUt+OI=; b=1S4lPODhHaVy+M TFMFNORGWm0SclJk8oC0DW9vMgHrfyG2DNR49zfnrBoBinPkyTBX/uBOyLWaEDuV7MLYprTwGDAtp 44oeDg6IDYPGMWrJyewFN5Xu/YOGGJ9yAdIoypZnGlLcyj++Yi8ke9ev0RAYRsftpmUbb1NVdgBPI I30JV957gq3vB4P35k/0Z6YE7P8lLgHJqUz6fikgOut+vk4VtHKIBO7ohUrOaF5eQG3mfwmTjm21d /5mGU3QwoxMOc7j5QZ+iTgVzTqV8YBl+erP79Ydi9YMiwkq/JJIWIfoG5ldOrlZlLgwSP6p4wcnKh NC/oQshAtyEwsjI3j0Og==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rT5yv-00000001iL3-1deX; Thu, 25 Jan 2024 20:05:49 +0000 Received: from vps0.lunn.ch ([156.67.10.101]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rT5yt-00000001iKY-0MU5 for linux-arm-kernel@lists.infradead.org; Thu, 25 Jan 2024 20:05:48 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=PSP1mwXt7pbVQqCb1c1AUqEAyMaE5dkMskynL1tp6dg=; b=Ch5/8b3frcnqGViJrO55oIG1hK KCyHsGaAI2M2KL74z6fIm3tlvk2bgW8h1JTdxUdqjXUSl/LlZ8XgIJoHwGHw6hP5vIJEoIfgosfmy +FeuruMUTm2HxmCCFeGWn96d6zPTUdGwoCpS47jNJuQV7CtycTpMfVlXCt6p2holagKA=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1rT5yg-0067Ml-Ai; Thu, 25 Jan 2024 21:05:34 +0100 Date: Thu, 25 Jan 2024 21:05:34 +0100 From: Andrew Lunn To: Kathiravan Thirumoorthy Cc: Bjorn Andersson , Konrad Dybcio , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Richard Cochran , Catalin Marinas , Will Deacon , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v4 2/8] clk: qcom: ipq5332: enable few nssnoc clocks in driver probe Message-ID: <7a69a68d-44c2-4589-b286-466d2f2a0809@lunn.ch> References: <20240122-ipq5332-nsscc-v4-0-19fa30019770@quicinc.com> <20240122-ipq5332-nsscc-v4-2-19fa30019770@quicinc.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240122-ipq5332-nsscc-v4-2-19fa30019770@quicinc.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240125_120547_171236_DDF1BEB7 X-CRM114-Status: GOOD ( 10.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jan 22, 2024 at 11:26:58AM +0530, Kathiravan Thirumoorthy wrote: > gcc_snoc_nssnoc_clk, gcc_snoc_nssnoc_1_clk, gcc_nssnoc_nsscc_clk are > enabled by default and it's RCG is properly configured by bootloader. Which bootloader? Mainline barebox? > Some of the NSS clocks needs these clocks to be enabled. To avoid > these clocks being disabled by clock framework, drop these entries > from the clock table and enable it in the driver probe itself. If they are critical clocks, i would expect a device to reference them. The CCF only disabled unused clocks in late_initcall_sync(), which means all drivers should of probed and taken a reference on any clocks they require. Please correctly describe the clock tree in device tree, not hide clocks because your DT description is not complete. Andrew --- pw-bot: cr _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel