From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFB12C433F5 for ; Thu, 30 Dec 2021 11:09:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238821AbhL3LJM (ORCPT ); Thu, 30 Dec 2021 06:09:12 -0500 Received: from szxga01-in.huawei.com ([45.249.212.187]:15993 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235057AbhL3LJL (ORCPT ); Thu, 30 Dec 2021 06:09:11 -0500 Received: from dggpemm500024.china.huawei.com (unknown [172.30.72.53]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4JPlnB1CBpzZdxH; Thu, 30 Dec 2021 19:05:50 +0800 (CST) Received: from dggpemm500006.china.huawei.com (7.185.36.236) by dggpemm500024.china.huawei.com (7.185.36.203) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Thu, 30 Dec 2021 19:09:09 +0800 Received: from [10.174.178.55] (10.174.178.55) by dggpemm500006.china.huawei.com (7.185.36.236) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Thu, 30 Dec 2021 19:09:08 +0800 Subject: Re: [PATCH v19 01/13] kdump: add helper parse_crashkernel_high_low() To: Borislav Petkov CC: Thomas Gleixner , Ingo Molnar , , "H . Peter Anvin" , , Dave Young , Baoquan He , Vivek Goyal , Eric Biederman , , Catalin Marinas , Will Deacon , , Rob Herring , Frank Rowand , , "Jonathan Corbet" , , Randy Dunlap , Feng Zhou , Kefeng Wang , Chen Zhou , "John Donnelly" References: <20211228132612.1860-1-thunder.leizhen@huawei.com> <20211228132612.1860-2-thunder.leizhen@huawei.com> <4878dda9-871d-228d-21ac-3ac7c8a84322@huawei.com> From: "Leizhen (ThunderTown)" Message-ID: <7a703955-cd1c-e074-17dd-a9155aa7690a@huawei.com> Date: Thu, 30 Dec 2021 19:08:56 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.178.55] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpemm500006.china.huawei.com (7.185.36.236) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021/12/30 18:40, Borislav Petkov wrote: > On Thu, Dec 30, 2021 at 06:14:59PM +0800, Leizhen (ThunderTown) wrote: >> >> Hi, Dave, Baoquan, Borislav: >> What do you think about the introduction of parse_crashkernel_high_low()? If everyone >> doesn't object, I'll bring it to the next version. But I'll make some adjustments to the >> patches, see below. If there's any objection, I still strongly recommend removing the >> parameters "system_ram" and "crash_base" of parse_crashkernel_{high,low}(). >> >> How about splitting __parse_crashkernel() into two parts? One for parsing >> "crashkernel=X[@offset]", another one for parsing "crashkernel=X,{high,low}" and other >> suffixes in the future. So the parameter requirements are clear at the lowest level. > > First of all, please do not top post! > > Now, I already explained to you what I'd like to see: > > https://lore.kernel.org/r/Ycs3kpZD/vpoo1AX@zn.tnic > > yet you still don't get it. > > So let me make myself clear: in its current form, this is not really an > improvement so for all x86 changes: > > NAKed-by: Borislav Petkov > OK, thanks for your immediate reply, so I can take less detours. -- Regards, Zhen Lei From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8894FC433F5 for ; Thu, 30 Dec 2021 11:10:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:CC:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=t3DEe5vHyl77W0bCkrYvp5/NldcFCiyUVbj7q4AVTBM=; b=ZUuIPQ28knfOfutZ7TM+QkKOwC VDurJeZBYfzukgR/TzShOOzE9IxchmMX0C0I9LH/C4J2kP3a/zNfc8z2dXRd2cnxvUPU0viKLq1RD uAkl9USvTjTd7vQjAIKY7ATBHE/mIS28yFqOm70Ck20YydHRIBtWWUNZY5vfvO7VhSgWyt0ieK+R/ Sf552fj4Qjut+no5ninTWZUY84uxTrpF514NCsEUPzG9iSWTMuxjZkAnjHvH2aG+3ADmE6lNLYl5G pxqR/4ZkWvIYH/fcPXH6+4zB3grJs9ZLn4SnWfki2MJCN/csugUdglSO8VMKWPMfHKJq6LjJhVLjm /x3Xi8LA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n2tJ7-004GD3-Ky; Thu, 30 Dec 2021 11:09:17 +0000 Received: from szxga01-in.huawei.com ([45.249.212.187]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n2tJ2-004GBB-6Q; Thu, 30 Dec 2021 11:09:14 +0000 Received: from dggpemm500024.china.huawei.com (unknown [172.30.72.53]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4JPlnB1CBpzZdxH; Thu, 30 Dec 2021 19:05:50 +0800 (CST) Received: from dggpemm500006.china.huawei.com (7.185.36.236) by dggpemm500024.china.huawei.com (7.185.36.203) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Thu, 30 Dec 2021 19:09:09 +0800 Received: from [10.174.178.55] (10.174.178.55) by dggpemm500006.china.huawei.com (7.185.36.236) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Thu, 30 Dec 2021 19:09:08 +0800 Subject: Re: [PATCH v19 01/13] kdump: add helper parse_crashkernel_high_low() To: Borislav Petkov CC: Thomas Gleixner , Ingo Molnar , , "H . Peter Anvin" , , Dave Young , Baoquan He , Vivek Goyal , Eric Biederman , , Catalin Marinas , Will Deacon , , Rob Herring , Frank Rowand , , "Jonathan Corbet" , , Randy Dunlap , Feng Zhou , Kefeng Wang , Chen Zhou , "John Donnelly" References: <20211228132612.1860-1-thunder.leizhen@huawei.com> <20211228132612.1860-2-thunder.leizhen@huawei.com> <4878dda9-871d-228d-21ac-3ac7c8a84322@huawei.com> From: "Leizhen (ThunderTown)" Message-ID: <7a703955-cd1c-e074-17dd-a9155aa7690a@huawei.com> Date: Thu, 30 Dec 2021 19:08:56 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Originating-IP: [10.174.178.55] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpemm500006.china.huawei.com (7.185.36.236) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211230_030912_450865_98F466BA X-CRM114-Status: GOOD ( 16.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2021/12/30 18:40, Borislav Petkov wrote: > On Thu, Dec 30, 2021 at 06:14:59PM +0800, Leizhen (ThunderTown) wrote: >> >> Hi, Dave, Baoquan, Borislav: >> What do you think about the introduction of parse_crashkernel_high_low()? If everyone >> doesn't object, I'll bring it to the next version. But I'll make some adjustments to the >> patches, see below. If there's any objection, I still strongly recommend removing the >> parameters "system_ram" and "crash_base" of parse_crashkernel_{high,low}(). >> >> How about splitting __parse_crashkernel() into two parts? One for parsing >> "crashkernel=X[@offset]", another one for parsing "crashkernel=X,{high,low}" and other >> suffixes in the future. So the parameter requirements are clear at the lowest level. > > First of all, please do not top post! > > Now, I already explained to you what I'd like to see: > > https://lore.kernel.org/r/Ycs3kpZD/vpoo1AX@zn.tnic > > yet you still don't get it. > > So let me make myself clear: in its current form, this is not really an > improvement so for all x86 changes: > > NAKed-by: Borislav Petkov > OK, thanks for your immediate reply, so I can take less detours. -- Regards, Zhen Lei _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Subject: Re: [PATCH v19 01/13] kdump: add helper parse_crashkernel_high_low() References: <20211228132612.1860-1-thunder.leizhen@huawei.com> <20211228132612.1860-2-thunder.leizhen@huawei.com> <4878dda9-871d-228d-21ac-3ac7c8a84322@huawei.com> From: "Leizhen (ThunderTown)" Message-ID: <7a703955-cd1c-e074-17dd-a9155aa7690a@huawei.com> Date: Thu, 30 Dec 2021 19:08:56 +0800 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Borislav Petkov Cc: Thomas Gleixner , Ingo Molnar , x86@kernel.org, "H . Peter Anvin" , linux-kernel@vger.kernel.org, Dave Young , Baoquan He , Vivek Goyal , Eric Biederman , kexec@lists.infradead.org, Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org, Rob Herring , Frank Rowand , devicetree@vger.kernel.org, Jonathan Corbet , linux-doc@vger.kernel.org, Randy Dunlap , Feng Zhou , Kefeng Wang , Chen Zhou , John Donnelly On 2021/12/30 18:40, Borislav Petkov wrote: > On Thu, Dec 30, 2021 at 06:14:59PM +0800, Leizhen (ThunderTown) wrote: >> >> Hi, Dave, Baoquan, Borislav: >> What do you think about the introduction of parse_crashkernel_high_low()? If everyone >> doesn't object, I'll bring it to the next version. But I'll make some adjustments to the >> patches, see below. If there's any objection, I still strongly recommend removing the >> parameters "system_ram" and "crash_base" of parse_crashkernel_{high,low}(). >> >> How about splitting __parse_crashkernel() into two parts? One for parsing >> "crashkernel=X[@offset]", another one for parsing "crashkernel=X,{high,low}" and other >> suffixes in the future. So the parameter requirements are clear at the lowest level. > > First of all, please do not top post! > > Now, I already explained to you what I'd like to see: > > https://lore.kernel.org/r/Ycs3kpZD/vpoo1AX@zn.tnic > > yet you still don't get it. > > So let me make myself clear: in its current form, this is not really an > improvement so for all x86 changes: > > NAKed-by: Borislav Petkov > OK, thanks for your immediate reply, so I can take less detours. -- Regards, Zhen Lei _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec