Re: [MPTCP] [PATCH v3 0/3] mptcp: refactor xmit path

Re: [MPTCP] [PATCH v3 0/3] mptcp: refactor xmit path

[Matthieu Baerts]

[-- Attachment #1: Type: text/plain, Size: 1436 bytes --]

Hi Paolo, Mat,

On 11/05/2019 02:43, Mat Martineau wrote:
> 
> On Fri, 10 May 2019, Paolo Abeni wrote:
> 
>> this series refactor the mptcp xmit path trying to make sendmsg behavior
>> more consistent, memory efficent and improve its performances.
>>
>> Self-test results are not affected: tests fail in similar way before and
>> after this series.
>>
>> To support MP_JOIN and multiple subflows, the idea is adding, with later
>> patches, an RB-tree structure containing references to the pending page
>> fragments, their length and the associated mptcp write_seq number (is
>> subflow
>> rel_write_seq needed, too?).
> 
> rel_write_seq doesn't need to be stored for later, it will be different
> for every copy of the data that is sent.
> 
>> RB-tree node can be allocated using the same
>> page frag used in this series for skb data. Each RB-tree node will own a
>> reference to the page frag.
> 
> I think this is a nice improvement for the sendmsg code, the earlier
> issues are resolved and we should merge the series to mptcp_net-next.

Thank you for the new version of the patches and the reviews. Just added
at the end of the series.

https://github.com/multipath-tcp/mptcp_net-next/commits/export

Cheers,
Matt
-- 
Matthieu Baerts | R&D Engineer
matthieu.baerts(a)tessares.net
Tessares SA | Hybrid Access Solutions
www.tessares.net
1 Avenue Jean Monnet, 1348 Louvain-la-Neuve, Belgium

Re: [MPTCP] [PATCH v3 0/3] mptcp: refactor xmit path

[Mat Martineau]

[-- Attachment #1: Type: text/plain, Size: 1886 bytes --]


On Fri, 10 May 2019, Paolo Abeni wrote:

> this series refactor the mptcp xmit path trying to make sendmsg behavior
> more consistent, memory efficent and improve its performances.
>
> Self-test results are not affected: tests fail in similar way before and
> after this series.
>
> To support MP_JOIN and multiple subflows, the idea is adding, with later
> patches, an RB-tree structure containing references to the pending page
> fragments, their length and the associated mptcp write_seq number (is subflow
> rel_write_seq needed, too?).

rel_write_seq doesn't need to be stored for later, it will be different 
for every copy of the data that is sent.

> RB-tree node can be allocated using the same
> page frag used in this series for skb data. Each RB-tree node will own a
> reference to the page frag.

I think this is a nice improvement for the sendmsg code, the earlier 
issues are resolved and we should merge the series to mptcp_net-next.


Mat


>
> v2 -> v3:
> - rebased on top of "mptcp: refactor shutdown/close and conn_list handling"
> - cope with egres pkt with NULL ext
>
> v1  -> v2:
> - rebased on top of current git
> - fix handling of some corner cases
>
> RFC -> v1:
> - addressed Mat's feedback, dropping patch 3/4 and switching
>   to per msk page frag use, and checking mptcp seq number for coalescing
>
> Paolo Abeni (3):
>  mptcp: use sk_page_frag() in sendmsg
>  mptcp: sendmsg() do spool all the provided data
>  mptcp: allow collapsing consecutive sendpages on the same substream
>
> net/mptcp/protocol.c | 190 ++++++++++++++++++++++++++++---------------
> 1 file changed, 123 insertions(+), 67 deletions(-)
>
> -- 
> 2.20.1
>
> _______________________________________________
> mptcp mailing list
> mptcp(a)lists.01.org
> https://lists.01.org/mailman/listinfo/mptcp
>

--
Mat Martineau
Intel

[MPTCP] [PATCH v3 0/3] mptcp: refactor xmit path

[Paolo Abeni]

[-- Attachment #1: Type: text/plain, Size: 1334 bytes --]

this series refactor the mptcp xmit path trying to make sendmsg behavior
more consistent, memory efficent and improve its performances.

Self-test results are not affected: tests fail in similar way before and
after this series.

To support MP_JOIN and multiple subflows, the idea is adding, with later
patches, an RB-tree structure containing references to the pending page
fragments, their length and the associated mptcp write_seq number (is subflow
rel_write_seq needed, too?). RB-tree node can be allocated using the same
page frag used in this series for skb data. Each RB-tree node will own a
reference to the page frag.

v2 -> v3:
 - rebased on top of "mptcp: refactor shutdown/close and conn_list handling"
 - cope with egres pkt with NULL ext

v1  -> v2:
 - rebased on top of current git
 - fix handling of some corner cases

RFC -> v1:
 - addressed Mat's feedback, dropping patch 3/4 and switching
   to per msk page frag use, and checking mptcp seq number for coalescing

Paolo Abeni (3):
  mptcp: use sk_page_frag() in sendmsg
  mptcp: sendmsg() do spool all the provided data
  mptcp: allow collapsing consecutive sendpages on the same substream

 net/mptcp/protocol.c | 190 ++++++++++++++++++++++++++++---------------
 1 file changed, 123 insertions(+), 67 deletions(-)

-- 
2.20.1