From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hannes Reinecke Subject: Re: [RFC 9/9] zfcp: decouple our scsi_eh callbacks from scsi_cmnd Date: Wed, 26 Jul 2017 08:16:42 +0200 Message-ID: <7a91a979-cb1b-00e9-9ae9-6c63ce9456fe@suse.de> References: <20170725141427.35258-1-maier@linux.vnet.ibm.com> <20170725141427.35258-10-maier@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <20170725141427.35258-10-maier@linux.vnet.ibm.com> Content-Language: en-US Sender: linux-scsi-owner@vger.kernel.org List-Archive: List-Post: To: Steffen Maier , linux-scsi@vger.kernel.org Cc: linux-s390@vger.kernel.org, Benjamin Block List-ID: On 07/25/2017 04:14 PM, Steffen Maier wrote: > zfcp_scsi_eh_device_reset_handler() now only depends on scsi_device. > zfcp_scsi_eh_target_reset_handler() now only depends on scsi_target. > zfcp_scsi_eh_host_reset_handler() now only depends on Scsi_Host. > All derive other objects from these intended callback arguments. > > Actually change the signature of zfcp_task_mgmt_function() used by > zfcp_scsi_eh_device_reset_handler() & zfcp_scsi_eh_target_reset_handler(). > Since it was prepared in a previous patch, we only need to delete > some local auto variables which are now the intended arguments. > > Signed-off-by: Steffen Maier > --- > drivers/s390/scsi/zfcp_scsi.c | 40 ++++++++++++++++++++++++++++++++-------- > 1 file changed, 32 insertions(+), 8 deletions(-) > Thank you for doing this. Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking hare@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg)