From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Suman Anna <s-anna@ti.com>, Tony Lindgren <tony@atomide.com>,
Thomas Gleixner <tglx@linutronix.de>
Cc: linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
Tero Kristo <t-kristo@ti.com>,
Neil Armstrong <narmstrong@baylibre.com>,
"H . Nikolaus Schaller" <hns@goldelico.com>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Keerthy <j-keerthy@ti.com>, Ladislav Michl <ladis@linux-mips.org>,
Pavel Machek <pavel@ucw.cz>, Sebastian Reichel <sre@kernel.org>
Subject: Re: [PATCH] clocksource: timer-ti-dm: Drop bogus omap_dm_timer_of_set_source()
Date: Thu, 27 Feb 2020 10:33:23 +0100 [thread overview]
Message-ID: <7a91fcf9-68c8-91d4-e692-8f01129458dc@linaro.org> (raw)
In-Reply-To: <20200213053504.22638-1-s-anna@ti.com>
Hi,
On 13/02/2020 06:35, Suman Anna wrote:
> The function omap_dm_timer_of_set_source() was originally added in
> commit 31a7448f4fa8a ("ARM: OMAP: dmtimer: Add clock source from DT"),
> and is designed to set a clock source from DT using the clocks property
> of a timer node. This design choice is okay for clk provider nodes but
> otherwise is a bad design as typically the clocks property is used to
> specify the functional clocks for a device, and not its parents.
>
> The timer nodes now all define a timer functional clock after the
> conversion to ti-sysc and the new clkctrl layout, and this results
> in an attempt to set the same functional clock as its parent when a
> consumer driver attempts to acquire any of these timers in the
> omap_dm_timer_prepare() function. This was masked and worked around
> in commit 983a5a43ec25 ("clocksource: timer-ti-dm: Fix pwm dmtimer
> usage of fck reparenting"). Fix all of this by simply dropping the
> entire function.
>
> Any DT configuration of clock sources should be achieved using
> assigned-clocks and assigned-clock-parents properties provided
> by the Common Clock Framework.
Applied. Thanks
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2020-02-27 9:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-13 5:35 [PATCH] clocksource: timer-ti-dm: Drop bogus omap_dm_timer_of_set_source() Suman Anna
2020-02-24 5:01 ` Lokesh Vutla
2020-02-26 16:16 ` Tony Lindgren
2020-02-26 17:24 ` Daniel Lezcano
2020-02-27 9:33 ` Daniel Lezcano [this message]
2020-03-19 8:47 ` [tip: timers/core] clocksource/drivers/timer-ti-dm: " tip-bot2 for Suman Anna
2020-04-25 9:14 ` [PATCH] clocksource: timer-ti-dm: " Lokesh Vutla
2020-04-25 14:51 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7a91fcf9-68c8-91d4-e692-8f01129458dc@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=bgolaszewski@baylibre.com \
--cc=hns@goldelico.com \
--cc=j-keerthy@ti.com \
--cc=ladis@linux-mips.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=narmstrong@baylibre.com \
--cc=pavel@ucw.cz \
--cc=s-anna@ti.com \
--cc=sre@kernel.org \
--cc=t-kristo@ti.com \
--cc=tglx@linutronix.de \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.