From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35374) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fO288-0006hl-JF for qemu-devel@nongnu.org; Wed, 30 May 2018 10:31:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fO283-0003BA-O9 for qemu-devel@nongnu.org; Wed, 30 May 2018 10:31:12 -0400 References: <20180517081527.14410-1-david@redhat.com> <20180517081527.14410-6-david@redhat.com> <20180530151212.47455e78@redhat.com> From: David Hildenbrand Message-ID: <7a9ad117-1f07-d7a5-051e-67b754b9dd0d@redhat.com> Date: Wed, 30 May 2018 16:31:04 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4 05/14] pc: route all memory devices through the machine hotplug handler List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , Igor Mammedov Cc: qemu-devel@nongnu.org, Pankaj Gupta , Eduardo Habkost , "Michael S . Tsirkin" , Cornelia Huck , Markus Armbruster , Alexander Graf , Christian Borntraeger , qemu-s390x@nongnu.org, qemu-ppc@nongnu.org, Marcel Apfelbaum , Luiz Capitulino , David Gibson , Richard Henderson On 30.05.2018 16:27, Paolo Bonzini wrote: > On 30/05/2018 16:08, David Hildenbrand wrote: >>>> if (object_dynamic_cast(OBJECT(dev), TYPE_PC_DIMM) || >>>> + object_dynamic_cast(OBJECT(dev), TYPE_MEMORY_DEVICE) || >>> you probably could drop TYPE_PC_DIMM above, it's redundant since DIMM >>> can be cast to TYPE_MEMORY_DEVICE >>> >>> ditto for spapr >>> >> Yes, had the same in mind but left it for now this way (basically >> because we do special handling for PC_DIMM, so anybody reading this code >> is not directly confused) >> > > Hmm, I think what Igor proposes is nicer. Can you send a v5 when he's > done with review? Sure! > > Paolo > -- Thanks, David / dhildenb