From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: Subject: Re: [PATCH v3] rpmsg: qcom_smd: Access APCS through mailbox framework From: Frank Rowand References: <20180420011757.22389-1-bjorn.andersson@linaro.org> Message-ID: <7a9ae9a0-8d26-6968-6357-d5347cc44333@gmail.com> Date: Thu, 30 Aug 2018 21:05:12 -0700 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit To: Bjorn Andersson , Rob Herring Cc: Mark Rutland , Ohad Ben-Cohen , linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-remoteproc@vger.kernel.org, Nicolas Dechesne List-ID: On 08/30/18 20:57, Frank Rowand wrote: > Hi Bjorn, > > > On 04/19/18 18:17, Bjorn Andersson wrote: >> Attempt to acquire the APCS IPC through the mailbox framework and fall >> back to the old syscon based approach, to allow us to move away from >> using the syscon. >> >> Reviewed-by: Arun Kumar Neelakantam >> Signed-off-by: Bjorn Andersson >> --- >> >> Changes since v2: >> - Added comment about mbox_send_message() return value. >> >> .../devicetree/bindings/soc/qcom/qcom,smd.txt | 8 ++- >> drivers/rpmsg/Kconfig | 1 + >> drivers/rpmsg/qcom_smd.c | 67 ++++++++++++++++------ >> 3 files changed, 56 insertions(+), 20 deletions(-) > > This patch in the mainline Linux kernel as commit ab460a2e72dabecfdabd45eb7e3ee2d73fc876d4 > causes a problem with the APQ8074 Dragonboard. The mmc device is not set up > with the patch applied, thus I do not have the block device my root file system > is located on. > > Testing on v4.18, if I revert this commit the mmc device is available. > > I'll reply to this email with the console messages for 4.18 and for 4.18 with > this commit reverted. < snip > Note that I have commented out the WARN_ON() in gic_irq_domain_translate() at drivers/irqchip/irq-gic.c:1016 to remove a lot of noise from the boot messages. Here are the console messages for 4.18, with ab460a2e72da reverted: Android Bootloader - UART_DM Initialized!!! [0] welcome to lk [10] platform_init() [10] target_init() [10] Display Init: Start [10] display_init(),target_id=10. [30] Config MIPI_VIDEO_PANEL. [30] Turn on MIPI_VIDEO_PANEL. [50] Video lane tested successfully [50] Display Init: Done [80] Loading keystore failed status 5 [80] ERROR: scm_protect_keystore Failed[200] USB init ept @ 0xf96b000 [220] fastboot_init() [220] udc_start() [350] -- reset -- [350] -- portchange -- [460] -- reset -- [460] -- portchange -- [650] fastboot: processing commands [760] fastboot: download:00ed6000 [1250] fastboot: boot [1270] Found Appeneded Flattened Device tree [1270] cmdline: console=ttyMSM0,115200,n8 androidboot.hardware=qcom user_debug=31 maxcpus=2 msm_rtb.filter=0x37 ehci-hcd.park=3 kgdboc=ttyMSM0,115200 debug and roidboot.emmc=true androidboot.serialno=40081c41 androidboot.baseband=apq [1290] Updating device tree: start [1300] Updating device tree: done [1300] booting linux @ 0x8000, ramdisk @ 0x2000000 (9533134), tags/device tree @ 0x1e00000 [1310] Turn off MIPI_VIDEO_PANEL. [1310] Continuous splash enabled, keeping panel alive. Booting Linux on physical CPU 0x0 Linux version 4.18.0-dirty (frowand@xps8900) (gcc version 4.6.x-google 20120106 (prerelease) (GCC)) #2 SMP PREEMPT Thu Aug 30 20:26:18 PDT 2018 CPU: ARMv7 Processor [512f06f0] revision 0 (ARMv7), cr=10c5787d CPU: div instructions available: patching division code CPU: PIPT / VIPT nonaliasing data cache, PIPT instruction cache OF: fdt: Machine model: Qualcomm APQ8074 Dragonboard Memory policy: Data cache writealloc On node 0 totalpages: 491776 Normal zone: 1536 pages used for memmap Normal zone: 0 pages reserved Normal zone: 164096 pages, LIFO batch:31 HighMem zone: 327680 pages, LIFO batch:31 random: get_random_bytes called from start_kernel+0x80/0x47c with crng_init=0 percpu: Embedded 17 pages/cpu @(ptrval) s39616 r8192 d21824 u69632 pcpu-alloc: s39616 r8192 d21824 u69632 alloc=17*4096 pcpu-alloc: [0] 0 [0] 1 [0] 2 [0] 3 Built 1 zonelists, mobility grouping on. Total pages: 490240 Kernel command line: console=ttyMSM0,115200,n8 androidboot.hardware=qcom user_debug=31 maxcpus=2 msm_rtb.filter=0x37 ehci-hcd.park=3 kgdboc=ttyM SM0,115200 debug androidboot.emmc=true androidboot.serialno=40081c41 androidboot.baseband=apq Dentry cache hash table entries: 131072 (order: 7, 524288 bytes) Inode-cache hash table entries: 65536 (order: 6, 262144 bytes) Memory: 1926832K/1967104K available (8192K kernel code, 793K rwdata, 3260K rodata, 1024K init, 267K bss, 40272K reserved, 0K cma-reserved, 13107 20K highmem) Virtual kernel memory layout: vector : 0xffff0000 - 0xffff1000 ( 4 kB) fixmap : 0xffc00000 - 0xfff00000 (3072 kB) vmalloc : 0xf0800000 - 0xff800000 ( 240 MB) lowmem : 0xc0000000 - 0xf0000000 ( 768 MB) pkmap : 0xbfe00000 - 0xc0000000 ( 2 MB) modules : 0xbf000000 - 0xbfe00000 ( 14 MB) .text : 0x(ptrval) - 0x(ptrval) (9184 kB) .init : 0x(ptrval) - 0x(ptrval) (1024 kB) .data : 0x(ptrval) - 0x(ptrval) ( 794 kB) .bss : 0x(ptrval) - 0x(ptrval) ( 268 kB) SLUB: HWalign=64, Order=0-3, MinObjects=0, CPUs=4, Nodes=1 Preemptible hierarchical RCU implementation. Tasks RCU enabled. NR_IRQS: 16, nr_irqs: 16, preallocated irqs: 16 arch_timer: cp15 and mmio timer(s) running at 19.20MHz (virt/virt). clocksource: arch_sys_counter: mask: 0xffffffffffffff max_cycles: 0x46d987e47, max_idle_ns: 440795202767 ns sched_clock: 56 bits at 19MHz, resolution 52ns, wraps every 4398046511078ns Switching to timer-based delay loop, resolution 52ns Console: colour dummy device 80x30 Calibrating delay loop (skipped), value calculated using timer frequency.. 38.40 BogoMIPS (lpj=192000) pid_max: default: 32768 minimum: 301 Mount-cache hash table entries: 2048 (order: 1, 8192 bytes) Mountpoint-cache hash table entries: 2048 (order: 1, 8192 bytes) CPU: Testing write buffer coherency: ok CPU0: thread -1, cpu 0, socket 0, mpidr 80000000 Setting up static identity map for 0x300000 - 0x300060 Hierarchical SRCU implementation. smp: Bringing up secondary CPUs ... CPU1: thread -1, cpu 1, socket 0, mpidr 80000001 smp: Brought up 1 node, 2 CPUs SMP: Total of 2 processors activated (76.80 BogoMIPS). CPU: All CPU(s) started in SVC mode. devtmpfs: initialized VFP support v0.3: implementor 51 architecture 64 part 6f variant 2 rev 0 clocksource: jiffies: mask: 0xffffffff max_cycles: 0xffffffff, max_idle_ns: 19112604462750000 ns futex hash table entries: 1024 (order: 4, 65536 bytes) pinctrl core: initialized pinctrl subsystem NET: Registered protocol family 16 DMA: preallocated 256 KiB pool for atomic coherent allocations cpuidle: using governor menu hw-breakpoint: found 5 (+1 reserved) breakpoint and 4 watchpoint registers. hw-breakpoint: maximum watchpoint size is 8 bytes. reg-fixed-voltage vreg-boost: could not find pctldev for node /soc/spmi@fc4cf000/pm8941@0/gpios@c000/boost-bypass, deferring probe vgaarb: loaded SCSI subsystem initialized libata version 3.00 loaded. usbcore: registered new interface driver usbfs usbcore: registered new interface driver hub usbcore: registered new device driver usb Advanced Linux Sound Architecture Driver Initialized. clocksource: Switched to clocksource arch_sys_counter NET: Registered protocol family 2 tcp_listen_portaddr_hash hash table entries: 512 (order: 0, 6144 bytes) TCP established hash table entries: 8192 (order: 3, 32768 bytes) TCP bind hash table entries: 8192 (order: 4, 65536 bytes) TCP: Hash tables configured (established 8192 bind 8192) UDP hash table entries: 512 (order: 2, 16384 bytes) UDP-Lite hash table entries: 512 (order: 2, 16384 bytes) NET: Registered protocol family 1 RPC: Registered named UNIX socket transport module. RPC: Registered udp transport module. RPC: Registered tcp transport module. RPC: Registered tcp NFSv4.1 backchannel transport module. PCI: CLS 0 bytes, default 64 Trying to unpack rootfs image as initramfs... Freeing initrd memory: 9312K hw perfevents: enabled with armv7_krait PMU driver, 5 counters available Initialise system trusted keyrings workingset: timestamp_bits=30 max_order=19 bucket_order=0 NFS: Registering the id_resolver key type Key type id_resolver registered Key type id_legacy registered jffs2: version 2.2. (NAND) �© 2001-2006 Red Hat, Inc. fuse init (API version 7.27) Key type asymmetric registered Asymmetric key parser 'x509' registered bounce: pool size: 64 pages Block layer SCSI generic (bsg) driver version 0.4 loaded (major 250) io scheduler noop registered io scheduler deadline registered io scheduler cfq registered (default) io scheduler mq-deadline registered io scheduler kyber registered msm_serial f991e000.serial: msm_serial: detected port #0 msm_serial f991e000.serial: uartclk = 7372800 f991e000.serial: ttyMSM0 at MMIO 0xf991e000 (irq = 27, base_baud = 460800) is a MSM msm_serial: console setup on port #0 console [ttyMSM0] enabled msm_serial: driver initialized brd: module loaded loop: module loaded SCSI Media Changer driver v0.25 spmi spmi-0: PMIC arbiter version v1 (0x20000002) s1: supplied by regulator-dummy s2: supplied by regulator-dummy s3: supplied by regulator-dummy s4: Bringing 5100000uV into 5000000-5000000uV l1: supplied by regulator-dummy l2: supplied by regulator-dummy l3: supplied by regulator-dummy l4: supplied by regulator-dummy l5: supplied by regulator-dummy l6: supplied by regulator-dummy l7: supplied by regulator-dummy l8: supplied by regulator-dummy l9: supplied by regulator-dummy l10: supplied by regulator-dummy l11: supplied by regulator-dummy l12: supplied by regulator-dummy l13: supplied by regulator-dummy l14: supplied by regulator-dummy l15: supplied by regulator-dummy l16: supplied by regulator-dummy l17: supplied by regulator-dummy l18: supplied by regulator-dummy l19: supplied by regulator-dummy l20: supplied by regulator-dummy l21: supplied by regulator-dummy l22: supplied by regulator-dummy l23: supplied by regulator-dummy l24: supplied by regulator-dummy lvs1: supplied by regulator-dummy lvs2: supplied by regulator-dummy lvs3: supplied by regulator-dummy 5vs1: supplied by s4 5vs2: supplied by s4 libphy: Fixed MDIO Bus: probed SLIP: version 0.8.4-NET3.019-NEWTTY (dynamic channels, max=256) (6 bit encapsulation enabled). CSLIP: code copyright 1989 Regents of the University of California. usbcore: registered new interface driver ax88179_178a usbcore: registered new interface driver cdc_ether usbcore: registered new interface driver net1080 usbcore: registered new interface driver cdc_subset usbcore: registered new interface driver cdc_ncm ehci_hcd: USB 2.0 'Enhanced' Host Controller (EHCI) Driver ehci-pci: EHCI PCI platform driver usbcore: registered new interface driver cdc_acm cdc_acm: USB Abstract Control Model driver for USB modems and ISDN adapters rtc-pm8xxx fc4cf000.spmi:pm8941@0:rtc@6000: rtc core: registered pm8xxx_rtc as rtc0 i2c /dev entries driver qcom-smbb fc4cf000.spmi:pm8941@0:charger@1000: Initializing SMBB rev 3 otg-vbus: supplied by 5vs1 qcom-tsens fc4a8000.thermal-sensor: tsens calibration failed cpuidle: enable-method property 'qcom,kpss-acc-v2' found operations cpuidle: enable-method property 'qcom,kpss-acc-v2' found operations cpuidle: enable-method property 'qcom,kpss-acc-v2' found operations cpuidle: enable-method property 'qcom,kpss-acc-v2' found operations sdhci: Secure Digital Host Controller Interface driver sdhci: Copyright(c) Pierre Ossman sdhci-pltfm: SDHCI platform and OF driver helper sdhci_msm f98a4900.sdhci: Got CD GPIO usbcore: registered new interface driver usbhid usbhid: USB HID core driver remoteproc remoteproc0: releasing adsp-pil oprofile: using timer interrupt. NET: Registered protocol family 17 Key type dns_resolver registered Registering SWP/SWPB emulation handler Loading compiled-in X.509 certificates s1: supplied by regulator-dummy s1: Bringing 0uV into 675000-675000uV sdhci_msm f98a4900.sdhci: Got CD GPIO remoteproc remoteproc0: releasing adsp-pil s2: supplied by regulator-dummy s2: Bringing 0uV into 500000-500000uV rtc-pm8xxx fc4cf000.spmi:pm8941@0:rtc@6000: setting system clock to 1970-01-01 03:12:34 UTC (11554) s3: supplied by regulator-dummy cfg80211: Loading compiled-in X.509 certificates for regulatory database s3: Bringing 0uV into 500000-500000uV s4: supplied by regulator-dummy cfg80211: Loaded X.509 cert 'sforshee: 00b28ddf47aef9cea7' s4: Bringing 0uV into 500000-500000uV platform regulatory.0: Direct firmware load for regulatory.db failed with error -2 s5: supplied by regulator-dummy ALSA device list: s6: supplied by regulator-dummy cfg80211: failed to load regulatory.db s7: supplied by regulator-dummy No soundcard�[ 2.107810] s1: supplied by regulator-dummy s1: Bringing 0uV into 1300000-1300000uV Freeing unused kernel memory: 1024K s2: supplied by regulator-dummy sdhci_msm f98a4900.sdhci: Got CD GPIO s2: Bringing 0uV into 2150000-2150000uV qcom_adsp_pil adsp-pil: adsp-pil supply px not found, using dummy regulator qcom_adsp_pil adsp-pil: no fatal IRQ defined s3: supplied by regulator-dummy s3: Bringing 0uV into 1800000-1800000uV remoteproc remoteproc0: releasing adsp-pil l1: supplied by s1 mkdir: can't create directory '/bin': File exists mkdir: can't [ 2.165006] l1: Bringing 0uV into 1225000-1225000uV l2: supplied by s3 create directory '/dev': File exists l2: Bringing 0uV into 1200000-1200000uV l3: supplied by s1 l3: Bringing 0uV into 1225000-1225000uV l4: supplied by s1 mdev: unknown user/group 'root:uucp' on line 34 l4: Bringing 0uV into 1225000-1225000uV l5: supplied by s2 l5: Bringing 0uV into 1800000-1800000uV l6: supplied by s2 l6: Bringing 0uV into 1800000-1800000uV l7: supplied by s2 l7: Bringing 0uV into 1800000-1800000uV l8: supplied by regulator-dummy l8: Bringing 0uV into 1800000-1800000uV l9: supplied by regulator-dummy l9: Bringing 0uV into 1800000-1800000uV l10: supplied by regulator-dummy l10: Bringing 0uV into 1800000-1800000uV l11: supplied by s1 l11: Bringing 0uV into 1300000-1300000uV l12: supplied by s2 l12: Bringing 0uV into 1800000-1800000uV l13: supplied by regulator-dummy l13: Bringing 0uV into 1800000-1800000uV l14: supplied by s2 l14: Bringing 0uV into 1800000-1800000uV l15: supplied by s2 l15: Bringing 0uV into 2050000-2050000uV l16: supplied by regulator-dummy l16: Bringing 0uV into 2700000-2700000uV l17: supplied by regulator-dummy l17: Bringing 0uV into 2700000-2700000uV l18: supplied by regulator-dummy l18: Bringing 0uV into 2850000-2850000uV l19: supplied by regulator-dummy l19: Bringing 0uV into 3300000-3300000uV l20: supplied by regulator-dummy l20: Bringing 0uV into 2950000-2950000uV l21: supplied by regulator-dummy l21: Bringing 0uV into 2950000-2950000uV l22: supplied by regulator-dummy l22: Bringing 0uV into 3000000-3000000uV l23: supplied by regulator-dummy l23: Bringing 0uV into 3000000-3000000uV l24: supplied by regulator-dummy l24: Bringing 0uV into 3075000-3075000uV lvs1: supplied by s3 lvs2: supplied by s3 lvs3: supplied by s3 5vs1: supplied by s4 5vs2: supplied by s4 mmc0: Switching to 3.3V signalling voltage failed mmc0: SDHCI controller on f9824900.sdhci [f9824900.sdhci] using ADMA sdhci_msm f98a4900.sdhci: Got CD GPIO mmc1: SDHCI controller on f98a4900.sdhci [f98a4900.sdhci] using ADMA qcom_adsp_pil adsp-pil: adsp-pil supply px not found, using dummy regulator qcom_adsp_pil adsp-pil: no fatal IRQ defined remoteproc remoteproc0: releasing adsp-pil qcom_adsp_pil adsp-pil: adsp-pil supply px not found, using dummy regulator qcom_adsp_pil adsp-pil: no fatal IRQ defined remoteproc remoteproc0: releasing adsp-pil mmc0: new HS200 MMC card at address 0001 mmcblk0: mmc0:0001 SEM16G 14.7 GiB mmcblk0boot0: mmc0:0001 SEM16G partition 1 4.00 MiB mmcblk0boot1: mmc0:0001 SEM16G partition 2 4.00 MiB mmcblk0rpmb: mmc0:0001 SEM16G partition 3 4.00 MiB, chardev (247:0) random: fast init done mmcblk0: p1 p2 p3 p4 p5 p6 p7 p8 p9 p10 p11 p12 p13 p14 p15 p16 p17 p18 p19 p20 mmc1: new ultra high speed DDR50 SDHC card at address aaaa mmcblk1: mmc1:aaaa SU16G 14.8 GiB mmcblk1: p1 qcom_adsp_pil adsp-pil: adsp-pil supply px not found, using dummy regulator qcom_adsp_pil adsp-pil: no fatal IRQ defined remoteproc remoteproc0: releasing adsp-pil qcom_adsp_pil adsp-pil: adsp-pil supply px not found, using dummy regulator qcom_adsp_pil adsp-pil: no fatal IRQ defined remoteproc remoteproc0: releasing adsp-pil Attempt to mount partitions: /usr/system /usr/data Mounting partitions from: /dev/mmcblk0 EXT4-fs (mmcblk0p12): mounted filesystem with ordered data mode. Opts: (null) EXT4-fs (mmcblk0p13): recovery complete EXT4-fs (mmcblk0p13): mounted filesystem with ordered data mode. Opts: (null) / # / # / #