From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A67D6C48BE8 for ; Wed, 16 Jun 2021 18:16:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8206A613DF for ; Wed, 16 Jun 2021 18:16:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231739AbhFPSS5 (ORCPT ); Wed, 16 Jun 2021 14:18:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48244 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231613AbhFPSS4 (ORCPT ); Wed, 16 Jun 2021 14:18:56 -0400 Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com [IPv6:2a00:1450:4864:20::129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 43CB1C06175F for ; Wed, 16 Jun 2021 11:16:49 -0700 (PDT) Received: by mail-lf1-x129.google.com with SMTP id r5so5828127lfr.5 for ; Wed, 16 Jun 2021 11:16:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=W2b2jFEehNknJRq+OcnVlifnQjPyUsywazDun11Qz00=; b=RbIa8yy5N57ekFnm44RR4Wz17v63PQuvQ7iuEyEsAzjhP2pXfbm8K1mWUT9rce4TZ/ E4KCWV3OWpfaA5Pki/doXwe5mXERlsCV49sfaeOZA7QiVRDQllM1bDlHVUQVwecGkpuB dAzqFbFNzFZRmagp0n0ESxf9CFGvY0lzvVnHHeb85GNZ2ba5Wz8jNOUfna3EKvpNMbPs jqbldkb5/5/1dUvQflwHc/hIHSJmPdAB9JGFjDxTYQQ+i5xCABXBNAJUre80xaUIp2TD Zb+6T1o/qGNN7HC1z+f//GpSaLto9lB1n5U+inX4YE/MiBCLymnLkwW+Vqf0PJnmx4He IKYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=W2b2jFEehNknJRq+OcnVlifnQjPyUsywazDun11Qz00=; b=lbEPKdjCP3xszTG9VSOWifa49pYWnY9W892xFhVTvGIquu3sbOthOlUfxa98nYfvyw PTThEvHcIKPM/GbQqjCV7JCjRo4AKkGKpkh9erPm5dU/Wh/auIg9aqbGTLtvzB+3QPXf /UMgORG3ZbrwEQk2PsRTbPnGh85YNOLclOs/0aHQ0F26ZQetF0Y1r77c4Le4utPX4b4z JDxBf7ZrpwwWJTS4MBYpp9TD2sZxIDgzD/iFoG2an6X0I/reJ1breGVdEXk2IrR3l+8J cHmYQxFHg+epW458j/Akj/HIYustRhwHK34KFH6ExyjyDlCf35sRILP1dnimLEZcdQR8 vlTg== X-Gm-Message-State: AOAM533zqsFd0s2FZ46lzOmV2TE0slT9a6NpZFWnYosBvw7bPrCH4yiq Ufy6/Ax40y8UyIRMlNKkVMZ/XQ== X-Google-Smtp-Source: ABdhPJyeUC5P2zVYSmtzIgWA4NvoIF5no5BuhXQhyQPVwfntBDU2HrGn40e9WtI3xYkaEMbQa9s24w== X-Received: by 2002:a19:8c58:: with SMTP id i24mr709113lfj.121.1623867406491; Wed, 16 Jun 2021 11:16:46 -0700 (PDT) Received: from [192.168.88.254] ([85.249.44.185]) by smtp.gmail.com with ESMTPSA id s28sm367049ljc.34.2021.06.16.11.16.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Jun 2021 11:16:45 -0700 (PDT) Subject: Re: [PATCH 00/17] CAMSS: SM8250 support (and some fixes) To: Jonathan Marek , linux-arm-msm@vger.kernel.org Cc: robert.foss@linaro.org, Andy Gross , Bjorn Andersson , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Hans Verkuil , open list , "open list:QUALCOMM CAMERA SUBSYSTEM DRIVER" , Mauro Carvalho Chehab , Rob Herring , Todor Tomov References: <20210608223513.23193-1-jonathan@marek.ca> From: Andrey Konovalov Message-ID: <7a9b847c-34b8-c9ca-8232-88b6ecb23ff5@linaro.org> Date: Wed, 16 Jun 2021 21:16:42 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210608223513.23193-1-jonathan@marek.ca> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi Jonathan, I've given this patchset a try on RB3 board (SDM845) with ov8856 camera sensor - works OK, no regressions. Thanks, Andrey On 09.06.2021 01:34, Jonathan Marek wrote: > This adds initial support for SM8250 and its 4 VFEs and 6 CSIPHYs. > The only big change is the added camss-vfe-480.c to support the > Titan 480 VFE. > > v2: > - Fixed some typos in commit messages (patches 02 and 08) > - patch 03 ("media: camss: csiphy-3ph: add support for SM8250 CSI DPHY"): > - moved definition of CAMSS_8250 to this patch, > - removed unused lane_enable variable > - added a default unreachable case to avoid a warning > - added a is_gen2 variable (minor rework) > - Undo DECODE_FORMAT_PAYLOAD_ONLY change, add comment instead (patch 04) > - "ops" reworks in addition to removing dead code (patch 12) > - renamed csid-170 to csid-gen2, added defines for offsets, add missing > camnoc_axi clock to sm8250 vfe resources (patch 16/17) > > Jonathan Marek (17): > media: camss: csiphy-3ph: don't print HW version as an error > media: camss: csiphy-3ph: disable interrupts > media: camss: csiphy-3ph: add support for SM8250 CSI DPHY > media: camss: csid-170: fix non-10bit formats > media: camss: csid-170: don't enable unused irqs > media: camss: csid-170: remove stray comment > media: camss: csid-170: support more than one lite vfe > media: camss: csid-170: set the right HALT_CMD when disabled > media: camss: csid: allow csid to work without a regulator > media: camss: remove vdda-csiN from sdm845 resources > media: camss: fix VFE irq name > media: camss: remove some vfe ops and clean up dead vfe-170 code > media: camss: vfe-170: fix "VFE halt timeout" error > media: camss: Add initial support for VFE hardware version Titan 480 > media: camss: add support for V4L2_PIX_FMT_GREY for sdm845 HW > media: camss: add support for SM8250 camss > media: dt-bindings: media: camss: Add qcom,sm8250-camss binding > > .../bindings/media/qcom,sm8250-camss.yaml | 399 +++++++++++++ > drivers/media/platform/qcom/camss/Makefile | 3 +- > .../{camss-csid-170.c => camss-csid-gen2.c} | 32 +- > .../media/platform/qcom/camss/camss-csid.c | 45 +- > .../media/platform/qcom/camss/camss-csid.h | 2 +- > .../qcom/camss/camss-csiphy-3ph-1-0.c | 184 ++++-- > .../media/platform/qcom/camss/camss-csiphy.c | 9 +- > .../media/platform/qcom/camss/camss-vfe-170.c | 101 +--- > .../media/platform/qcom/camss/camss-vfe-4-1.c | 25 +- > .../media/platform/qcom/camss/camss-vfe-4-7.c | 63 +- > .../media/platform/qcom/camss/camss-vfe-4-8.c | 65 +-- > .../media/platform/qcom/camss/camss-vfe-480.c | 545 ++++++++++++++++++ > .../platform/qcom/camss/camss-vfe-gen1.c | 94 +-- > .../platform/qcom/camss/camss-vfe-gen1.h | 39 +- > drivers/media/platform/qcom/camss/camss-vfe.c | 29 +- > drivers/media/platform/qcom/camss/camss-vfe.h | 17 +- > .../media/platform/qcom/camss/camss-video.c | 5 +- > drivers/media/platform/qcom/camss/camss.c | 205 ++++++- > drivers/media/platform/qcom/camss/camss.h | 1 + > 19 files changed, 1523 insertions(+), 340 deletions(-) > create mode 100644 Documentation/devicetree/bindings/media/qcom,sm8250-camss.yaml > rename drivers/media/platform/qcom/camss/{camss-csid-170.c => camss-csid-gen2.c} (95%) > create mode 100644 drivers/media/platform/qcom/camss/camss-vfe-480.c >