From: David Ahern <dsahern@gmail.com>
To: Petr Machata <petrm@nvidia.com>, netdev@vger.kernel.org
Cc: Stephen Hemminger <stephen@networkplumber.org>,
Tariq Toukan <tariqt@nvidia.com>,
Itay Aveksis <itayav@nvidia.com>
Subject: Re: [PATCH iproute2-next v2] ip: Fix rx_otherhost_dropped support
Date: Fri, 1 Jul 2022 08:42:18 -0600 [thread overview]
Message-ID: <7a9cc617-c903-d9e7-9120-649a3bab86c6@gmail.com> (raw)
In-Reply-To: <4148bef3a4e4f259aa9fa7936062a4416a035fec.1656411498.git.petrm@nvidia.com>
On 6/28/22 4:19 AM, Petr Machata wrote:
> The commit cited below added a new column to print_stats64(). However it
> then updated only one size_columns() call site, neglecting to update the
> remaining three. As a result, in those not-updated invocations,
> size_columns() now accesses a vararg argument that is not being passed,
> which is undefined behavior.
>
> Fixes: cebf67a35d8a ("show rx_otherehost_dropped stat in ip link show")
> CC: Tariq Toukan <tariqt@nvidia.com>
> CC: Itay Aveksis <itayav@nvidia.com>
> Signed-off-by: Petr Machata <petrm@nvidia.com>
> ---
>
> Notes:
> v2:
> - Adjust to changes in the "32-bit quantity" patch
> - Tweak the commit message for clarity
>
> ip/ipaddress.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
I merged main into next and now this one needs to be rebased.
next prev parent reply other threads:[~2022-07-01 14:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-28 10:19 [PATCH iproute2-next v2] ip: Fix rx_otherhost_dropped support Petr Machata
2022-07-01 14:42 ` David Ahern [this message]
2022-07-06 12:42 ` Petr Machata
2022-07-06 14:52 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7a9cc617-c903-d9e7-9120-649a3bab86c6@gmail.com \
--to=dsahern@gmail.com \
--cc=itayav@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=petrm@nvidia.com \
--cc=stephen@networkplumber.org \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.