From: Jan Kiszka <jan.kiszka@siemens.com>
To: Hongzhan Chen <hongzhan.chen@intel.com>, xenomai@xenomai.org
Subject: Re: [PATCH V2 0/3] add support for cherryview gpio controller driver
Date: Tue, 31 Aug 2021 09:15:37 +0200 [thread overview]
Message-ID: <7a9dbf0d-2270-4beb-1680-c48a3686b88b@siemens.com> (raw)
In-Reply-To: <20210831050736.5371-1-hongzhan.chen@intel.com>
On 31.08.21 07:07, Hongzhan Chen via Xenomai wrote:
> 1. move out of OF config conditional compilation so that non-OF platform
> call same API to remove rtdm gpio chip device and remove _of for api
> name.
> 2. Introduce helper to find gpiochip as referring to pair of
> rtdm_gpiochip_scan_of and rtdm_gpiochip_scan_array_of.
> 3. Add Intel Cherryview pinctrl driver based on on 1 and 2.
>
> I also did following tests with this patchset:
> 1. run /usr/lib/xenomai/testsuite/gpiobench -i 334 -i 335 -c INT33FF:02
> to validate patch 9afea5ff2d7ba97db96b22a005a9a7fcf5f2d892 when
> setting GPIO_RTIOC_TS
> 2. apply following patch, and rerun 1.
>
> index f83d7689f..50afbd418 100644
> --- a/testsuite/gpiobench/gpiobench.c
> +++ b/testsuite/gpiobench/gpiobench.c
> @@ -619,7 +619,7 @@ int main(int argc, char **argv)
> goto out;
> }
>
> - ret = ioctl(ti.fd_dev_intr, GPIO_RTIOC_TS, &value);
> + ret = ioctl(ti.fd_dev_intr, GPIO_RTIOC_TS_MONO, &value);
> if (ret) {
> printf("ioctl gpio port ts, failed\n");
> goto out;
>
> 3. test result for inner related output:
> REALTIME clock:
> # Total: 000999999
> # Min Latencies: 00013
> # Avg Latencies: 16.879997
> # Max Latencies: 00043
>
> MONO clock:
> # Total: 000083988
> # Min Latencies: 00012
> # Avg Latencies: 2814377.000000
> # Max Latencies: 00041
>
> Hardware env:
> 1. Rock PI X V1.4.
> 2. GPIO loopback connection between GPIO 334 and 335.
>
> Hongzhan Chen (3):
> drivers/gpio: core: Move out of OF config conditional compilation
> drivers/gpio: core: Introduce helper to find gpiochip
> driver/gpio: Add Intel Cherryview pinctrl driver
>
> include/cobalt/kernel/rtdm/gpio.h | 12 +++++--
> kernel/drivers/gpio/Kconfig | 7 ++++
> kernel/drivers/gpio/Makefile | 2 ++
> kernel/drivers/gpio/gpio-bcm2835.c | 2 +-
> kernel/drivers/gpio/gpio-cherryview.c | 42 ++++++++++++++++++++++
> kernel/drivers/gpio/gpio-core.c | 50 ++++++++++++++++++++++++---
> kernel/drivers/gpio/gpio-mxc.c | 2 +-
> kernel/drivers/gpio/gpio-omap.c | 2 +-
> kernel/drivers/gpio/gpio-sun8i-h3.c | 2 +-
> kernel/drivers/gpio/gpio-xilinx.c | 2 +-
> kernel/drivers/gpio/gpio-zynq7000.c | 2 +-
> 11 files changed, 112 insertions(+), 13 deletions(-)
> create mode 100644 kernel/drivers/gpio/gpio-cherryview.c
>
All three merged, with slight modifications as discussed.
Thanks,
Jan
--
Siemens AG, T RDA IOT
Corporate Competence Center Embedded Linux
prev parent reply other threads:[~2021-08-31 7:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-31 5:07 [PATCH V2 0/3] add support for cherryview gpio controller driver Hongzhan Chen
2021-08-31 5:07 ` [PATCH 1/3] drivers/gpio: core: Move out of OF config conditional compilation Hongzhan Chen
2021-08-31 13:05 ` Jan Kiszka
2021-09-01 1:16 ` Chen, Hongzhan
2021-08-31 5:07 ` [PATCH 2/3] drivers/gpio: core: Introduce helper to find gpiochip Hongzhan Chen
2021-08-31 6:47 ` Jan Kiszka
2021-08-31 7:07 ` Chen, Hongzhan
2021-08-31 7:14 ` Jan Kiszka
2021-08-31 5:07 ` [PATCH 3/3] driver/gpio: Add Intel Cherryview pinctrl driver Hongzhan Chen
2021-08-31 6:51 ` Jan Kiszka
2021-08-31 7:15 ` Jan Kiszka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7a9dbf0d-2270-4beb-1680-c48a3686b88b@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=hongzhan.chen@intel.com \
--cc=xenomai@xenomai.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.