From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A94EC04FF3 for ; Mon, 24 May 2021 11:38:51 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 370A361028 for ; Mon, 24 May 2021 11:38:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 370A361028 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1ll8v2-0007ZE-K0; Mon, 24 May 2021 11:38:48 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ll8v0-0007Yk-TL for linux-f2fs-devel@lists.sourceforge.net; Mon, 24 May 2021 11:38:46 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:To:Subject:Sender:Reply-To:Cc: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ccCVINMdZ87xx/ThsWfN3Vi3IqJG+aNAuxRQK8LESak=; b=TW8Hvd5/Vmq6lijYFo5HeBIPBz 4Mmy92zr4Xjvc8zG2xjutHXjVlWsvqRn6/DO4GV70maA3ZBnsPAXhxx5cA/re8Luie3DWc7Z7vnaZ 2NNwAfl9Q+UMKAwQVcGE+h9An/PNaJoI972nF/otcqhQr97X7j9XUWOfbbnb4HUaE1oI=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Sender:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=ccCVINMdZ87xx/ThsWfN3Vi3IqJG+aNAuxRQK8LESak=; b=nS8H8/xP9TDbsd/qUt+BH7bCl0 WgKA0aBFqbyJyDBmvU0+EZJmO85EU9Z4fXbasHG0jYAq8Ke3tMw1MkuyJlMVpyaffjsGJpQ819PSl 4i30ato+lfAZQDaxP7KXBm0XAvCCkw6ccg/eC11ZdZ+LOCuAiRP6fmD/S+cgufzKykJU=; Received: from szxga05-in.huawei.com ([45.249.212.191]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1ll8uw-0048Fz-9J for linux-f2fs-devel@lists.sourceforge.net; Mon, 24 May 2021 11:38:47 +0000 Received: from dggems703-chm.china.huawei.com (unknown [172.30.72.58]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4FpZs972tWzkYlL; Mon, 24 May 2021 19:35:41 +0800 (CST) Received: from dggemx753-chm.china.huawei.com (10.0.44.37) by dggems703-chm.china.huawei.com (10.3.19.180) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2176.2; Mon, 24 May 2021 19:38:32 +0800 Received: from [10.136.110.154] (10.136.110.154) by dggemx753-chm.china.huawei.com (10.0.44.37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Mon, 24 May 2021 19:38:31 +0800 To: Fengnan Chang , , , References: <20210518125113.1712-1-changfengnan@vivo.com> From: Chao Yu Message-ID: <7ad8bae8-6e38-5ff7-add8-fe1023569f43@huawei.com> Date: Mon, 24 May 2021 19:38:31 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20210518125113.1712-1-changfengnan@vivo.com> Content-Language: en-US X-Originating-IP: [10.136.110.154] X-ClientProxiedBy: dggemx702-chm.china.huawei.com (10.1.199.49) To dggemx753-chm.china.huawei.com (10.0.44.37) X-CFilter-Loop: Reflected X-Headers-End: 1ll8uw-0048Fz-9J Subject: Re: [f2fs-dev] [RFC PATCH] f2fs: compress: remove unneeded read when rewrite whole cluster X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 2021/5/18 20:51, Fengnan Chang wrote: > For now,when overwrite compressed file, we need read old data to page > cache first and update pages. > But when we need overwrite whole cluster, we don't need old data > anymore. I only see you just check the whole page was dirty as below rather than the whole cluster is dirty during write(). Thanks, > + if (len == PAGE_SIZE) > + return 0; > /* compressed case */ > prealloc = (ret < cc->cluster_size); > _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel