From: Vlastimil Babka <vbabka@suse.cz>
To: glittao@gmail.com, brendanhiggins@google.com, cl@linux.com,
penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com,
akpm@linux-foundation.org
Cc: linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
kunit-dev@googlegroups.com, linux-mm@kvack.org, elver@google.com,
dlatypov@google.com
Subject: Re: [PATCH v5 1/3] kunit: make test->lock irq safe
Date: Wed, 12 May 2021 12:28:34 +0200 [thread overview]
Message-ID: <7ae6e0a1-8a4c-02b0-e26d-2d6a5f107506@suse.cz> (raw)
In-Reply-To: <20210511150734.3492-1-glittao@gmail.com>
On 5/11/21 5:07 PM, glittao@gmail.com wrote:
> From: Vlastimil Babka <vbabka@suse.cz>
>
> The upcoming SLUB kunit test will be calling kunit_find_named_resource() from
> a context with disabled interrupts. That means kunit's test->lock needs to be
> IRQ safe to avoid potential deadlocks and lockdep splats.
>
> This patch therefore changes the test->lock usage to spin_lock_irqsave()
> and spin_unlock_irqrestore().
>
> Signed-off-by: Vlastimil Babka <vbabka@suse.cz>
> Signed-off-by: Oliver Glitta <glittao@gmail.com>
Note v4 had
Reviewed-by: Brendan Higgins <brendanhiggins@google.com>
and it's unchanged AFAIK.
prev parent reply other threads:[~2021-05-12 10:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-11 15:07 [PATCH v5 1/3] kunit: make test->lock irq safe glittao
2021-05-11 15:07 ` [PATCH v5 2/3] mm/slub, kunit: add a KUnit test for SLUB debugging functionality glittao
2021-05-11 15:16 ` Marco Elver
2021-05-11 15:16 ` Marco Elver
2021-05-12 10:30 ` Vlastimil Babka
2021-05-12 10:30 ` Vlastimil Babka
2021-05-12 12:24 ` Oliver Glitta
2021-05-12 14:06 ` [PATCH] mm/slub, kunit: add a KUnit test for SLUB debugging functionality-fix glittao
2021-05-13 4:44 ` [PATCH v5 2/3] mm/slub, kunit: add a KUnit test for SLUB debugging functionality Andrew Morton
2021-05-13 8:54 ` Marco Elver
2021-05-13 8:54 ` Marco Elver
2021-05-13 9:32 ` Oliver Glitta
2021-05-13 9:32 ` Oliver Glitta
2021-05-11 15:07 ` [PATCH v5 3/3] slub: remove resiliency_test() function glittao
2021-05-12 10:28 ` Vlastimil Babka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ae6e0a1-8a4c-02b0-e26d-2d6a5f107506@suse.cz \
--to=vbabka@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=brendanhiggins@google.com \
--cc=cl@linux.com \
--cc=dlatypov@google.com \
--cc=elver@google.com \
--cc=glittao@gmail.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=kunit-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.