From: "Christian König" <deathsimple-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org>
To: Monk Liu <Monk.Liu-5C7GfCeVMHo@public.gmane.org>,
amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: Re: [PATCH 3/4] drm/amdgpu:only call flr_work under infinite timeout
Date: Mon, 8 May 2017 11:11:29 +0200 [thread overview]
Message-ID: <7ae97dfa-96bd-414b-0ace-ddf4e626440d@vodafone.de> (raw)
In-Reply-To: <1494226269-8837-4-git-send-email-Monk.Liu-5C7GfCeVMHo@public.gmane.org>
Am 08.05.2017 um 08:51 schrieb Monk Liu:
> Change-Id: I541aa5109f4fcab06ece4761a09dc7e053ec6837
> Signed-off-by: Monk Liu <Monk.Liu@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/mxgpu_vi.c | 15 +++++++++------
> 1 file changed, 9 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/mxgpu_vi.c b/drivers/gpu/drm/amd/amdgpu/mxgpu_vi.c
> index 1cdf5cc..0109b5c 100644
> --- a/drivers/gpu/drm/amd/amdgpu/mxgpu_vi.c
> +++ b/drivers/gpu/drm/amd/amdgpu/mxgpu_vi.c
> @@ -537,12 +537,15 @@ static int xgpu_vi_mailbox_rcv_irq(struct amdgpu_device *adev,
> {
> int r;
>
> - /* see what event we get */
> - r = xgpu_vi_mailbox_rcv_msg(adev, IDH_FLR_NOTIFICATION);
> -
> - /* only handle FLR_NOTIFY now */
> - if (!r)
> - schedule_work(&adev->virt.flr_work);
> + /* trigger gpu-reset by hypervisor only if TDR disbaled */
> + if (msecs_to_jiffies(amdgpu_lockup_timeout) == MAX_SCHEDULE_TIMEOUT) {
That won't work like this, we use zero for infinite timeout here. See
amdgpu_fence_driver_init_ring() as well.
Just changing that test to "amdgpu_lockup_timeout == 0" should work.
Christian.
> + /* see what event we get */
> + r = xgpu_vi_mailbox_rcv_msg(adev, IDH_FLR_NOTIFICATION);
> +
> + /* only handle FLR_NOTIFY now */
> + if (!r)
> + schedule_work(&adev->virt.flr_work);
> + }
>
> return 0;
> }
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2017-05-08 9:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-08 6:51 [PATCH 0/4] TDR guilty job feature Monk Liu
[not found] ` <1494226269-8837-1-git-send-email-Monk.Liu-5C7GfCeVMHo@public.gmane.org>
2017-05-08 6:51 ` [PATCH 1/4] drm/amdgpu:don't invoke srio-gpu-reset in gpu-reset Monk Liu
[not found] ` <1494226269-8837-2-git-send-email-Monk.Liu-5C7GfCeVMHo@public.gmane.org>
2017-05-08 9:07 ` Christian König
[not found] ` <4d4fb987-9ccb-8fde-e485-7586f6ec49e8-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org>
2017-05-08 9:10 ` Liu, Monk
[not found] ` <DM5PR12MB16103A41862C9FCFF923295384EE0-2J9CzHegvk++jCVTvoAFKAdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2017-05-08 9:19 ` Christian König
[not found] ` <707273ff-6cf7-4d86-bbe4-7cebe928840d-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org>
2017-05-08 9:24 ` Liu, Monk
[not found] ` <DM5PR12MB1610A94BDEBFCAB42975560B84EE0-2J9CzHegvk++jCVTvoAFKAdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2017-05-08 9:33 ` Christian König
[not found] ` <3290f7e0-56a7-98e0-db60-0ce968cd65e5-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org>
2017-05-08 9:42 ` Liu, Monk
[not found] ` <DM5PR12MB1610851C6F0BDD8FAC54DE1284EE0-2J9CzHegvk++jCVTvoAFKAdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2017-05-08 9:50 ` Christian König
2017-05-08 6:51 ` [PATCH 2/4] drm/amdgpu:use job* to replace voluntary Monk Liu
[not found] ` <1494226269-8837-3-git-send-email-Monk.Liu-5C7GfCeVMHo@public.gmane.org>
2017-05-08 9:08 ` Christian König
2017-05-08 6:51 ` [PATCH 3/4] drm/amdgpu:only call flr_work under infinite timeout Monk Liu
[not found] ` <1494226269-8837-4-git-send-email-Monk.Liu-5C7GfCeVMHo@public.gmane.org>
2017-05-08 9:11 ` Christian König [this message]
[not found] ` <7ae97dfa-96bd-414b-0ace-ddf4e626440d-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org>
2017-05-08 9:15 ` Liu, Monk
2017-05-08 6:51 ` [PATCH 4/4] drm/amdgpu/SRIOV:implement guilty job TDR for Monk Liu
[not found] ` <1494226269-8837-5-git-send-email-Monk.Liu-5C7GfCeVMHo@public.gmane.org>
2017-05-08 7:00 ` Liu, Monk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ae97dfa-96bd-414b-0ace-ddf4e626440d@vodafone.de \
--to=deathsimple-antagkrnahcb1svskn2v4q@public.gmane.org \
--cc=Monk.Liu-5C7GfCeVMHo@public.gmane.org \
--cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.