From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 3A02BC43334
	for <linux-kernel@archiver.kernel.org>; Tue, 19 Jul 2022 15:27:21 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S231176AbiGSP05 (ORCPT <rfc822;linux-kernel@archiver.kernel.org>);
        Tue, 19 Jul 2022 11:26:57 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57386 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S233950AbiGSP0t (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 19 Jul 2022 11:26:49 -0400
X-Greylist: delayed 367 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Tue, 19 Jul 2022 08:26:48 PDT
Received: from smtp74.iad3a.emailsrvr.com (smtp74.iad3a.emailsrvr.com [173.203.187.74])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BE330402EA
        for <linux-kernel@vger.kernel.org>; Tue, 19 Jul 2022 08:26:48 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=openvpn.net;
        s=20170822-45nk5nwl; t=1658244040;
        bh=adV58vm7/tjy+kwDeEpAfKovQjvWtkBDSOIQUg1vwNc=;
        h=Date:Subject:To:From:From;
        b=ujRI5ngutfmpo214226g48qNhkxDHOgiKqZQ2aUfjg8tEBd2Wtf7Nf5DBo2NbTZu6
         09kkqwsVYT9lK1cIJzurRErST8ZTKzTE/Y9tUF7pJNNHsl9H4Ql+FpjCWVFdY/Ljfy
         FR+y17lGx+y6J8vVqbvjPemSN48eNs/XeYFgjfU4=
X-Auth-ID: antonio@openvpn.net
Received: by smtp10.relay.iad3a.emailsrvr.com (Authenticated sender: antonio-AT-openvpn.net) with ESMTPSA id 129CA62BC;
        Tue, 19 Jul 2022 11:20:39 -0400 (EDT)
Message-ID: <7aeaf711-c18f-3442-be44-d820f2539a15@openvpn.net>
Date:   Tue, 19 Jul 2022 17:21:23 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [RFC 1/1] net: introduce OpenVPN Data Channel Offload (ovpn-dco)
Content-Language: en-US
To:     Andrew Lunn <andrew@lunn.ch>
Cc:     netdev@vger.kernel.org, David Miller <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>, linux-kernel@vger.kernel.org
References: <20220719014704.21346-1-antonio@openvpn.net>
 <20220719014704.21346-2-antonio@openvpn.net> <YtbLa54+0A4SyR9+@lunn.ch>
From:   Antonio Quartulli <antonio@openvpn.net>
Organization: OpenVPN Inc.
In-Reply-To: <YtbLa54+0A4SyR9+@lunn.ch>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Classification-ID: d2ebcfec-646c-42bf-a8b6-56f2520d45a0-1-1
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 19/07/2022 17:19, Andrew Lunn wrote:
> As a general comment throughout the code, pr_ functions are not
> liked. Since this is a network device, it would be better to use
> netdev_debug(), netdev_warn() etc, so indicating which device is
> outputting warnings or debug info.

Thanks for the hint, Andrew!
I will convert the pr_* calls to netdev_*.

Regards,

-- 
Antonio Quartulli
OpenVPN Inc.