From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 006F8C282DF for ; Fri, 19 Apr 2019 18:24:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C387120652 for ; Fri, 19 Apr 2019 18:24:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KEyc0JG/" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727623AbfDSSY2 (ORCPT ); Fri, 19 Apr 2019 14:24:28 -0400 Received: from mail-pf1-f195.google.com ([209.85.210.195]:33646 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727401AbfDSSY0 (ORCPT ); Fri, 19 Apr 2019 14:24:26 -0400 Received: by mail-pf1-f195.google.com with SMTP id h5so2892554pfo.0 for ; Fri, 19 Apr 2019 11:24:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:openpgp:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=eaTnFsb5QnqPcIb8xjSh53tSyaJ5lJOuh8alskMGaLc=; b=KEyc0JG/5jaEZYE3Kq3XS67YzrjfDU5OwUBDMZx5zUbijHEioNI3fvsinhHudHtKpe oQupehx1EgtHsqOsYWLIv06C6O0GLC3Fm/mrovX4TJa8BnXP4uPHW0xHdTNmv482LYB4 GlP9V0ExLM5h21x1ScSs9oSdR3/CBsf2Y7t6C1AEBEcRdeVhnm32Ybwt8bOEY+nsocB7 XPU3wFF4u3ci/psIMSb3PWHddpG6h493jeiUQJB4zH2ilcguNQUQNWggJJ4sX0srfr3m XfyXoNSE/RSWX+3imdJ9GVfAiAzFJtjKZluKThxnjcAUU+11dZkiYlUnyUjkIE4YqtXU ytPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=eaTnFsb5QnqPcIb8xjSh53tSyaJ5lJOuh8alskMGaLc=; b=ph59NECCYOCmucyDno/JYX6m9eW1JPXuqYblidFkxqBPf3N4h7FOgPev8XYUBwqEef Cj+ZGaoeT3JrXCu9bBa4N9WlqgVytdsfWz+Xw65nOmWrtmAjvaeXY3FEJSnr4ytBg5P3 1us3vlAznmMyJkH2San6T4PMsmP/LShBntMuRCuNGY6UiGZqhp1XqUUmQUvQd16sr7ov HGdz0k8Z4pAg5zZcHLHWuqCokck1FQCRSUWSddRaWb24HNQIau+R0kZL52jN4qBQewvs ou1LG2xyC6U/Yg8smUbWhS5augyBOfxVBEBv79pU/Vnk7Y5MaTQtfQslbcMBwsohgYpw HULw== X-Gm-Message-State: APjAAAX6cEYmufrJDRjijSSRiy5wZr+iyL5ffe0hb1Hvm/g70UfdXTpy I1QGjCj4KXA+Xjnr9gfvrlieyaG2 X-Google-Smtp-Source: APXvYqwHn0rzwyHgmtKeYrcNpK9FaMBvYkDs+TEIcRF/fcws/NmdK49wVfU7F0XkrNQwnxzvb59KBg== X-Received: by 2002:a63:5c56:: with SMTP id n22mr4562094pgm.108.1555687921970; Fri, 19 Apr 2019 08:32:01 -0700 (PDT) Received: from [192.168.1.3] (ip68-101-123-102.oc.oc.cox.net. [68.101.123.102]) by smtp.gmail.com with ESMTPSA id l2sm5668496pgl.2.2019.04.19.08.32.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 19 Apr 2019 08:32:01 -0700 (PDT) Subject: Re: [PATCH net-next 10/15] dsa: Rename dsa_resolve_tag_protocol() to _get ready for locking To: Andrew Lunn , David Miller Cc: netdev , Vivien Didelot References: <20190418023120.17067-1-andrew@lunn.ch> <20190418023120.17067-11-andrew@lunn.ch> From: Florian Fainelli Openpgp: preference=signencrypt Message-ID: <7af3a6e2-5287-746f-538a-016de0cb3bdf@gmail.com> Date: Fri, 19 Apr 2019 08:31:59 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190418023120.17067-11-andrew@lunn.ch> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 4/17/2019 7:31 PM, Andrew Lunn wrote: > dsa_resolve_tag_protocol() is used to find the tagging driver needed > by a switch driver. When the tagging drivers become modules, it will > be necassary to take a reference on the module to prevent it being > unloaded. So rename this function to _get() to indicate it has some > locking properties. > > Signed-off-by: Andrew Lunn Reviewed-by: Florian Fainelli -- Florian