From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.9 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6ACC8C47082 for ; Thu, 3 Jun 2021 14:59:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5231B601FA for ; Thu, 3 Jun 2021 14:59:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231931AbhFCPAp (ORCPT ); Thu, 3 Jun 2021 11:00:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50230 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231411AbhFCPAp (ORCPT ); Thu, 3 Jun 2021 11:00:45 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 42989C06174A for ; Thu, 3 Jun 2021 07:59:00 -0700 (PDT) Received: from gallifrey.ext.pengutronix.de ([2001:67c:670:201:5054:ff:fe8d:eefb] helo=[IPv6:::1]) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1loooE-0002s8-PC; Thu, 03 Jun 2021 16:58:58 +0200 Subject: Re: [PATCH] ARM: dts: stm32: set stm32mp157c-odyssey DCMI pins To: Grzegorz Szymaszek , Alexandre Torgue , Maxime Coquelin , Marcin Sloniewski , Rob Herring , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com References: From: Ahmad Fatoum Message-ID: <7af54c28-1cc1-775e-a544-45a0f5f9957e@pengutronix.de> Date: Thu, 3 Jun 2021 16:58:57 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: a.fatoum@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03.06.21 16:49, Grzegorz Szymaszek wrote: > Hello Ahmad, > > On Thu, Jun 03, 2021 at 04:26:59PM +0200, Ahmad Fatoum wrote: >> On 03.06.21 16:23, Grzegorz Szymaszek wrote: >>> The Seeed Odyssey-STM32MP157C board has a 20-pin DVP camera output. >>> stm32mp15-pinctrl.dtsi contains one pin state definition for the DCMI >>> interface, dcmi-0, AKA phandle dcmi_pins_a. This definition is >>> incompatible with the pins used on the Odyssey board, where: >>> - there are 8 data pins instead of 12, >>> - […] >>> >>> Override the dcmi_pins_a definition (as well as dcmi_sleep_pins_a) in >>> the Odyssey device tree. >> >> Rather define a new pinctrl group (e.g. &dcmi_pins_b) and use that >> instead of overriding an existing one. > > Can I simply use dcmi_pins_b (as the first unused identifier) or is > there some way to match specific pin groups to an identifier (b, c, d, > and so on)? Just take the next available. That's how I did it so far. >> Current convention is also to place all STM32MP1 pinctrl nodes into >> a central file, not in the individual board device trees. > > Sure, I will update the patch. > > Thanks for your comments! Cheers, Ahmad -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11843C47082 for ; Thu, 3 Jun 2021 15:00:47 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C630E613E9 for ; Thu, 3 Jun 2021 15:00:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C630E613E9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=ekjmK++qgPJ/y0dS+UinvGjFkz7sCDkchNKFCdpU1NA=; b=4ZkZzazM6OMe5LNLYobevvuXJz IQIecxxkdexN2ilC9EnLKeHIU85uOfXfdUlJ2N/kvLU5v0NnCqWr2MQK9MDwLKshCuIxQlrGMjLxE PIZzX+00WEod7rPZK7FLqIU87ROcwtoviWSN+LXqaO9C1a5fZBHzjmVBW5v9MAxdq5Zw00D1dk4zx IhWi0SaMbJpf2l5XFWK9TV5qWFbxy9wweuVaoNFM9IpLNoJs1yO3brYUUWS3trcNNH+hKLWNii3+k 3uCknBRRErkwKKzYZlrHgjhZZEkXU0+b4kbVAFwf0qg+e2F4r8jMIpyY/dAROIxJu+FQ+I4OYPlus R0/LyOqw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1loooK-009Gdo-AB; Thu, 03 Jun 2021 14:59:04 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1loooG-009Gd1-Jo for linux-arm-kernel@lists.infradead.org; Thu, 03 Jun 2021 14:59:02 +0000 Received: from gallifrey.ext.pengutronix.de ([2001:67c:670:201:5054:ff:fe8d:eefb] helo=[IPv6:::1]) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1loooE-0002s8-PC; Thu, 03 Jun 2021 16:58:58 +0200 Subject: Re: [PATCH] ARM: dts: stm32: set stm32mp157c-odyssey DCMI pins To: Grzegorz Szymaszek , Alexandre Torgue , Maxime Coquelin , Marcin Sloniewski , Rob Herring , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com References: From: Ahmad Fatoum Message-ID: <7af54c28-1cc1-775e-a544-45a0f5f9957e@pengutronix.de> Date: Thu, 3 Jun 2021 16:58:57 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.2 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: a.fatoum@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210603_075900_677474_C12CC191 X-CRM114-Status: GOOD ( 22.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMDMuMDYuMjEgMTY6NDksIEdyemVnb3J6IFN6eW1hc3playB3cm90ZToKPiBIZWxsbyBBaG1h ZCwKPiAKPiBPbiBUaHUsIEp1biAwMywgMjAyMSBhdCAwNDoyNjo1OVBNICswMjAwLCBBaG1hZCBG YXRvdW0gd3JvdGU6Cj4+IE9uIDAzLjA2LjIxIDE2OjIzLCBHcnplZ29yeiBTenltYXN6ZWsgd3Jv dGU6Cj4+PiBUaGUgU2VlZWQgT2R5c3NleS1TVE0zMk1QMTU3QyBib2FyZCBoYXMgYSAyMC1waW4g RFZQIGNhbWVyYSBvdXRwdXQuCj4+PiBzdG0zMm1wMTUtcGluY3RybC5kdHNpIGNvbnRhaW5zIG9u ZSBwaW4gc3RhdGUgZGVmaW5pdGlvbiBmb3IgdGhlIERDTUkKPj4+IGludGVyZmFjZSwgZGNtaS0w LCBBS0EgcGhhbmRsZSBkY21pX3BpbnNfYS4gVGhpcyBkZWZpbml0aW9uIGlzCj4+PiBpbmNvbXBh dGlibGUgd2l0aCB0aGUgcGlucyB1c2VkIG9uIHRoZSBPZHlzc2V5IGJvYXJkLCB3aGVyZToKPj4+ IC0gdGhlcmUgYXJlIDggZGF0YSBwaW5zIGluc3RlYWQgb2YgMTIsCj4+PiAtIFvigKZdCj4+Pgo+ Pj4gT3ZlcnJpZGUgdGhlIGRjbWlfcGluc19hIGRlZmluaXRpb24gKGFzIHdlbGwgYXMgZGNtaV9z bGVlcF9waW5zX2EpIGluCj4+PiB0aGUgT2R5c3NleSBkZXZpY2UgdHJlZS4KPj4KPj4gUmF0aGVy IGRlZmluZSBhIG5ldyBwaW5jdHJsIGdyb3VwIChlLmcuICZkY21pX3BpbnNfYikgYW5kIHVzZSB0 aGF0Cj4+IGluc3RlYWQgb2Ygb3ZlcnJpZGluZyBhbiBleGlzdGluZyBvbmUuCj4gCj4gQ2FuIEkg c2ltcGx5IHVzZSBkY21pX3BpbnNfYiAoYXMgdGhlIGZpcnN0IHVudXNlZCBpZGVudGlmaWVyKSBv ciBpcwo+IHRoZXJlIHNvbWUgd2F5IHRvIG1hdGNoIHNwZWNpZmljIHBpbiBncm91cHMgdG8gYW4g aWRlbnRpZmllciAoYiwgYywgZCwKPiBhbmQgc28gb24pPwoKSnVzdCB0YWtlIHRoZSBuZXh0IGF2 YWlsYWJsZS4gVGhhdCdzIGhvdyBJIGRpZCBpdCBzbyBmYXIuCgo+PiBDdXJyZW50IGNvbnZlbnRp b24gaXMgYWxzbyB0byBwbGFjZSBhbGwgU1RNMzJNUDEgcGluY3RybCBub2RlcyBpbnRvCj4+IGEg Y2VudHJhbCBmaWxlLCBub3QgaW4gdGhlIGluZGl2aWR1YWwgYm9hcmQgZGV2aWNlIHRyZWVzLgo+ IAo+IFN1cmUsIEkgd2lsbCB1cGRhdGUgdGhlIHBhdGNoLgo+IAo+IFRoYW5rcyBmb3IgeW91ciBj b21tZW50cyEKCkNoZWVycywKQWhtYWQKCi0tIApQZW5ndXRyb25peCBlLksuICAgICAgICAgICAg ICAgICAgICAgICAgICAgfCAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfApTdGV1ZXJ3YWxk ZXIgU3RyLiAyMSAgICAgICAgICAgICAgICAgICAgICAgfCBodHRwOi8vd3d3LnBlbmd1dHJvbml4 LmRlLyAgfAozMTEzNyBIaWxkZXNoZWltLCBHZXJtYW55ICAgICAgICAgICAgICAgICAgfCBQaG9u ZTogKzQ5LTUxMjEtMjA2OTE3LTAgICAgfApBbXRzZ2VyaWNodCBIaWxkZXNoZWltLCBIUkEgMjY4 NiAgICAgICAgICAgfCBGYXg6ICAgKzQ5LTUxMjEtMjA2OTE3LTU1NTUgfAoKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWls aW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0 cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=