All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Paul Barker <paul.barker@sancloud.com>,
	Matt Madison <matt@madison.systems>,
	 openembedded-core@lists.openembedded.org
Cc: Joshua Watt <jpewhacker@gmail.com>
Subject: Re: [OE-core][PATCH 0/4] Move crate fetcher to OE_IMPORTS
Date: Mon, 20 Dec 2021 22:34:44 +0000	[thread overview]
Message-ID: <7b0757495eff0e466dc84cb82f597e4c28256061.camel@linuxfoundation.org> (raw)
In-Reply-To: <100ff0ce-72e1-b3b3-ff1e-2a56e0742624@sancloud.com>

On Mon, 2021-12-20 at 17:01 +0000, Paul Barker wrote:
> On 17/12/2021 15:36, Matt Madison wrote:
> > This patch series switches to using the OE_IMPORTS mechanism
> > for installing the crate fetcher. This simplifies the addition
> > and clears up issues with interactions between SRCPV and
> > the shared-state fetching logic.
> > 
> > Matt Madison (4):
> >    lib/crate.py: install crate fetcher on import
> >    base.bbclass: add crate to OE_IMPORTS
> >    cargo_common.bbclass: remove inherit of crate-fetch
> >    classes: remove crate-fetch.bbclass
> > 
> >   meta/classes/base.bbclass         |  2 +-
> >   meta/classes/cargo_common.bbclass |  2 --
> >   meta/classes/crate-fetch.bbclass  | 28 ----------------------------
> >   meta/lib/crate.py                 |  2 ++
> >   4 files changed, 3 insertions(+), 31 deletions(-)
> >   delete mode 100644 meta/classes/crate-fetch.bbclass
> > 
> 
> Would a better solution here be to move the crate fetcher into
> lib/bb/fetch2/ in bitbake?

I've been wondering about this too.

Does anyone remember how the fetcher lines up against the general fetcher
requirements we have and is there a list of anything that remained to be done
before it could be added to bitbake?

Cheers,

Richard



  reply	other threads:[~2021-12-20 22:34 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-17 15:36 [OE-core][PATCH 0/4] Move crate fetcher to OE_IMPORTS Matt Madison
2021-12-17 15:36 ` [OE-core][PATCH 1/4] lib/crate.py: install crate fetcher on import Matt Madison
2021-12-17 15:36 ` [OE-core][PATCH 2/4] base.bbclass: add crate to OE_IMPORTS Matt Madison
2021-12-17 16:37   ` Alexander Kanavin
2021-12-20 15:34     ` Matt Madison
2021-12-17 15:36 ` [OE-core][PATCH 3/4] cargo_common.bbclass: remove inherit of crate-fetch Matt Madison
2021-12-17 15:36 ` [OE-core][PATCH 4/4] classes: remove crate-fetch.bbclass Matt Madison
2021-12-20 17:01 ` [OE-core][PATCH 0/4] Move crate fetcher to OE_IMPORTS Paul Barker
2021-12-20 22:34   ` Richard Purdie [this message]
2021-12-21 14:07     ` Paul Barker
2021-12-21 18:14       ` Matt Madison
     [not found]       ` <16C2D7CF44733347.22520@lists.openembedded.org>
2022-01-14 10:31         ` Matt Madison
2022-01-14 13:17           ` Richard Purdie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7b0757495eff0e466dc84cb82f597e4c28256061.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=jpewhacker@gmail.com \
    --cc=matt@madison.systems \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=paul.barker@sancloud.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.