From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v2 1/2] net/avf: fix unused variables and
	label
Date: Tue, 18 Sep 2018 14:51:27 +0100
Message-ID: <7b1032a7-78e4-019e-ccba-3e1e5488bc56@intel.com>
References: <20180913144405.72772-1-bruce.richardson@intel.com>
 <20180918131726.60303-1-bruce.richardson@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org, bluca@debian.org, Qi Zhang <qi.z.zhang@intel.com>,
 stable@dpdk.org
To: Bruce Richardson <bruce.richardson@intel.com>,
 Jingjing Wu <jingjing.wu@intel.com>, Wenzhuo Lu <wenzhuo.lu@intel.com>
Return-path: <dev-bounces@dpdk.org>
In-Reply-To: <20180918131726.60303-1-bruce.richardson@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 9/18/2018 2:17 PM, Bruce Richardson wrote:
> Compiling with all warnings turned on causes errors about unused variables
> and an unused label. Remove these to allow building without having to
> disable those warnings.
> 
> Fixes: 69dd4c3d0898 ("net/avf: enable queue and device")
> Fixes: 3fd7a3719c66 ("net/avf: enable ops for MTU setting")
> Fixes: d6bde6b5eae9 ("net/avf: enable Rx interrupt")
> Fixes: 22b123a36d07 ("net/avf: initialize PMD")
> Fixes: 319c421f3890 ("net/avf: enable SSE Rx Tx")
> Fixes: a2b29a7733ef ("net/avf: enable basic Rx Tx")>
> CC: stable@dpdk.org
> 
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> Acked-by: Luca Boccassi <bluca@debian.org>

<...>

> @@ -1268,7 +1266,6 @@ static inline uint16_t
>  rx_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)
>  {
>  	struct avf_rx_queue *rxq = (struct avf_rx_queue *)rx_queue;
> -	struct rte_eth_dev *dev;

Fixes: 1060591eada5 ("net/avf: enable bulk allocate Rx")

>  	uint16_t nb_rx = 0;
>  
>  	if (!nb_pkts)
> @@ -1584,10 +1581,6 @@ avf_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)
>  
>  		if (nb_ctx) {
>  			/* Setup TX context descriptor if required */
> -			volatile struct avf_tx_context_desc *ctx_txd =
> -				(volatile struct avf_tx_context_desc *)
> -					&txr[tx_id];

ctx_txd seems used in below macro controlled by DEBUG_DUMP_DESC define
AVF_DUMP_TX_DESC(txq, ctx_txd, tx_id);