All of
 help / color / mirror / Atom feed
From: Bruno Piazera Larsen <>
To: David Gibson <>
Subject: Re: [PATCH v4 1/5] target/ppc: moved ppc_cpu_do_interrupt to cpu.c
Date: Tue, 25 May 2021 08:08:54 -0300	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <YKyGjNzW1A+7RXsd@yekko>

[-- Attachment #1: Type: text/plain, Size: 1395 bytes --]

On 25/05/2021 02:09, David Gibson wrote:
> On Mon, May 24, 2021 at 10:59:04AM -0300, Bruno Larsen (billionai) wrote:
>> Moved the ppc_cpu_do_interrupt function to cpu.c file, where it makes
>> more sense, and turned powerpc_excp not static, as it now needs to be
>> accessed from outside of excp_helper.c
>> Signed-off-by: Bruno Larsen (billionai)
>> <>
> Looking at this again, I'm inclined to agree with Richard: I don't see
> a lot of point to this.  It's not really clear to me that these belong
> more in cpu.c than in excp_helper.c, and I believe we're already
> expecting to need excp_helper.c (or at least parts of it) for !TCG
> builds.

yeah, now that I look at it, I agree too. This was in my mind (or code, 
can't remember) before we agreed that excp_helper needed to be compiled, 
so I went ahead and posted it because it was here all along.

While we compile excp_helper, there isn't really a point. I think there 
was a plan to remove or improve excp_helper, so could be something we 
come back to later, but for now I'll remove from the patch series

Bruno Piazera Larsen
Instituto de Pesquisas ELDORADO 
Departamento Computação Embarcada
Analista de Software Trainee
Aviso Legal - Disclaimer <>

[-- Attachment #2: Type: text/html, Size: 2136 bytes --]

  reply	other threads:[~2021-05-25 11:10 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-24 13:59 [PATCH v4 0/5] target/ppc: add support to disable-tcg Bruno Larsen (billionai)
2021-05-24 13:59 ` [PATCH v4 1/5] target/ppc: moved ppc_cpu_do_interrupt to cpu.c Bruno Larsen (billionai)
2021-05-25  5:09   ` David Gibson
2021-05-25 11:08     ` Bruno Piazera Larsen [this message]
2021-05-24 13:59 ` [PATCH v4 2/5] target/ppc: used ternary operator when registering MAS Bruno Larsen (billionai)
2021-05-24 17:32   ` Richard Henderson
2021-05-25  5:10     ` David Gibson
2021-05-24 13:59 ` [PATCH v4 3/5] target/ppc: added ifdefs around TCG-only code Bruno Larsen (billionai)
2021-05-24 13:59 ` [PATCH v4 4/5] target/ppc: created tcg-stub.c file Bruno Larsen (billionai)
2021-05-24 13:59 ` [PATCH v4 5/5] target/ppc: updated to support disable-tcg Bruno Larsen (billionai)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH v4 1/5] target/ppc: moved ppc_cpu_do_interrupt to cpu.c' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.