From: Jeff Johnson <quic_jjohnson@quicinc.com>
To: Andrew Morton <akpm@linux-foundation.org>,
ALOK JHA <alok08jha@gmail.com>
Cc: "Gustavo A. R. Silva" <gustavo@embeddedor.com>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Michal Marek <michal.lkml@markovi.net>,
"Kees Cook" <keescook@chromium.org>,
<linux-kbuild@vger.kernel.org>
Subject: Re: [PATCH] Makefile: Globally enable fall-through warning
Date: Tue, 17 May 2022 12:40:25 -0700 [thread overview]
Message-ID: <7b3e919a-4660-e477-b4bd-a92c28b174fb@quicinc.com> (raw)
In-Reply-To: <20220517114601.55016e298905d6b6aa0fa873@linux-foundation.org>
On 5/17/2022 11:46 AM, Andrew Morton wrote:
> On Tue, 17 May 2022 23:05:34 +0530 ALOK JHA <alok08jha@gmail.com> wrote:
>
>> From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
>>
>> Now that all the fall-through warnings have been addressed in the
>> kernel, enable the fall-through warning globally.
>>
>> Also, update the deprecated.rst file to include implicit fall-through
>> as 'deprecated' so people can be pointed to a single location for
>> justification.
>>
>> ...
>>
>> --- a/Documentation/process/deprecated.rst
>> +++ b/Documentation/process/deprecated.rst
>> @@ -119,3 +119,17 @@ array may exceed the remaining memory in the stack segment. This could
>> lead to a crash, possible overwriting sensitive contents at the end of the
>> stack (when built without `CONFIG_THREAD_INFO_IN_TASK=y`), or overwriting
>> memory adjacent to the stack (when built without `CONFIG_VMAP_STACK=y`)
>> +
>> +Implicit switch case fall-through
>> +---------------------------------
>>
>> ...
>>
>
> Documentation/process/deprecated.rst already has a section "Implicit
> switch case fall-through". Maybe you're working against an old kernel.
> Please update when resending.
>
shouldn't we now just be referencing the fallthrough() macro?
next prev parent reply other threads:[~2022-05-17 19:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-17 17:35 [PATCH] Makefile: Globally enable fall-through warning ALOK JHA
2022-05-17 18:42 ` Andrew Morton
2022-05-17 18:46 ` Andrew Morton
2022-05-17 19:40 ` Jeff Johnson [this message]
2022-05-17 19:59 ` Gustavo A. R. Silva
-- strict thread matches above, loose matches on Subject: below --
2019-07-28 13:58 Guenter Roeck
2019-07-28 16:42 ` Gustavo A. R. Silva
2019-07-28 17:14 ` Guenter Roeck
2019-07-28 17:31 ` Gustavo A. R. Silva
2019-07-28 18:12 ` Guenter Roeck
2019-07-29 8:22 ` Geert Uytterhoeven
2019-07-29 14:42 ` Gustavo A. R. Silva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b3e919a-4660-e477-b4bd-a92c28b174fb@quicinc.com \
--to=quic_jjohnson@quicinc.com \
--cc=akpm@linux-foundation.org \
--cc=alok08jha@gmail.com \
--cc=gustavo@embeddedor.com \
--cc=keescook@chromium.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=michal.lkml@markovi.net \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.