From: Thomas Huth <thuth@redhat.com>
To: Greg Kurz <groug@kaod.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 2/2] virtfs: Fix documentation of -fsdev and -virtfs
Date: Fri, 17 May 2019 15:22:48 +0200 [thread overview]
Message-ID: <7b4b93c9-761b-edbb-4538-b4e549afd48e@redhat.com> (raw)
In-Reply-To: <20190517151711.7262e276@bahia.lan>
On 17/05/2019 15.17, Greg Kurz wrote:
> On Mon, 13 May 2019 12:34:10 +0200
> Greg Kurz <groug@kaod.org> wrote:
>
>> This fixes several things:
>> - add "id" description to -virtfs documentation
>> - split the description into several lines in both usage and documentation
>> for accurateness and clarity
>> - add documentation and usage of the synth fsdriver
>> - add "throttling.*" description to -fsdev local
>> - add some missing periods
>> - add proper reference to the virtfs-proxy-helper(1) manual page
>> - document that the virtio device may be either virtio-9p-pci, virtio-9p-ccw
>> or virtio-9p-device, depending on the machine type
>>
>> Buglink: https://bugs.launchpad.net/qemu/+bug/1581976
>> Signed-off-by: Greg Kurz <groug@kaod.org>
>> ---
>> v2: - mention virtfs-proxy-helper(1) change in the changelog
>> - mention virtio-9p-ccw and virtio-9p-device
>> ---
>
> Thomas,
>
> Unless you (or anyone else) have some objections, I intend to apply this patch
> and issue a pull request in a near future.
Fine for me - I just lack the detailed 9p knowledge to provide a real
"Reviewed-by" here, I hope you were not waiting for it? ... but if it
helps, I can at least say:
Acked-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2019-05-17 13:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-13 10:33 [Qemu-devel] [PATCH v2 0/2] fsdev/virtfs: Assorted cleanups and fixes Greg Kurz
2019-05-13 10:34 ` [Qemu-devel] [PATCH v2 1/2] vl: Deprecate -virtfs_synth Greg Kurz
2019-05-14 10:04 ` Thomas Huth
2019-05-13 10:34 ` [Qemu-devel] [PATCH v2 2/2] virtfs: Fix documentation of -fsdev and -virtfs Greg Kurz
2019-05-17 13:17 ` Greg Kurz
2019-05-17 13:22 ` Thomas Huth [this message]
2019-05-17 15:20 ` Greg Kurz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b4b93c9-761b-edbb-4538-b4e549afd48e@redhat.com \
--to=thuth@redhat.com \
--cc=groug@kaod.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.