From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758920AbdKPLyE (ORCPT ); Thu, 16 Nov 2017 06:54:04 -0500 Received: from mout.web.de ([212.227.17.12]:51592 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934252AbdKPLx5 (ORCPT ); Thu, 16 Nov 2017 06:53:57 -0500 Subject: [PATCH 2/3] ALSA: korg1212: Delete a duplicate function call "release_firmware" in snd_korg1212_create() From: SF Markus Elfring To: alsa-devel@alsa-project.org, Alexey Dobriyan , Andrew Morton , Bhumika Goyal , Jaroslav Kysela , Kees Cook , Takashi Iwai Cc: LKML , kernel-janitors@vger.kernel.org References: <3f68211d-51f0-2990-d711-44eaeb85ba4d@users.sourceforge.net> Message-ID: <7b5b034c-e441-f363-a94f-c81bd0b5ed7a@users.sourceforge.net> Date: Thu, 16 Nov 2017 12:52:41 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <3f68211d-51f0-2990-d711-44eaeb85ba4d@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:TEvo0GTtjjBEBrSHSM3KjOjlwYzxPT8kIDHPNsEKMzJcO7r3lM2 sekYN8r/r68EGrbkwzAW4CmXBaqittYSdfmpEjgK5WtqGcsnKmu1SYxSnNwbn4bqUYZsYgz UAADtp2WoNeV+P8pugR6dKrjVwcX/sTwfLI7F9NHYaa5yUaWxmi0GNB0Z6TFVRxIDMCFVjD pbCP+AcT/tpiVtjukmV2Q== X-UI-Out-Filterresults: notjunk:1;V01:K0:OpPBzRBvwEE=:XXohVABmh12fPjLcLmZC7j xpWIGrdS6BF0xom/qUvtNsPrgqPdxtCfeJQWbHMiMQ22HhwhdtmsLlcTV8a0J2irjb7Lj9bzU F94NWFG5mwHMg8lFtiX9R1QU/gtq6Rad55jfhAeqC4dtv2NTYBLEGkdfr8v72d8vsBqQm7Y8C q13iSxhcRcem+2invwIxijWM9sJ4zXs3Cu74/2JeQ4P1EWCBPbs43VhjJw6fEEz34owFw6WJ1 BJknloHs3h7U9uYXblEkUNtoqxDp85AuahAqPywfDNGgcJdvEPYg11zqaUftzhr5lD0Q1H2SJ D4QYxb3mS5dD8JBH94HwXxwLc2+19WzG+43tQNhoMokABTJSGzeNNmY4IIDMdxFGuqiEUq931 XTBNHAjEn8zbVAOmiDtLQiEhKLXaHseA5OFN5ERCQdMYbqUvcspVrizGTseuIDlW8MhfSQNcw vihRSdFtZtze7lqbAbwXigmLTWE3tmsNJoQa5e0edbnjBaF4PH1cBmP4iR5HY5IJ2JLIyFwYB KiGpsl9yGmuPtCeh3RomYMJIRJT0l/v9KeHWLqIfXwYgIUjsylhjh+mMyZtxwgsdzmu2qnLUM GFoqg83OLiEDJIMgMV9ZY/Pvwgfxw/QpVJi2QLGQ9FV93I7vIrgLFQD9uc/oYUBmeB2skTroo 0rlS4VC6vBH8dBgcpKdm+clGCvltB5elvy0/YYJlX5RXokMqZThdXfs5/iX4hayOAtiq2AA29 cJEJnBkocGh8hY0YUDKuDAatdYkDmX4B8+F9QL+z00OgvCeB5rcM9tTxcgSBNndHP34uW0cud 9pjDcqFrEA7GFPnb/fmoz0Frke+zKZQdXoKqUB2ekHz5CfsXjk= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Thu, 16 Nov 2017 11:22:26 +0100 The function "release_firmware" is called in the current implementation of the function "_request_firmware" after a failure was detected. Link: https://elixir.free-electrons.com/linux/v4.14-rc8/source/drivers/base/firmware_class.c#L1196 Such a call should therefore not be repeated directly after the corresponding error information was received in the local variable "err" of the function "snd_korg1212_create". Thus remove a misplaced function call. Signed-off-by: Markus Elfring --- sound/pci/korg1212/korg1212.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/pci/korg1212/korg1212.c b/sound/pci/korg1212/korg1212.c index 6dde8c215b48..dc701519d219 100644 --- a/sound/pci/korg1212/korg1212.c +++ b/sound/pci/korg1212/korg1212.c @@ -2352,7 +2352,6 @@ static int snd_korg1212_create(struct snd_card *card, struct pci_dev *pci, err = request_firmware(&dsp_code, "korg/k1212.dsp", &pci->dev); if (err < 0) { - release_firmware(dsp_code); snd_printk(KERN_ERR "firmware not available\n"); snd_korg1212_free(korg1212); return err; -- 2.15.0 From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Date: Thu, 16 Nov 2017 11:52:41 +0000 Subject: [PATCH 2/3] ALSA: korg1212: Delete a duplicate function call "release_firmware" in snd_korg1212_crea Message-Id: <7b5b034c-e441-f363-a94f-c81bd0b5ed7a@users.sourceforge.net> List-Id: References: <3f68211d-51f0-2990-d711-44eaeb85ba4d@users.sourceforge.net> In-Reply-To: <3f68211d-51f0-2990-d711-44eaeb85ba4d@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: alsa-devel@alsa-project.org, Alexey Dobriyan , Andrew Morton , Bhumika Goyal , Jaroslav Kysela , Kees Cook , Takashi Iwai Cc: kernel-janitors@vger.kernel.org, LKML From: Markus Elfring Date: Thu, 16 Nov 2017 11:22:26 +0100 The function "release_firmware" is called in the current implementation of the function "_request_firmware" after a failure was detected. Link: https://elixir.free-electrons.com/linux/v4.14-rc8/source/drivers/base/firmware_class.c#L1196 Such a call should therefore not be repeated directly after the corresponding error information was received in the local variable "err" of the function "snd_korg1212_create". Thus remove a misplaced function call. Signed-off-by: Markus Elfring --- sound/pci/korg1212/korg1212.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/pci/korg1212/korg1212.c b/sound/pci/korg1212/korg1212.c index 6dde8c215b48..dc701519d219 100644 --- a/sound/pci/korg1212/korg1212.c +++ b/sound/pci/korg1212/korg1212.c @@ -2352,7 +2352,6 @@ static int snd_korg1212_create(struct snd_card *card, struct pci_dev *pci, err = request_firmware(&dsp_code, "korg/k1212.dsp", &pci->dev); if (err < 0) { - release_firmware(dsp_code); snd_printk(KERN_ERR "firmware not available\n"); snd_korg1212_free(korg1212); return err; -- 2.15.0 From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Subject: [PATCH 2/3] ALSA: korg1212: Delete a duplicate function call "release_firmware" in snd_korg1212_create() Date: Thu, 16 Nov 2017 12:52:41 +0100 Message-ID: <7b5b034c-e441-f363-a94f-c81bd0b5ed7a@users.sourceforge.net> References: <3f68211d-51f0-2990-d711-44eaeb85ba4d@users.sourceforge.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mout.web.de (mout.web.de [212.227.17.12]) by alsa0.perex.cz (Postfix) with ESMTP id 9753B266EE4 for ; Thu, 16 Nov 2017 12:53:20 +0100 (CET) In-Reply-To: <3f68211d-51f0-2990-d711-44eaeb85ba4d@users.sourceforge.net> Content-Language: en-GB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: alsa-devel@alsa-project.org, Alexey Dobriyan , Andrew Morton , Bhumika Goyal , Jaroslav Kysela , Kees Cook , Takashi Iwai Cc: kernel-janitors@vger.kernel.org, LKML List-Id: alsa-devel@alsa-project.org From: Markus Elfring Date: Thu, 16 Nov 2017 11:22:26 +0100 The function "release_firmware" is called in the current implementation of the function "_request_firmware" after a failure was detected. Link: https://elixir.free-electrons.com/linux/v4.14-rc8/source/drivers/base/firmware_class.c#L1196 Such a call should therefore not be repeated directly after the corresponding error information was received in the local variable "err" of the function "snd_korg1212_create". Thus remove a misplaced function call. Signed-off-by: Markus Elfring --- sound/pci/korg1212/korg1212.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/pci/korg1212/korg1212.c b/sound/pci/korg1212/korg1212.c index 6dde8c215b48..dc701519d219 100644 --- a/sound/pci/korg1212/korg1212.c +++ b/sound/pci/korg1212/korg1212.c @@ -2352,7 +2352,6 @@ static int snd_korg1212_create(struct snd_card *card, struct pci_dev *pci, err = request_firmware(&dsp_code, "korg/k1212.dsp", &pci->dev); if (err < 0) { - release_firmware(dsp_code); snd_printk(KERN_ERR "firmware not available\n"); snd_korg1212_free(korg1212); return err; -- 2.15.0