From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1852BC4338F for ; Mon, 9 Aug 2021 23:50:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EF8F460E78 for ; Mon, 9 Aug 2021 23:50:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233236AbhHIXvH (ORCPT ); Mon, 9 Aug 2021 19:51:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60714 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231127AbhHIXvH (ORCPT ); Mon, 9 Aug 2021 19:51:07 -0400 Received: from mail-oi1-x234.google.com (mail-oi1-x234.google.com [IPv6:2607:f8b0:4864:20::234]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EE66CC0613D3; Mon, 9 Aug 2021 16:50:45 -0700 (PDT) Received: by mail-oi1-x234.google.com with SMTP id bi32so2328936oib.2; Mon, 09 Aug 2021 16:50:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=CwKNOnnzAd5qosOD7HgKOb5hYzfIZY7Sz4p7lyYQkDQ=; b=Aw1PwLw9e6HEVLxXhk3SYCBTevOdoaIoFpu5z454kaPWRiGrPfArMajweYsgcLKbzk Imp4itmpEiA+3FGketSR7PifxV6klN1X7wdOV8tp5BICwZtSPUnkFUYUnhH/puiFckkW 1owHYvHPyAoPARvslIafJjcn/4RIdhVJ0Bc32zc71tDqTV5oykqqsJOgtUfcqJitBWVL RghRsH8xnfUNvK2oQlex1pdgJooRD0CQeGSABCvcUkkILPupJIlrkitKO/7TGNzA/ZGH I6qV0Qvj260FojJGnK5wmkBtJSht0PHFoI81D06mAQCrIiQVUGxwBN0BD7p3xBiDmVeK z5Mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=CwKNOnnzAd5qosOD7HgKOb5hYzfIZY7Sz4p7lyYQkDQ=; b=SY0FCAMT5ZBUDy+qJVPEXfoUlk91UISAgZ/A6gjFLXlAO5jCzJzQK+BuQ1H19Q/+wz 7nuY0EEI02k87pBiKU3+WK+rdw6jbumbTo4GscoWzIodmOgUsY6YIDNngo5iIzO5ApG9 HQWAIGf8HqbolfjFmIluKOVD8i1/EtKjvhzRNxzSYKI4wbd0oqMP9P6skI0yhlvUg67C JVwXO0LyH/VyIHNlbLvhdrIfR9BN/Drhp5geXSjkGina8EpwhTytcz2N6QdtBezKeRDn V6X3WrLg8n2m+s+JjSyrfWIcJZ50XtypAPIKa1MfvgciPshAmwbInVW43eudCXDHc3kn Xl4g== X-Gm-Message-State: AOAM5320w90JMwN74L4oCO5Hlv3gG4ZVOB4qjMKUXHY0U6dix8yqs6PT DKDm7GzEPXRpkYbGekPzfbY= X-Google-Smtp-Source: ABdhPJwKE8xFAwn77y6/BcbWHJp78SYbrn5U/bAujlBDwg0xzY5VcU7KrFg7wdPYJagRGaxULtF8Kw== X-Received: by 2002:a05:6808:601:: with SMTP id y1mr16033359oih.27.1628553045406; Mon, 09 Aug 2021 16:50:45 -0700 (PDT) Received: from ian.penurio.us ([47.184.51.90]) by smtp.gmail.com with ESMTPSA id u8sm496600oiw.52.2021.08.09.16.50.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 Aug 2021 16:50:44 -0700 (PDT) Subject: Re: [RFC PATCH v2 00/10] Add configurable block device LED triggers To: =?UTF-8?Q?Marek_Beh=c3=ban?= , Greg KH , hch@lst.de Cc: pali@kernel.org, linux-block@vger.kernel.org, linux-leds@vger.kernel.org, axboe@kernel.dk, pavel@ucw.cz, linux-kernel@vger.kernel.org, kernelnewbies@kernelnewbies.org References: <20210809033217.1113444-1-arequipeno@gmail.com> <20210809205633.4300bbea@thinkpad> <81c128a1-c1b8-0f1e-a77b-6704bade26c0@gmail.com> <20210810004331.0f0094a5@thinkpad> From: Ian Pilcher Message-ID: <7b5f3509-5bcd-388b-8d3b-4ea95a9483ad@gmail.com> Date: Mon, 9 Aug 2021 18:50:44 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210810004331.0f0094a5@thinkpad> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org On 8/9/21 5:43 PM, Marek Behún wrote: > I confess that I am not very familiar with internal blkdev API. It's mainly a matter of symbol visibility. See this thread from a few months ago: https://www.spinics.net/lists/linux-leds/msg18244.html Now ... my code currently lives in block/, so there isn't actually anything technically preventing it from iterating through the block devices. The reactions to Enzo's patch (which you can see in that thread) make me think that anything that iterates through all block devices is likely to be rejected, but maybe I'm reading too much into it. Greg / Christoph - (As you were the people who expressed disapproval of Enzo's patch to export block_class and disk_type ...) Can you weigh in on the acceptability of iterating through the block devices (searching by name) from LED trigger code within the block subsystem (i.e. no new symbols would need to be exported)? This would allow the trigger to implement the sysfs API that Marek and Pavel want. Thanks! -- ======================================================================== In Soviet Russia, Google searches you! ======================================================================== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45C12C4338F for ; Mon, 9 Aug 2021 23:51:24 +0000 (UTC) Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A131F60EBD for ; Mon, 9 Aug 2021 23:51:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A131F60EBD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kernelnewbies.org Received: from localhost ([::1] helo=shelob.surriel.com) by shelob.surriel.com with esmtp (Exim 4.94.2) (envelope-from ) id 1mDF2j-0005Rt-7C; Mon, 09 Aug 2021 19:50:53 -0400 Received: from mail-oi1-x231.google.com ([2607:f8b0:4864:20::231]) by shelob.surriel.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1mDF2g-0005Rh-Ov for kernelnewbies@kernelnewbies.org; Mon, 09 Aug 2021 19:50:50 -0400 Received: by mail-oi1-x231.google.com with SMTP id o20so26130822oiw.12 for ; Mon, 09 Aug 2021 16:50:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=CwKNOnnzAd5qosOD7HgKOb5hYzfIZY7Sz4p7lyYQkDQ=; b=Aw1PwLw9e6HEVLxXhk3SYCBTevOdoaIoFpu5z454kaPWRiGrPfArMajweYsgcLKbzk Imp4itmpEiA+3FGketSR7PifxV6klN1X7wdOV8tp5BICwZtSPUnkFUYUnhH/puiFckkW 1owHYvHPyAoPARvslIafJjcn/4RIdhVJ0Bc32zc71tDqTV5oykqqsJOgtUfcqJitBWVL RghRsH8xnfUNvK2oQlex1pdgJooRD0CQeGSABCvcUkkILPupJIlrkitKO/7TGNzA/ZGH I6qV0Qvj260FojJGnK5wmkBtJSht0PHFoI81D06mAQCrIiQVUGxwBN0BD7p3xBiDmVeK z5Mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=CwKNOnnzAd5qosOD7HgKOb5hYzfIZY7Sz4p7lyYQkDQ=; b=HfK7HC90qkNgK/BsyNt8ZQUfoecOmhPkujj6bd5ZgwpiZYSes5IfypUnpWUVPvE1T0 X+4GnPxRXapk7TC/6cgY/Lpz2VLjoppieH4eVEKRPfNri8y9NXuWMsPX/cXExsMx6yvU 15Ts5z1E+8VWjev0UsDFKpU+9uAPYYYuTxUpB/OqvsgDkkmjFTm7j2ezC2rJG2lboABL G+N7Vvsj92vyF0+QWxNcre2MG4RqDII/fMsKJIqP0YL6z/iZdxp5E+H4Sm2/Avz+Fsni kltI0EHP3HaVFvZBADxY5UqGEDJ0Yory4QoaAKKIzN83LEF/lGOsWgm8BnL7JThZZXiR 4v7g== X-Gm-Message-State: AOAM531n3gu3a5tpHd7A6tyBwNkGmW0lb+z44dL1wUuCxaWlDsrD56mE DGD22X/+Tjn7a3EQVpp0BJ6qjmI/Yox2rkyD X-Google-Smtp-Source: ABdhPJwKE8xFAwn77y6/BcbWHJp78SYbrn5U/bAujlBDwg0xzY5VcU7KrFg7wdPYJagRGaxULtF8Kw== X-Received: by 2002:a05:6808:601:: with SMTP id y1mr16033359oih.27.1628553045406; Mon, 09 Aug 2021 16:50:45 -0700 (PDT) Received: from ian.penurio.us ([47.184.51.90]) by smtp.gmail.com with ESMTPSA id u8sm496600oiw.52.2021.08.09.16.50.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 Aug 2021 16:50:44 -0700 (PDT) Subject: Re: [RFC PATCH v2 00/10] Add configurable block device LED triggers To: =?UTF-8?Q?Marek_Beh=c3=ban?= , Greg KH , hch@lst.de References: <20210809033217.1113444-1-arequipeno@gmail.com> <20210809205633.4300bbea@thinkpad> <81c128a1-c1b8-0f1e-a77b-6704bade26c0@gmail.com> <20210810004331.0f0094a5@thinkpad> From: Ian Pilcher Message-ID: <7b5f3509-5bcd-388b-8d3b-4ea95a9483ad@gmail.com> Date: Mon, 9 Aug 2021 18:50:44 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210810004331.0f0094a5@thinkpad> Content-Language: en-US Cc: axboe@kernel.dk, kernelnewbies@kernelnewbies.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, pavel@ucw.cz, pali@kernel.org, linux-leds@vger.kernel.org X-BeenThere: kernelnewbies@kernelnewbies.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Learn about the Linux kernel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: kernelnewbies-bounces@kernelnewbies.org T24gOC85LzIxIDU6NDMgUE0sIE1hcmVrIEJlaMO6biB3cm90ZToKPiBJIGNvbmZlc3MgdGhhdCBJ IGFtIG5vdCB2ZXJ5IGZhbWlsaWFyIHdpdGggaW50ZXJuYWwgYmxrZGV2IEFQSS4KCkl0J3MgbWFp bmx5IGEgbWF0dGVyIG9mIHN5bWJvbCB2aXNpYmlsaXR5LiAgU2VlIHRoaXMgdGhyZWFkIGZyb20g YSBmZXcKbW9udGhzIGFnbzoKCiAgIGh0dHBzOi8vd3d3LnNwaW5pY3MubmV0L2xpc3RzL2xpbnV4 LWxlZHMvbXNnMTgyNDQuaHRtbAoKTm93IC4uLiBteSBjb2RlIGN1cnJlbnRseSBsaXZlcyBpbiBi bG9jay8sIHNvIHRoZXJlIGlzbid0IGFjdHVhbGx5CmFueXRoaW5nIHRlY2huaWNhbGx5IHByZXZl bnRpbmcgaXQgZnJvbSBpdGVyYXRpbmcgdGhyb3VnaCB0aGUgYmxvY2sKZGV2aWNlcy4KClRoZSBy ZWFjdGlvbnMgdG8gRW56bydzIHBhdGNoICh3aGljaCB5b3UgY2FuIHNlZSBpbiB0aGF0IHRocmVh ZCkgbWFrZSBtZQp0aGluayB0aGF0IGFueXRoaW5nIHRoYXQgaXRlcmF0ZXMgdGhyb3VnaCBhbGwg YmxvY2sgZGV2aWNlcyBpcyBsaWtlbHkgdG8KYmUgcmVqZWN0ZWQsIGJ1dCBtYXliZSBJJ20gcmVh ZGluZyB0b28gbXVjaCBpbnRvIGl0LgoKCkdyZWcgLyBDaHJpc3RvcGggLQoKKEFzIHlvdSB3ZXJl IHRoZSBwZW9wbGUgd2hvIGV4cHJlc3NlZCBkaXNhcHByb3ZhbCBvZiBFbnpvJ3MgcGF0Y2ggdG8K ZXhwb3J0IGJsb2NrX2NsYXNzIGFuZCBkaXNrX3R5cGUgLi4uKQoKQ2FuIHlvdSB3ZWlnaCBpbiBv biB0aGUgYWNjZXB0YWJpbGl0eSBvZiBpdGVyYXRpbmcgdGhyb3VnaCB0aGUgYmxvY2sKZGV2aWNl cyAoc2VhcmNoaW5nIGJ5IG5hbWUpIGZyb20gTEVEIHRyaWdnZXIgY29kZSB3aXRoaW4gdGhlIGJs b2NrCnN1YnN5c3RlbSAoaS5lLiBubyBuZXcgc3ltYm9scyB3b3VsZCBuZWVkIHRvIGJlIGV4cG9y dGVkKT8KClRoaXMgd291bGQgYWxsb3cgdGhlIHRyaWdnZXIgdG8gaW1wbGVtZW50IHRoZSBzeXNm cyBBUEkgdGhhdCBNYXJlayBhbmQKUGF2ZWwgd2FudC4KClRoYW5rcyEKCi0tIAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KICAgICAgICAgICAgICAgICAgSW4gU292aWV0IFJ1c3NpYSwgR29vZ2xlIHNlYXJjaGVz IHlvdSEKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpLZXJuZWxuZXdiaWVzIG1haWxpbmcgbGlzdApLZXJuZWxuZXdiaWVzQGtl cm5lbG5ld2JpZXMub3JnCmh0dHBzOi8vbGlzdHMua2VybmVsbmV3Ymllcy5vcmcvbWFpbG1hbi9s aXN0aW5mby9rZXJuZWxuZXdiaWVzCg==