Re: [Qemu-devel] [PATCH v3] linux-user: fix to handle variably sized SIOCGSTAMP with new kernels

From: Laurent Vivier <laurent@vivier.eu>
To: qemu-devel@nongnu.org
Cc: "Daniel P . Berrangé" <berrange@redhat.com>,
	"Arnd Bergmann" <arnd@arndb.de>,
	"Gerhard Stenzel" <gerhard.stenzel@de.ibm.com>,
	"Riku Voipio" <riku.voipio@iki.fi>,
	"Christian Ehrhardt" <christian.ehrhardt@canonical.com>,
	"Christian Borntraeger" <borntraeger@de.ibm.com>
Subject: Re: [Qemu-devel] [PATCH v3] linux-user: fix to handle variably sized SIOCGSTAMP with new kernels
Date: Thu, 11 Jul 2019 19:28:09 +0200	[thread overview]
Message-ID: <7b6221eb-2ea6-b0ec-f423-667933143a8f@vivier.eu> (raw)
In-Reply-To: <20190711171556.3377-1-laurent@vivier.eu>

Le 11/07/2019 à 19:15, Laurent Vivier a écrit :
> diff --git a/linux-user/syscall_types.h b/linux-user/syscall_types.h
> index b98a23b0f1b0..584087301edc 100644
> --- a/linux-user/syscall_types.h
> +++ b/linux-user/syscall_types.h
> @@ -20,6 +20,12 @@ STRUCT(timeval,
>  STRUCT(timespec,
>         MK_ARRAY(TYPE_LONG, 2))
>  
> +STRUCT(timeval64,
> +       MK_ARRAY(TYPE_LONGLONG, 2))
> +
> +STRUCT(timespec64,
> +       MK_ARRAY(TYPE_LONGLONG, 2))
> +

kernel type is:

typedef __s64 time64_t;
struct timespec64 {
        time64_t        tv_sec;                 /* seconds */
        long            tv_nsec;                /* nanoseconds */
};

So the definitions from v2 were good:

STRUCT(timeval64, TYPE_LONGLONG, TYPE_LONG)
STRUCT(timespec64, TYPE_LONGLONG, TYPE_LONG)

kernel uses the same type for timeval and timespec.

I send a v4.

Thanks,
Laurent