All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
To: Max Reitz <mreitz@redhat.com>, qemu-block@nongnu.org
Cc: kwolf@redhat.com, jsnow@redhat.com, qemu-devel@nongnu.org
Subject: Re: [PATCH v4 00/10] Further bitmaps improvements
Date: Wed, 11 Mar 2020 09:17:23 +0300	[thread overview]
Message-ID: <7b655cdf-8c54-b10a-4140-2ad083dec75a@virtuozzo.com> (raw)
In-Reply-To: <ca6f95ef-d51f-130a-8ad1-4eba5e0a3528@redhat.com>

10.03.2020 20:17, Max Reitz wrote:
> On 06.03.20 08:45, Vladimir Sementsov-Ogievskiy wrote:
>> 26.02.2020 16:13, Max Reitz wrote:
>>> On 05.02.20 12:20, Vladimir Sementsov-Ogievskiy wrote:
>>>> Hi!
>>>>
>>>> The main feature here is improvement of _next_dirty_area API, which I'm
>>>> going to use then for backup / block-copy.
>>>>
>>>> Somehow, I thought that it was merged, but seems I even forgot to send
>>>> v4.
>>>
>>> The changes from v3 look good to me, but I’d prefer a review from Eric
>>> on patch 8.
>>>
>>
>> Hi!
>>
>> Could you take it now, or do you prefer me to resend?
> 
> I understand that you agreed to drop the comment above
> bd_extent_array_convert_to_be(), then do the
> “s/further call/so further calls/” replacement, and finally replace the
> whole four lines Eric has quoted by “(this ensures that after a failure,
> no further extents can accidentally change the bounds of the last extent
> in the array)”?
> 

Yes, all true.


-- 
Best regards,
Vladimir


  reply	other threads:[~2020-03-11  6:18 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-05 11:20 [PATCH v4 00/10] Further bitmaps improvements Vladimir Sementsov-Ogievskiy
2020-02-05 11:20 ` [PATCH v4 01/10] hbitmap: assert that we don't create bitmap larger than INT64_MAX Vladimir Sementsov-Ogievskiy
2020-02-05 15:14   ` Eric Blake
2020-02-05 11:20 ` [PATCH v4 02/10] hbitmap: move hbitmap_iter_next_word to hbitmap.c Vladimir Sementsov-Ogievskiy
2020-02-05 11:20 ` [PATCH v4 03/10] hbitmap: unpublish hbitmap_iter_skip_words Vladimir Sementsov-Ogievskiy
2020-02-05 11:20 ` [PATCH v4 04/10] hbitmap: drop meta bitmaps as they are unused Vladimir Sementsov-Ogievskiy
2020-02-05 11:20 ` [PATCH v4 05/10] block/dirty-bitmap: switch _next_dirty_area and _next_zero to int64_t Vladimir Sementsov-Ogievskiy
2020-02-26 12:39   ` Max Reitz
2020-02-05 11:20 ` [PATCH v4 06/10] block/dirty-bitmap: add _next_dirty API Vladimir Sementsov-Ogievskiy
2020-02-05 11:20 ` [PATCH v4 07/10] block/dirty-bitmap: improve _next_dirty_area API Vladimir Sementsov-Ogievskiy
2020-02-05 11:20 ` [PATCH v4 08/10] nbd/server: introduce NBDExtentArray Vladimir Sementsov-Ogievskiy
2020-02-26 15:06   ` Eric Blake
2020-02-27 12:46     ` Vladimir Sementsov-Ogievskiy
2020-02-27 13:21       ` Eric Blake
2020-03-06  7:44         ` Vladimir Sementsov-Ogievskiy
2020-02-05 11:20 ` [PATCH v4 09/10] nbd/server: use bdrv_dirty_bitmap_next_dirty_area Vladimir Sementsov-Ogievskiy
2020-02-05 11:20 ` [PATCH v4 10/10] block/qcow2-bitmap: use bdrv_dirty_bitmap_next_dirty Vladimir Sementsov-Ogievskiy
2020-02-26  9:27 ` [PATCH v4 00/10] Further bitmaps improvements Vladimir Sementsov-Ogievskiy
2020-02-26 13:13 ` Max Reitz
2020-03-06  7:45   ` Vladimir Sementsov-Ogievskiy
2020-03-10 17:17     ` Max Reitz
2020-03-11  6:17       ` Vladimir Sementsov-Ogievskiy [this message]
2020-03-11  9:55         ` Max Reitz
2020-03-11 13:58           ` Vladimir Sementsov-Ogievskiy
2020-03-11 17:03             ` John Snow
2020-03-12  5:59               ` Vladimir Sementsov-Ogievskiy
2020-03-12 16:33                 ` John Snow
2020-03-12 20:41                 ` John Snow
2020-03-13  6:43                   ` Vladimir Sementsov-Ogievskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7b655cdf-8c54-b10a-4140-2ad083dec75a@virtuozzo.com \
    --to=vsementsov@virtuozzo.com \
    --cc=jsnow@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.