All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>, qemu-devel@nongnu.org
Subject: Re: [PATCH RESEND v2 00/16] hw: Let DMA/PCI API take MemTxAttrs argument and propagate MemTxResult
Date: Fri, 23 Oct 2020 17:09:52 +0200	[thread overview]
Message-ID: <7b6f9053-206d-f301-808d-d2c990320207@redhat.com> (raw)
In-Reply-To: <e25101fd-5a14-13ff-6e5b-d46b780a8ca5@redhat.com>

Hi Paolo,

On 10/22/20 4:44 PM, Philippe Mathieu-Daudé wrote:
> ping?

In case the rationale is not clear, the motivation
for this series is to make the API more robust to
enforce correct use by the consumers.

Currently the MemTxResult return value is not
propagated, so lost.

If adding the MemTxAttrs argument could introduce
security issues and you need more time to consider
this change, I can repost only the MemTxResult
propagation patches, and we'll discuss the MemTxAttrs
after the 5.2 release.

Laszlo Ersek pointed me to commit f794aa4a2fd
("target-i386: introduce cpu_get_mem_attrs") to
understand how MemTxAttrs is used by SMM on X86.

 From the review comment from Edgar in v1, I understand
there should not be security issues with the current
codebase.
https://www.mail-archive.com/qemu-block@nongnu.org/msg74077.html

Regards,

Phil.

> 
> On 10/1/20 7:25 PM, Philippe Mathieu-Daudé wrote:
>> This is a respin of:
>>
>> "dma: Let the DMA API take MemTxAttrs argument and propagate MemTxResult"
>> https://lists.gnu.org/archive/html/qemu-devel/2020-09/msg02048.html
>>
>> and:
>> "pci: Let PCI DMA API functions propagate a MemTxResult"
>> https://lists.gnu.org/archive/html/qemu-devel/2020-09/msg02048.html
>>
>> (resent using correct git-profile).
>>
>> The DMA API propagates MemTxResult:
>> - MEMTX_OK,
>> - MEMTX_device_ERROR,
>> - MEMTX_DECODE_ERROR.
>>
>> Let the PCI DMA API propagate them, as they are
>> clearer than an undocumented 'int'.
>>
>> Klaus Jensen (1):
>>    pci: pass along the return value of dma_memory_rw
>>
>> Philippe Mathieu-Daudé (15):
>>    docs/devel/loads-stores: Add regexp for DMA functions
>>    dma: Document address_space_map/address_space_unmap() prototypes
>>    dma: Let dma_memory_set() propagate MemTxResult
>>    dma: Let dma_memory_rw() propagate MemTxResult
>>    dma: Let dma_memory_read() propagate MemTxResult
>>    dma: Let dma_memory_write() propagate MemTxResult
>>    dma: Let dma_memory_valid() take MemTxAttrs argument
>>    dma: Let dma_memory_set() take MemTxAttrs argument
>>    dma: Let dma_memory_rw_relaxed() take MemTxAttrs argument
>>    dma: Let dma_memory_rw() take MemTxAttrs argument
>>    dma: Let dma_memory_read/write() take MemTxAttrs argument
>>    dma: Let dma_memory_map() take MemTxAttrs argument
>>    pci: Let pci_dma_rw() propagate MemTxResult
>>    pci: Let pci_dma_read() propagate MemTxResult
>>    pci: Let pci_dma_write() propagate MemTxResult



      reply	other threads:[~2020-10-23 15:25 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-01 17:25 [PATCH RESEND v2 00/16] hw: Let DMA/PCI API take MemTxAttrs argument and propagate MemTxResult Philippe Mathieu-Daudé
2020-10-01 17:25 ` [PATCH RESEND v2 01/16] pci: pass along the return value of dma_memory_rw Philippe Mathieu-Daudé
2020-10-01 17:25 ` [PATCH RESEND v2 02/16] docs/devel/loads-stores: Add regexp for DMA functions Philippe Mathieu-Daudé
2020-10-01 17:25 ` [PATCH RESEND v2 03/16] dma: Document address_space_map/address_space_unmap() prototypes Philippe Mathieu-Daudé
2020-10-01 17:25 ` [PATCH RESEND v2 04/16] dma: Let dma_memory_set() propagate MemTxResult Philippe Mathieu-Daudé
2020-10-01 17:25 ` [PATCH RESEND v2 05/16] dma: Let dma_memory_rw() " Philippe Mathieu-Daudé
2020-10-01 17:25 ` [PATCH RESEND v2 06/16] dma: Let dma_memory_read() " Philippe Mathieu-Daudé
2020-10-01 17:25 ` [PATCH RESEND v2 07/16] dma: Let dma_memory_write() " Philippe Mathieu-Daudé
2020-10-01 17:25 ` [PATCH RESEND v2 08/16] dma: Let dma_memory_valid() take MemTxAttrs argument Philippe Mathieu-Daudé
2020-10-01 17:25 ` [PATCH RESEND v2 09/16] dma: Let dma_memory_set() " Philippe Mathieu-Daudé
2020-10-01 17:25 ` [PATCH RESEND v2 10/16] dma: Let dma_memory_rw_relaxed() " Philippe Mathieu-Daudé
2020-10-01 17:25 ` [PATCH RESEND v2 11/16] dma: Let dma_memory_rw() " Philippe Mathieu-Daudé
2020-10-01 17:25 ` [PATCH RESEND v2 12/16] dma: Let dma_memory_read/write() " Philippe Mathieu-Daudé
2020-10-01 17:25 ` [PATCH RESEND v2 13/16] dma: Let dma_memory_map() " Philippe Mathieu-Daudé
2020-10-01 17:25 ` [PATCH RESEND v2 14/16] pci: Let pci_dma_rw() propagate MemTxResult Philippe Mathieu-Daudé
2020-10-01 17:25 ` [PATCH RESEND v2 15/16] pci: Let pci_dma_read() " Philippe Mathieu-Daudé
2020-10-01 17:25 ` [PATCH RESEND v2 16/16] pci: Let pci_dma_write() " Philippe Mathieu-Daudé
2020-10-22 14:44 ` [PATCH RESEND v2 00/16] hw: Let DMA/PCI API take MemTxAttrs argument and " Philippe Mathieu-Daudé
2020-10-23 15:09   ` Philippe Mathieu-Daudé [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7b6f9053-206d-f301-808d-d2c990320207@redhat.com \
    --to=philmd@redhat.com \
    --cc=edgar.iglesias@xilinx.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.