From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757888AbaKTR3W (ORCPT ); Thu, 20 Nov 2014 12:29:22 -0500 Received: from mail-by2on0085.outbound.protection.outlook.com ([207.46.100.85]:30848 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1757651AbaKTR3S (ORCPT ); Thu, 20 Nov 2014 12:29:18 -0500 Date: Thu, 20 Nov 2014 09:29:08 -0800 From: =?utf-8?B?U8O2cmVu?= Brinkmann To: SF Markus Elfring CC: Michal Simek , , , LKML , , Julia Lawall Subject: Re: [PATCH 1/1] net: Xilinx: Deletion of unnecessary checks before two function calls References: <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <546DF1A2.8090208@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <546DF1A2.8090208@users.sourceforge.net> User-Agent: Mutt/1.5.23 (2014-03-12) X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-7.5.0.1018-21118.001 X-TM-AS-User-Approved-Sender: Yes;Yes Message-ID: <7b7454272cd247c18f32966e78b1b00b@BY2FFO11FD037.protection.gbl> X-EOPAttributedMessage: 0 Authentication-Results: spf=pass (sender IP is 149.199.60.83) smtp.mailfrom=soren.brinkmann@xilinx.com; X-Forefront-Antispam-Report: CIP:149.199.60.83;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(438002)(199003)(51704005)(24454002)(189002)(377424004)(54356999)(85182001)(20776003)(64706001)(85202003)(106466001)(53416004)(77096003)(62966003)(50986999)(120916001)(47776003)(77156002)(46102003)(76176999)(99396003)(83506001)(87936001)(107046002)(4396001)(50466002)(104016003)(19580395003)(23676002)(44976005)(21056001)(102836001)(95666004)(93886004)(19580405001)(31966008)(108616004)(74316001)(110136001)(92566001)(86362001)(6806004)(107986001)(24736002)(23106004);DIR:OUT;SFP:1101;SCL:1;SRVR:BY2FFO11HUB021;H:xsj-pvapsmtpgw01;FPR:;MLV:sfv;PTR:unknown-60-83.xilinx.com;A:1;MX:1;LANG:en; X-Microsoft-Antispam: UriScan:; X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:;SRVR:BY2FFO11HUB021; X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:;SRVR:BY2FFO11HUB021; X-Forefront-PRVS: 0401647B7F X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:;SRVR:BY2FFO11HUB021; X-OriginatorOrg: xilinx.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2014-11-20 at 02:50PM +0100, SF Markus Elfring wrote: > From: Markus Elfring > Date: Thu, 20 Nov 2014 14:47:12 +0100 > > The functions kfree() and of_node_put() test whether their argument is NULL > and then return immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring Reviewed-by: Soren Brinkmann Sören From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?utf-8?B?U8O2cmVu?= Brinkmann Date: Thu, 20 Nov 2014 17:29:08 +0000 Subject: Re: [PATCH 1/1] net: Xilinx: Deletion of unnecessary checks before two function calls Message-Id: <7b7454272cd247c18f32966e78b1b00b@BY2FFO11FD037.protection.gbl> List-Id: References: <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <546DF1A2.8090208@users.sourceforge.net> In-Reply-To: <546DF1A2.8090208@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: linux-arm-kernel@lists.infradead.org On Thu, 2014-11-20 at 02:50PM +0100, SF Markus Elfring wrote: > From: Markus Elfring > Date: Thu, 20 Nov 2014 14:47:12 +0100 >=20 > The functions kfree() and of_node_put() test whether their argument is NU= LL > and then return immediately. Thus the test around the call is not needed. >=20 > This issue was detected by using the Coccinelle software. >=20 > Signed-off-by: Markus Elfring Reviewed-by: Soren Brinkmann S=C3=B6ren -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" = in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: soren.brinkmann@xilinx.com (=?utf-8?B?U8O2cmVu?= Brinkmann) Date: Thu, 20 Nov 2014 09:29:08 -0800 Subject: [PATCH 1/1] net: Xilinx: Deletion of unnecessary checks before two function calls In-Reply-To: <546DF1A2.8090208@users.sourceforge.net> References: <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <546DF1A2.8090208@users.sourceforge.net> Message-ID: <7b7454272cd247c18f32966e78b1b00b@BY2FFO11FD037.protection.gbl> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, 2014-11-20 at 02:50PM +0100, SF Markus Elfring wrote: > From: Markus Elfring > Date: Thu, 20 Nov 2014 14:47:12 +0100 > > The functions kfree() and of_node_put() test whether their argument is NULL > and then return immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring Reviewed-by: Soren Brinkmann S?ren