From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail1.windriver.com (mail1.windriver.com [147.11.146.13]) by mx.groups.io with SMTP id smtpd.web11.5860.1589507577614840794 for ; Thu, 14 May 2020 18:52:57 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: windriver.com, ip: 147.11.146.13, mailfrom: kai.kang@windriver.com) Received: from ALA-HCA.corp.ad.wrs.com (ala-hca.corp.ad.wrs.com [147.11.189.40]) by mail1.windriver.com (8.15.2/8.15.2) with ESMTPS id 04F1qmm5023912 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Thu, 14 May 2020 18:52:48 -0700 (PDT) Received: from [128.224.162.131] (128.224.162.131) by ALA-HCA.corp.ad.wrs.com (147.11.189.50) with Microsoft SMTP Server id 14.3.487.0; Thu, 14 May 2020 18:52:47 -0700 Subject: Re: [OE-core] [PATCH] gcr: depends on gnupg-native To: Alexander Kanavin , Richard Purdie CC: OE-core References: <20200511092342.29197-1-kai.kang@windriver.com> <9c5dcfc03d2670a447cc08565cb74e407211906a.camel@linuxfoundation.org> From: "kai" Message-ID: <7b812b26-39fd-71ab-e84b-fb733659b485@windriver.com> Date: Fri, 15 May 2020 09:51:39 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/alternative; boundary="------------CD311F2F45ED17E05EE15B50" Content-Language: en-US --------------CD311F2F45ED17E05EE15B50 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: quoted-printable X-MIME-Autoconverted: from 8bit to quoted-printable by mail1.windriver.com id 04F1qmm5023912 On 2020/5/15 =E4=B8=8A=E5=8D=881:29, Alexander Kanavin wrote: > Looking gcr's autotools and meson build files, gpg executable is=20 > required in both. Gcr is needed only by epiphany, so I don't think=20 > build performance will suffer much. It seems gcr requires command gpg long long time ago(about 8 years). But= =20 I don't know why just exposed recently. https://gitlab.gnome.org/GNOME/gcr/-/commit/c6691faa0348ab087e99ab9bd9914e= 1d5e81fa14 Regards, Kai > > Alex > > On Thu, 14 May 2020 at 15:26, Richard Purdie=20 > > wrote: > > On Thu, 2020-05-14 at 09:59 +0800, kai wrote: > > On 2020/5/11 =E4=B8=8B=E5=8D=885:23, kai.kang@windriver.com > wrote: > > > From: Kai Kang > > > > > > > It fails to build gcr if no commmand gpg on build host: > > > > > > > meson.build:44:0: ERROR: Program(s) ['gpg2', 'gpg'] not found = or > > > > not executable > > > > > > Add dependency gnupg-native to fix the error. > > > > > > Signed-off-by: Kai Kang > > > > --- > > >=C2=A0 =C2=A0meta/recipes-gnome/gcr/gcr_3.36.0.bb > | 2 +- > > >=C2=A0 =C2=A01 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/meta/recipes-gnome/gcr/gcr_3.36.0.bb > b/meta/recipes- > > > gnome/gcr/gcr_3.36.0.bb > > > index 4fe3b2fff3..458dc8e6c4 100644 > > > --- a/meta/recipes-gnome/gcr/gcr_3.36.0.bb > > > +++ b/meta/recipes-gnome/gcr/gcr_3.36.0.bb > > > @@ -8,7 +8,7 @@ BUGTRACKER =3D " > > > https://gitlab.gnome.org/GNOME/gcr/issues" > > >=C2=A0 =C2=A0LICENSE =3D "GPLv2" > > >=C2=A0 =C2=A0LIC_FILES_CHKSUM =3D > > > "file://COPYING;md5=3D55ca817ccb7d5b5b66355690e9abc605" > > > > > > -DEPENDS =3D "gtk+3 p11-kit glib-2.0 libgcrypt \ > > > +DEPENDS =3D "gtk+3 p11-kit glib-2.0 libgcrypt gnupg-native \ > > >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ${@bb.utils.cont= ains('GI_DATA_ENABLED', 'True', > > > 'libxslt-native', '', d)}" > > > > > >=C2=A0 =C2=A0GNOMEBASEBUILDCLASS =3D "meson" > > > > Any comment, please? > > Why did this happen? Was this as a result of the move to meson? Is i= t > really needed and can we avoid it? native dependencies like this are= a > pain from a build performance perspective... > > Cheers, > > Richard > > =20 > --=20 Kai Kang Wind River Linux --------------CD311F2F45ED17E05EE15B50 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-MIME-Autoconverted: from 8bit to quoted-printable by mail1.windriver.com id 04F1qmm5023912
On 2020/5/15 =E4=B8=8A=E5=8D=881:29, Al= exander Kanavin wrote:
Looking gcr's autotools and meson build files, gpg executable is required in both. Gcr is needed only by epiphany, so I don't think build performance will suffer much.

It seems gcr requires command gpg long long time ago(about 8 years). But I don't know why just exposed recently.

https://gitlab.gnome.org/GNOME/gcr/-/commit/c6691faa034= 8ab087e99ab9bd9914e1d5e81fa14

Regards,
Kai


Alex

On Thu, 14 May 2020 at 15:26= , Richard Purdie <richard.purdie@linuxfoundation.org> wrote:
O= n Thu, 2020-05-14 at 09:59 +0800, kai wrote:
> On 2020/5/11 =E4=B8=8B=E5=8D=885:23, kai.kang@windriver.com wrote:
> > From: Kai Kang <kai.kang@windriver.com>
> >
> > It fails to build gcr if no commmand gpg on build host:
> >
> > > meson.build:44:0: ERROR: Program(s) ['gpg2', 'gpg'] not found or
> > > not executable
> >
> > Add dependency gnupg-native to fix the error.
> >
> > Signed-off-by: Kai Kang <kai.kang@windriver.com>
> > ---
> >=C2=A0 =C2=A0meta/recipes-gnome/gcr/gcr_3.36.0.bb | 2 +-
> >=C2=A0 =C2=A01 file changed, 1 insertion(+), 1 deletion= (-)
> >
> > diff --git a/meta/recipes-gnome/gcr/gcr_3.36.0.bb b/meta/recipes-
> > gnome/gcr/= gcr_3.36.0.bb
> > index 4fe3b2fff3..458dc8e6c4 100644
> > --- a/meta/recipes-gnome/gcr/gcr_3.36.0.bb
> > +++ b/meta/recipes-gnome/gcr/gcr_3.36.0.bb
> > @@ -8,7 +8,7 @@ BUGTRACKER =3D "
> > = https://gitlab.gnome.org/GNOME/gcr/issues"
> >=C2=A0 =C2=A0LICENSE =3D "GPLv2"
> >=C2=A0 =C2=A0LIC_FILES_CHKSUM =3D
> > "file://COPYING;md5=3D55ca817ccb7d5b5b663= 55690e9abc605"
> >=C2=A0 =C2=A0
> > -DEPENDS =3D "gtk+3 p11-kit glib-2.0 libgcrypt \
> > +DEPENDS =3D "gtk+3 p11-kit glib-2.0 libgcrypt gnupg-native \
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ${@bb.= utils.contains('GI_DATA_ENABLED', 'True',
> > 'libxslt-native', '', d)}"
> >=C2=A0 =C2=A0
> >=C2=A0 =C2=A0GNOMEBASEBUILDCLASS =3D "meson"
>
> Any comment, please?

Why did this happen? Was this as a result of the move to meson? Is it
really needed and can we avoid it? native dependencies like this are a
pain from a build performance perspective...

Cheers,

Richard



--=20
Kai Kang
Wind River Linux
--------------CD311F2F45ED17E05EE15B50--