From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA221C07E99 for ; Mon, 5 Jul 2021 13:23:51 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 80A4E6141C for ; Mon, 5 Jul 2021 13:23:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 80A4E6141C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:40202 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m0OZi-0000yz-MF for qemu-devel@archiver.kernel.org; Mon, 05 Jul 2021 09:23:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53920) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m0OYp-0000JY-Fv for qemu-devel@nongnu.org; Mon, 05 Jul 2021 09:22:55 -0400 Received: from szxga03-in.huawei.com ([45.249.212.189]:2187) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m0OYm-0006gy-Cc for qemu-devel@nongnu.org; Mon, 05 Jul 2021 09:22:55 -0400 Received: from dggemv704-chm.china.huawei.com (unknown [172.30.72.57]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4GJR8K4nFhz75gZ; Mon, 5 Jul 2021 21:18:25 +0800 (CST) Received: from dggema765-chm.china.huawei.com (10.1.198.207) by dggemv704-chm.china.huawei.com (10.3.19.47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2176.2; Mon, 5 Jul 2021 21:22:45 +0800 Received: from [10.174.185.210] (10.174.185.210) by dggema765-chm.china.huawei.com (10.1.198.207) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Mon, 5 Jul 2021 21:22:44 +0800 Subject: Re: [PATCH 1/2] qapi/run-state: Add a new shutdown cause 'migration-completed' To: =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= References: <20210705123653.1315-1-jiangkunkun@huawei.com> <20210705123653.1315-2-jiangkunkun@huawei.com> From: Kunkun Jiang Message-ID: <7b8324e9-85d8-1b14-4e63-308ea2563d56@huawei.com> Date: Mon, 5 Jul 2021 21:22:43 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Originating-IP: [10.174.185.210] X-ClientProxiedBy: dggeme717-chm.china.huawei.com (10.1.199.113) To dggema765-chm.china.huawei.com (10.1.198.207) X-CFilter-Loop: Reflected Received-SPF: pass client-ip=45.249.212.189; envelope-from=jiangkunkun@huawei.com; helo=szxga03-in.huawei.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Juan Quintela , "open list:All patches CC here" , Markus Armbruster , wanghaibin.wang@huawei.com, Paolo Bonzini , Eric Blake , "Dr . David Alan Gilbert" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Hi Daniel, On 2021/7/5 20:48, Daniel P. Berrangé wrote: > On Mon, Jul 05, 2021 at 08:36:52PM +0800, Kunkun Jiang wrote: >> In the current version, the source QEMU process does not automatic >> exit after a successful migration. Additional action is required, >> such as sending { "execute": "quit" } or ctrl+c. For simplify, add >> a new shutdown cause 'migration-completed' to exit the source QEMU >> process after a successful migration. > IIUC, 'STATUS_COMPLETED' state is entered on the source host > once it has finished sending all VM state, and thus does not > guarantee that the target host has successfully received and > loaded all VM state. Thanks for your reply. If the target host doesn't successfully receive and load all VM state, we can send { "execute": "cont" } to resume the soruce in time to ensure that VM will not lost? > Typically a mgmt app will need to directly confirm that the > target host QEMU has succesfully started running, before it > will tell the source QEMU to quit. 'a mgmt app', such as libvirt? Thanks, Kunkun Jiang > So, AFAICT, this automatic exit after STATUS_COMPLETED is > not safe and could lead to total loss of the running VM in > error scenarios. > > > >> Signed-off-by: Kunkun Jiang >> --- >> migration/migration.c | 1 + >> qapi/run-state.json | 4 +++- >> 2 files changed, 4 insertions(+), 1 deletion(-) >> >> diff --git a/migration/migration.c b/migration/migration.c >> index 4228635d18..16782c93c2 100644 >> --- a/migration/migration.c >> +++ b/migration/migration.c >> @@ -3539,6 +3539,7 @@ static void migration_iteration_finish(MigrationState *s) >> case MIGRATION_STATUS_COMPLETED: >> migration_calculate_complete(s); >> runstate_set(RUN_STATE_POSTMIGRATE); >> + qemu_system_shutdown_request(SHUTDOWN_CAUSE_MIGRATION_COMPLETED); >> break; >> >> case MIGRATION_STATUS_ACTIVE: >> diff --git a/qapi/run-state.json b/qapi/run-state.json >> index 43d66d700f..66aaef4e2b 100644 >> --- a/qapi/run-state.json >> +++ b/qapi/run-state.json >> @@ -86,12 +86,14 @@ >> # ignores --no-reboot. This is useful for sanitizing >> # hypercalls on s390 that are used during kexec/kdump/boot >> # >> +# @migration-completed: Reaction to the successful migration >> +# >> ## >> { 'enum': 'ShutdownCause', >> # Beware, shutdown_caused_by_guest() depends on enumeration order >> 'data': [ 'none', 'host-error', 'host-qmp-quit', 'host-qmp-system-reset', >> 'host-signal', 'host-ui', 'guest-shutdown', 'guest-reset', >> - 'guest-panic', 'subsystem-reset'] } >> + 'guest-panic', 'subsystem-reset', 'migration-completed'] } >> >> ## >> # @StatusInfo: >> -- >> 2.23.0 >> >> > Regards, > Daniel