From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C042C433E1 for ; Mon, 13 Jul 2020 07:24:29 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 320E5206F0 for ; Mon, 13 Jul 2020 07:24:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 320E5206F0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:46824 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1juspA-0006zL-Ez for qemu-devel@archiver.kernel.org; Mon, 13 Jul 2020 03:24:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58608) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jusoV-0006ZQ-79 for qemu-devel@nongnu.org; Mon, 13 Jul 2020 03:23:47 -0400 Received: from mga05.intel.com ([192.55.52.43]:54542) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jusoS-0006rP-IM for qemu-devel@nongnu.org; Mon, 13 Jul 2020 03:23:46 -0400 IronPort-SDR: fR78P8FzXW9N3WhV3HwZUxsW0HXUHhcxQnqp823gS8T5HHLJmpbfQ6R/ij2DMYjrZI8Resxs/G 9Zqgru2W+uOg== X-IronPort-AV: E=McAfee;i="6000,8403,9680"; a="233427203" X-IronPort-AV: E=Sophos;i="5.75,346,1589266800"; d="scan'208";a="233427203" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jul 2020 00:23:36 -0700 IronPort-SDR: eY8wIx6WV3Zy3KPsQ0H3v4aca6GYeFT1g3WVmLeTI9nIBMbS3HaRQ7WV+wSsZfQyXMh0SMdZCk maa9NFn3uydQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,346,1589266800"; d="scan'208";a="307358648" Received: from cqiang-mobl.ccr.corp.intel.com (HELO [10.238.2.93]) ([10.238.2.93]) by fmsmga004.fm.intel.com with ESMTP; 13 Jul 2020 00:23:34 -0700 Subject: Re: [PATCH v5 1/4] target/i386: add missing vmx features for several CPU models To: Eduardo Habkost References: <20200619073114.24303-1-chenyi.qiang@intel.com> <20200619073114.24303-2-chenyi.qiang@intel.com> <20200709221226.GM780932@habkost.net> <20200710164832.GR780932@habkost.net> From: Chenyi Qiang Message-ID: <7b8ceab5-2bf4-0905-ff9f-b2d9e2bd89a1@intel.com> Date: Mon, 13 Jul 2020 15:23:34 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200710164832.GR780932@habkost.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=192.55.52.43; envelope-from=chenyi.qiang@intel.com; helo=mga05.intel.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/13 03:23:37 X-ACL-Warn: Detected OS = FreeBSD 9.x or newer [fuzzy] X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , Robert Hoo , Xiaoyao Li , qemu-devel@nongnu.org, Richard Henderson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 7/11/2020 12:48 AM, Eduardo Habkost wrote: > On Fri, Jul 10, 2020 at 09:45:49AM +0800, Chenyi Qiang wrote: >> >> >> On 7/10/2020 6:12 AM, Eduardo Habkost wrote: >>> >>> I'm very sorry for taking so long to review this. Question >>> below: >>> >>> On Fri, Jun 19, 2020 at 03:31:11PM +0800, Chenyi Qiang wrote: >>>> Add some missing VMX features in Skylake-Server, Cascadelake-Server and >>>> Icelake-Server CPU models based on the output of Paolo's script. >>>> >>>> Signed-off-by: Chenyi Qiang >>> >>> Why are you changing the v1 definition instead adding those new >>> features in a new version of the CPU model, just like you did in >>> patch 3/4? >>> >> >> I suppose these missing vmx features are not quite necessary for customers. >> Just post it here to see if they are worth being added. >> Adding a new version is reasonable. Is it appropriate to put all the missing >> features in patch 1/4, 3/4, 4/4 in a same version? > > Yes, it would be OK to add only one new version with all the new > features. > During the coding, I prefer to split the missing vmx features into a new version of CPU model, because the vmx features depends on CPUID_EXT_VMX. I think It would be better to distinguish it instead of enabling the vmx transparently. i.e. { .version = 4, .props = (PropValue[]) { { "sha-ni", "on" }, ... ... { "model", "106" }, { /* end of list */ } }, }, { .version = 5, .props = (PropValue[]) { { "vmx", "on" }, { "vmx-eptp-switching", "on" }, { /* end of list */ } }, }, What do you think about?