From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14075C433E0 for ; Wed, 27 Jan 2021 06:46:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B722D2072D for ; Wed, 27 Jan 2021 06:46:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232596AbhA0Gp5 (ORCPT ); Wed, 27 Jan 2021 01:45:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55416 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232221AbhA0GgR (ORCPT ); Wed, 27 Jan 2021 01:36:17 -0500 Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:8b0:10b:1231::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6A6AEC0613ED; Tue, 26 Jan 2021 22:35:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender :Reply-To:Content-ID:Content-Description; bh=SawICNoa1kHyyeVtFqzgzTd8rQ75hzb8S4YXXAcpsPY=; b=QoOZvbdEU+hBFgpGiWadkcgzUE RW6FtKNpqlL/UxLfWddmBDCJjKIRQFKxV10LKmHRcP4Jxz0YhEqGn7hk9SvLysmavnuft2qPKBVu/ xOuYYK+bq4hwZ98XxSFDlEGWHO/UkS/hVxjxyXejOm9Sg3ta5bycHlkso5gSbZKbQYqsRJ13foLyn bQJ/i70iCPLz5XWxJ4JuTQj5UeKjWQvGPwuyyDHBXV4ov59l2Oi8HsGcErKnSAHwHN8pe53yFX7gn yPaPH/B0yHZvhIBoGDboaa52vLSQ2+0TcmODS/HKctXeAvhfU0M7HI3x6CKcd0xsQEI/N8cNIztJj VE3RhdUA==; Received: from [2601:1c0:6280:3f0::7650] by merlin.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1l4eQF-0003mB-Ck; Wed, 27 Jan 2021 06:35:23 +0000 Subject: Re: [PATCH 1/2] fs/efs/inode.c: follow style guide To: Amy Parker Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org References: <5d005259-feec-686d-dc32-e1b10cf74459@infradead.org> From: Randy Dunlap Message-ID: <7b8f67a6-0f06-6bf6-2ecd-5a57693a64f8@infradead.org> Date: Tue, 26 Jan 2021 22:35:17 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/26/21 9:13 PM, Amy Parker wrote: > On Tue, Jan 26, 2021 at 7:59 PM Randy Dunlap wrote: >> >> On 1/26/21 7:46 PM, Randy Dunlap wrote: >>> Hi Amy, >>> >>> What mail client did you use? >>> It is breaking (splitting) long lines into shorter lines and that >>> makes it not possible to apply the patch cleanly. > > Was worried about that, thought I had all my settings straightened out. > >>> >>> You can see this problem below or on the web in an email archive. >>> >>> Possibly Documentation/process/email-clients.rst can help you. > > Yeah, read that. Thought I had everything fixed up. > >> >> Also tabs in the source file have been converted to spaces. > > Was this inconsistent throughout the patch? I can't really seem to > tell. If it's consistent, bet it's probably my mail client - if it's > inconsistent it could be my editor, I had to switch out temporarily > for a different editor today. > There are no tabs in the patch. >> >> It would be good if you could email a patch to yourself and then >> see if you can apply cleanly it to your source tree (after removing >> any conflicting patches, of course -- or use a different source >> tree). > > Yeah, I'll make sure to double check with that in the future. > >> >> >> -- >> ~Randy >> Reported-by: Randy Dunlap >> netiquette: https://people.kernel.org/tglx/notes-about-netiquette > > Should I send in a v2 of this patchset, or just attach the patch here? > If I should just attach it here, then I'll do the same for patch 2/2. An attachment might be OK once but it would be better if you could get inline patches to work. You'll need to do that... -- ~Randy