From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0E329C433EF for ; Fri, 24 Dec 2021 07:00:58 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id B18588377A; Fri, 24 Dec 2021 08:00:56 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=rock-chips.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 57AAA83781; Fri, 24 Dec 2021 08:00:54 +0100 (CET) Received: from regular1.263xmail.com (regular1.263xmail.com [211.150.70.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 3E5C38378A for ; Fri, 24 Dec 2021 08:00:49 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=rock-chips.com Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=kever.yang@rock-chips.com Received: from localhost (unknown [192.168.167.69]) by regular1.263xmail.com (Postfix) with ESMTP id 68A9DE8A; Fri, 24 Dec 2021 15:00:43 +0800 (CST) X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-ADDR-CHECKED4: 1 X-SKE-CHECKED: 1 X-ABS-CHECKED: 1 X-ANTISPAM-LEVEL: 2 Received: from [192.168.60.65] (unknown [103.29.142.67]) by smtp.263.net (postfix) whith ESMTP id P6047T139645652285184S1640329229484856_; Fri, 24 Dec 2021 15:00:40 +0800 (CST) X-IP-DOMAINF: 1 X-RL-SENDER: kever.yang@rock-chips.com X-SENDER: yk@rock-chips.com X-LOGIN-NAME: kever.yang@rock-chips.com X-FST-TO: philipp.tomsich@vrull.eu X-RCPT-COUNT: 17 X-LOCAL-RCPT-COUNT: 0 X-MUTI-DOMAIN-COUNT: 0 X-SENDER-IP: 103.29.142.67 X-ATTACHMENT-NUM: 0 X-UNIQUE-TAG: <17df61a67dabab238623f0ce115e544a> X-System-Flag: 0 Subject: Re: [PATCH v2 3/4] rockchip: bob: Enable more configs To: Alper Nebi Yasak , u-boot@lists.denx.de Cc: Artem Lapkin , Christian Hewitt , Fabio Estevam , Jagan Teki , Lokesh Vutla , "Marty E . Plummer" , Heiko Schocher , Simon Glass , Andre Przywara , Neil Armstrong , Tim Harvey , Johan Jonker , Alexandre Vicenzi , Peter Robinson , Philipp Tomsich References: <20211213221528.43102-1-alpernebiyasak@gmail.com> <20211213221528.43102-4-alpernebiyasak@gmail.com> From: Kever Yang Message-ID: <7b99e97b-44ba-50db-bef7-ccf30df45501@rock-chips.com> Date: Fri, 24 Dec 2021 15:00:28 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20211213221528.43102-4-alpernebiyasak@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.38 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 2021/12/14 上午6:15, Alper Nebi Yasak wrote: > This patch enables some configs that should be working on the Bob board, > based on what is observed to work on the Kevin board. > > The Bob board uses an Embedded DisplayPort panel compatible with the > simple panel and Rockchip eDP drivers. Its backlight is controlled by > the Chromium OS Embedded Controller Pulse Width Modulator. Enable these > for the board. > > Also set VIDEO_ROCKCHIP_MAX_{XRES,YRES} to 1280x800, the resolution of > its panel. This had to be done for the Kevin board, but it's untested if > this is actually necessary for Bob. > > The Rockchip video driver needs to assert/deassert some resets, so also > enable the reset controller. RESET_ROCKCHIP defaults to y for this board > when DM_RESET=y, so it's enough to set that. > > The Bob board has two USB 3.0 Type-C ports and one USB 2.0 Type-A port > on its right side. Enable the configs relevant to USB devices so these > can be used. This is despite a known issue with RK3399 boards where USB > de-init causes a hang, as there is a known workaround. > > Some other rk3399-based devices enable support for the SoC's random > number generator in commit a475bef5340c ("configs: rk3399: enable rng on > firefly/rock960/rockpro64"), as it can provide a KASLR seed when booting > using UEFI. Enable it for Bob as well. > > The default misc_init_r() for Rockchip boards sets cpuid and ethernet > MAC address based on e-fuse block. A previous patch extends this on Gru > boards to set registers related to SoC IO domains as is necessary on > these boards. Enable this function and configs for it on Bob. > > The eMMC on this board is capable of running at a HS400 Enhanced Strobe > configuration, and the microSD slot at Ultra High Speed SDR104. Enable > the configs for these as the hardware supports these modes. There are > problems causing the devices to run at lower speeds, but these configs > are enabled in hope that these will be solved later. Enabling ADMA > currently makes the eMMC stop working, so it is kept disabled. > > The microSD card slot on this board (and others based on Gru) is > connected to a GPIO controlled regulator (ppvar-sd-card-io), which must > be operable by U-Boot. Enable the relevant config option to allow this. > > Bob boards also use the Winbond W25Q64DW SPI flash chip, enable support > for Winbond SPI flash chips in the board config so U-Boot can boot with > this chip. > > Signed-off-by: Alper Nebi Yasak Reviewed-by: Kever Yang Thanks, - Kever > --- > > (no changes since v1) > > configs/chromebook_bob_defconfig | 27 ++++++++++++++++++++++++++- > include/configs/gru.h | 3 +++ > 2 files changed, 29 insertions(+), 1 deletion(-) > > diff --git a/configs/chromebook_bob_defconfig b/configs/chromebook_bob_defconfig > index fe938c659172..048fa8e0c043 100644 > --- a/configs/chromebook_bob_defconfig > +++ b/configs/chromebook_bob_defconfig > @@ -21,6 +21,7 @@ CONFIG_DEFAULT_FDT_FILE="rockchip/rk3399-gru-bob.dtb" > # CONFIG_DISPLAY_CPUINFO is not set > CONFIG_DISPLAY_BOARDINFO_LATE=y > CONFIG_BOARD_EARLY_INIT_R=y > +CONFIG_MISC_INIT_R=y > CONFIG_BLOBLIST=y > CONFIG_BLOBLIST_SIZE=0x1000 > CONFIG_BLOBLIST_ADDR=0x100000 > @@ -52,26 +53,40 @@ CONFIG_ROCKCHIP_GPIO=y > CONFIG_I2C_CROS_EC_TUNNEL=y > CONFIG_SYS_I2C_ROCKCHIP=y > CONFIG_I2C_MUX=y > -CONFIG_DM_KEYBOARD=y > CONFIG_CROS_EC_KEYB=y > +CONFIG_MISC=y > +CONFIG_ROCKCHIP_EFUSE=y > CONFIG_CROS_EC=y > CONFIG_CROS_EC_SPI=y > CONFIG_PWRSEQ=y > CONFIG_MMC_PWRSEQ=y > +CONFIG_MMC_IO_VOLTAGE=y > +CONFIG_MMC_UHS_SUPPORT=y > +CONFIG_MMC_HS400_ES_SUPPORT=y > +CONFIG_MMC_HS400_SUPPORT=y > CONFIG_MMC_DW=y > CONFIG_MMC_DW_ROCKCHIP=y > CONFIG_MMC_SDHCI=y > +CONFIG_MMC_SDHCI_SDMA=y > CONFIG_MMC_SDHCI_ROCKCHIP=y > CONFIG_SF_DEFAULT_BUS=1 > CONFIG_SF_DEFAULT_SPEED=20000000 > CONFIG_SPI_FLASH_GIGADEVICE=y > +CONFIG_SPI_FLASH_WINBOND=y > CONFIG_DM_ETH=y > CONFIG_ETH_DESIGNWARE=y > CONFIG_GMAC_ROCKCHIP=y > +CONFIG_PHY_ROCKCHIP_INNO_USB2=y > +CONFIG_PHY_ROCKCHIP_TYPEC=y > CONFIG_PMIC_RK8XX=y > CONFIG_REGULATOR_PWM=y > +CONFIG_DM_REGULATOR_GPIO=y > CONFIG_REGULATOR_RK8XX=y > +CONFIG_PWM_CROS_EC=y > CONFIG_PWM_ROCKCHIP=y > +CONFIG_DM_RESET=y > +CONFIG_DM_RNG=y > +CONFIG_RNG_ROCKCHIP=y > CONFIG_DEBUG_UART_SHIFT=2 > CONFIG_ROCKCHIP_SPI=y > CONFIG_SYSRESET=y > @@ -80,11 +95,21 @@ CONFIG_USB_XHCI_HCD=y > CONFIG_USB_XHCI_DWC3=y > CONFIG_USB_EHCI_HCD=y > CONFIG_USB_EHCI_GENERIC=y > +CONFIG_USB_OHCI_HCD=y > +CONFIG_USB_OHCI_GENERIC=y > +CONFIG_USB_DWC3=y > +CONFIG_USB_KEYBOARD=y > CONFIG_USB_HOST_ETHER=y > CONFIG_USB_ETHER_ASIX=y > CONFIG_USB_ETHER_ASIX88179=y > CONFIG_USB_ETHER_MCS7830=y > CONFIG_USB_ETHER_RTL8152=y > CONFIG_USB_ETHER_SMSC95XX=y > +CONFIG_DM_VIDEO=y > +CONFIG_DISPLAY=y > +CONFIG_VIDEO_ROCKCHIP=y > +CONFIG_VIDEO_ROCKCHIP_MAX_XRES=1280 > +CONFIG_VIDEO_ROCKCHIP_MAX_YRES=800 > +CONFIG_DISPLAY_ROCKCHIP_EDP=y > CONFIG_CMD_DHRYSTONE=y > CONFIG_ERRNO_STR=y > diff --git a/include/configs/gru.h b/include/configs/gru.h > index be2dc79968c0..b1084bb21d4d 100644 > --- a/include/configs/gru.h > +++ b/include/configs/gru.h > @@ -13,4 +13,7 @@ > > #include > > +#define CONFIG_USB_OHCI_NEW > +#define CONFIG_SYS_USB_OHCI_MAX_ROOT_PORTS 2 > + > #endif