From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753046AbdFUQWM (ORCPT ); Wed, 21 Jun 2017 12:22:12 -0400 Received: from mail-bl2nam02on0055.outbound.protection.outlook.com ([104.47.38.55]:19918 "EHLO NAM02-BL2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752413AbdFUQWF (ORCPT ); Wed, 21 Jun 2017 12:22:05 -0400 Authentication-Results: redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=amd.com; Subject: Re: [PATCH v7 25/36] swiotlb: Add warnings for use of bounce buffers with SME To: Borislav Petkov Cc: linux-arch@vger.kernel.org, linux-efi@vger.kernel.org, kvm@vger.kernel.org, linux-doc@vger.kernel.org, x86@kernel.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, xen-devel@lists.xen.org, linux-mm@kvack.org, iommu@lists.linux-foundation.org, Brijesh Singh , Toshimitsu Kani , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Matt Fleming , Alexander Potapenko , "H. Peter Anvin" , Larry Woodman , Jonathan Corbet , Joerg Roedel , "Michael S. Tsirkin" , Ingo Molnar , Andrey Ryabinin , Dave Young , Rik van Riel , Arnd Bergmann , Konrad Rzeszutek Wilk , Andy Lutomirski , Boris Ostrovsky , Dmitry Vyukov , Juergen Gross , Thomas Gleixner , Paolo Bonzini References: <20170616184947.18967.84890.stgit@tlendack-t1.amdoffice.net> <20170616185435.18967.26665.stgit@tlendack-t1.amdoffice.net> <20170621105026.lcbtkklaenyi2wqe@pd.tnic> From: Tom Lendacky Message-ID: <7b9f8b6d-60f2-0a78-b582-0821401d17eb@amd.com> Date: Wed, 21 Jun 2017 10:37:41 -0500 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 In-Reply-To: <20170621105026.lcbtkklaenyi2wqe@pd.tnic> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [165.204.78.1] X-ClientProxiedBy: CO2PR07CA0047.namprd07.prod.outlook.com (10.174.192.15) To MWHPR12MB1152.namprd12.prod.outlook.com (10.169.204.16) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: cea6402d-7e92-4eda-86d2-08d4b8bb7829 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(48565401081)(201703131423075)(201703031133081);SRVR:MWHPR12MB1152; X-Microsoft-Exchange-Diagnostics: 1;MWHPR12MB1152;3:BYBxKCuJMJ2gn92ApEzFvMRcB9Wq2wlX8YHL1ZBUwMy2/7eFCrUf02ArebXF/7DzpFgGQ70dxYULK9ySvkE9TU1r2d/Z0aPmwR+yZPVcnX83E7qK4p9iBkx/UE7rpOBhdBgZfa0juXlC3Elw1Bl6aLZBeTJUJxn2m4zPQKFLHcdoPocpawABbjq+wFpfd4LRuqzHqB8XqKL3oCR5ZQqCWF8GM+zS0Re1vPfMqzp0wikV52J9EuADkcU7IuzqlHAwCQPD/qH0MDIfAtrKRD4XKWlTl7PjF20tICiR2JQXLVR2CxemZ0GYkNyxob3M07RahffilPtxJoU0KgPSXLe3sYfhDyAixT56hcmXfgkh8po=;25:FO6E0YugLlMeEhdebeTTnurZrMu1xDcAmVwjPKT3M2llFWWC8tK9mYNmNVGK7Hfj135X4jMplk/ds+IWqKlLAZWhuNMw+s95xbjXzNOLI18XBVZ4cwM3labpte3LzNtG50kroTaIvo0I1+NJGPPAkoV3F8co8xZjoRQqCIK5ETyoFWQFjh3zOLwtpYsZ9hVAlTyexkwIFAPkCll2luifQVqHe/28OcHjtcgz9/61PoNrsEllI2eEUsCQ+FQ2HrvBKeQCS88Ha6drcixLT4QrmhHwYLVdrkR5qzTyyOUGd8yHm71kPMJRsIYWY/ycHzUScW4p648yp7eWJfFldL/QIfqRvx+NvS5QJMwy/tZkXSyPoPVb5KL0gxBD49Gv0xkxE6r6jWWbPH8rqYkli9TLjmzou1LHcT4cE6mPVPaPojBZDIE9fsP3zsHiV4P53LS3I5V3e812k3v6G59uI9H90xXwS95YLU8SXtDCs1LlSmc= X-MS-TrafficTypeDiagnostic: MWHPR12MB1152: X-Microsoft-Exchange-Diagnostics: 1;MWHPR12MB1152;31:zTOt5XSzIWNEB11KZoJ00U7RnStOsABoLNx4ldvyDuW4rI40abgjEsgrtLZUtfht27hjinTW5OofNQVQVrS4vQLnoqU7yhtMQSmy9rtTCPwPd9yl20sYP7eg8Odrz5KcYDwX9VOc9SGxZQHXLTyT8q+f/1bTu7wvdjAo1qXH3PO6H/xC5vcYCsxy1YDv9/TicH3ElCaHW6p3J7dkidryidcMqYIaugNpfVMxamPtEbI=;20:dYpnbDFc8R2o9yFp/TEeLSaKB0rhI8swcDMShr6SDfoMuMx/JcpglmBqVyrf+1rtyeAkt6Gk/oSwSLRnt8n/WNWSEe5L3ASLq3muICXQ9n1U6zqp8xejQYHYKoEnOnDzUTGGedEoK4rN+p4IhDNEb5sCjPXpCSBr5bs4pzVZUs0+wHPEl5CtNoAjA9Y9qsRr7l8LgeIWtHrPA8HAgtgh01KneCRZ6Y+Cj1P3sScGctl2/CA7+PrK+rOckuoclXKelh93NQflwY3q88eyCERcRw5Z4ONas3MyQeiXev2KGOKiqZux2ruIoqQ0iKZ1iTgCKmC4zjGzeqnJnnmeURsPOa2Zfw5MbpnFLMEA1LPurdX6HV8q6Z5FdAXHkylXjt9bT/ef0z1u1/dP5pGTeAhKjiASYqFVpSTFXQWYwnONYE/P28eTqxg3yC96Qp3l0O7psdfsJurnjOmcdF/vTWKR6R+OWdqhpg1RUsGiXJjPWtVxuJKJY/suuZsYxRY75fvT X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(767451399110); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(93006095)(93001095)(100000703101)(100105400095)(10201501046)(3002001)(6055026)(6041248)(20161123564025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123560025)(20161123562025)(6072148)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:MWHPR12MB1152;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:MWHPR12MB1152; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtNV0hQUjEyTUIxMTUyOzQ6Sm9sN0VkSmRpbktPekVUS3Q1SUc4YWlEK04x?= =?utf-8?B?UDFwbUIwUHF1TXZsNVVkU3lHVzgxaWtKQjZmaEY0QVV6ODJjSzBQeFlDYytG?= =?utf-8?B?dEdhSlMrK1I4ZjNqNEdldzVzclh5K0w0ZTBYd2pJNC94a29QaklnVVVRMUFF?= =?utf-8?B?QU4rWXNESXhZQUlESXZlcGFsRTd6OUpvQkRpYnFBT2VDNUtBNk9EeERTdzNy?= =?utf-8?B?VGNSUDFSMExpSkpRVGlyQWd1ak5sK0hNOTFGenM1QVJuOWh5Y1paaVFuQ3RW?= =?utf-8?B?YTNoWitPOEVRbHFNQ283SGNNTlFyRGQydXVya1A4WEFXT2Z6RDZVS2UyV1Zh?= =?utf-8?B?NHlzTXVNdGZWOEZuRW9XY1Q4OFpIc0VMTHJuUGFJbjhQbm1NOWpBR1pYU3lQ?= =?utf-8?B?cDFpOEZhbjZrUlFmN2dpNUc4a09jL2crcDI3SmRxMnhGNWZqUW9pdEpJVml2?= =?utf-8?B?djVueE9oM1ZodzJjY3hsdFhDbEVyYUFWejNmb045U3lMODM2TDRGYXUwNEd6?= =?utf-8?B?MTBWblE4ckdXdHcyL1ltcEJBc2ljUGN1OGhmeGVGa3lScEJTeXVsdkFGRWRl?= =?utf-8?B?OGVwQjF4Vk1sc2tPejFTdUZmQlBLczlQNU1DYzhTWlF3UGRBM3BDc3lsWDJX?= =?utf-8?B?NCtXMnRDSm9UQlBnRkd2aURGenArMndLSThabTdNNFhnaTFaSDNmVVRNWWhD?= =?utf-8?B?UGRaR2h0V1hIY2ZmNVA3V1hDVzVMYW5FZkcyVVpJZ1V1Q1hMVVZDMjU4NkpK?= =?utf-8?B?Skdmb1IvZm1IeUF2YmgrTlZrdjFEaWZWTDF4VXJSM1hGb0MvRkI2aU12WHNR?= =?utf-8?B?bXFjM1JnekhvZDZIRlRWb1VjK2R0M1F4d1lGVnBlZXdSeEwzeGNPcE5IeXhG?= =?utf-8?B?L2RMZGo2bFB6djF5RTVBRnRMdDBGbzEwSUxhaHR3Q1ZhTzdRSDk5RzVHZkN2?= =?utf-8?B?Y082dzE5YW1jMHh2V2p1eFU5TmI4Z0NLOE04dGJheWVRM3ZUYTE3Q0tROHdS?= =?utf-8?B?bHBYM01HU2ZGeXF6elYxZ1JVeEZYekYrVjcwZkwwRFlFQ1lvRXlUM1hFdnJw?= =?utf-8?B?enlaVHdyK3Z3KzBnTERBUzc0L1RhaDBhZS9na3VmbGNOZ2U0QVJuckxCZm1J?= =?utf-8?B?dTlJVHFWUzdZTU9MNzdtSFNVZkFLL3B5UEhzMWdjZjNMOVQ1R21YekZuTUFO?= =?utf-8?B?MXBDdXl3ZlZCWXRrVk9ZMUJZMk1LL0piYUt6Z00wRGh1ektCQzVxbkd1b0ZD?= =?utf-8?B?R3FMVEJUSW12VGZza1RBRWlXT2J5M2JBb1U0YXp2QWF2MHBtWmR3bmxIWDJL?= =?utf-8?B?S1JWbVI0OTJRbDhyeXFXblMrcDhmY1dZYlRGcmNEQU5STmJLOTc2K2NKRHpQ?= =?utf-8?B?bndpZ0dvTGJKWndmeVdGSmJGN3RVcWt0S2ZYbmlmZjJFUFFKQm1URjMxWkZt?= =?utf-8?B?Sm9kNENXZFJDREgrdlUxMjkrSnVBdzNXZzNFaXVtWlUzNWVlWEpuYS95ZHpP?= =?utf-8?B?cmY4dVU1TUUrVXBLTHE1MElKVm5HUGNWUFFKYnFISXQ5dEpvMnNZM2YwV2V5?= =?utf-8?B?aDEva1dFQzgwempERllBQkZRR0Y2ZC9QRE81MUxjeWQxdHBFcXRKWEpkUFpq?= =?utf-8?Q?x3UVBzowKJZSmDpS944?= X-Forefront-PRVS: 0345CFD558 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6049001)(6009001)(39410400002)(39400400002)(39850400002)(39860400002)(39450400003)(39840400002)(377454003)(24454002)(25786009)(189998001)(54906002)(53546010)(7736002)(72206003)(76176999)(90366009)(54356999)(50986999)(33646002)(305945005)(7406005)(23676002)(31686004)(53936002)(42186005)(7416002)(5660300001)(86362001)(6246003)(110136004)(4001350100001)(229853002)(38730400002)(31696002)(6666003)(6916009)(2950100002)(2906002)(3846002)(83506001)(36756003)(6116002)(478600001)(4326008)(230700001)(77096006)(66066001)(81166006)(65806001)(6486002)(47776003)(8676002)(50466002);DIR:OUT;SFP:1101;SCL:1;SRVR:MWHPR12MB1152;H:[10.236.64.250];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtNV0hQUjEyTUIxMTUyOzIzOnBFTlFsdGRIVngyTStmR2hKTmxtSkNqOEhR?= =?utf-8?B?WVJBbkFtUzY5Wis0ZmtQUXlaeDdpTDFjK3BzbisvTjJJR3hnakFCV2g3SW5l?= =?utf-8?B?K0VSQU9KWk1zZzZwV0pYSXFBU3g0WlJmNkVVMTIxOE1odVc2ZG9lZ2ZVWGVM?= =?utf-8?B?R2pXelhVM1VIWUdYUHVldnBUY3ZPRUFXd2VSNWt3cUQ1d0lWTHFONDR5YWR2?= =?utf-8?B?MzRPbnhUZUJCempjWmU0amF0TDRTMUg1MEt1eWZPRnJjZVNxaE1ZY09Fb2ZD?= =?utf-8?B?dnZSNllERDlFamR4QUNtblF5b3ROcTBzOXVxVTdBMjVUS3VaMmNyZThOUy9i?= =?utf-8?B?a2JxWlVsOHZlbVBBb3hDR0U4bFdzOVp5d1FlTU84UHJmRUtNaldnVlkyWVd4?= =?utf-8?B?Y2t2OENZK2lvS1J2SmQyaGVXelF5VlRUcnppS0htQnpkTHJ2UHkza3ByWERL?= =?utf-8?B?ZUczak5UeVhMK05iL1VDSDhrb3lMdVgwVUFJZnBjUDNNNXFLL2gzemJIeGp2?= =?utf-8?B?L1lJejAxcVRNL1pXOHFXdVV1MW1va2J6U3hKeksvZE13bzJPbG0zWW1qU0pZ?= =?utf-8?B?RlhxRWpWNlM2ODJUN09LNFZsSkE1V2N1Y3F2ZWxXaCs4cm4rVHdFejl3V21W?= =?utf-8?B?OGQyVlhHd3pzMWpBL2JNL3lqaW9KQi9mT3k2R2pGeEk0WWdPQ2NDUjg5SGlF?= =?utf-8?B?emdPWkRHUW5DZGJidEhkR2RjRmM0WkFRaUxwdTRVajRMUllQNnB1RVl2T0lo?= =?utf-8?B?a1dLbFNGdm1COFhrL200T0Z5UFJZVmRtVko4bEZZV0pna0JrSEZ2TnhLeWp3?= =?utf-8?B?NUczd1l3OXY4ejJvbEhGZmJEQjJ2VzcwU2hxYWN4NUptNzA1clB0b2NRSHl3?= =?utf-8?B?SzNzbGpSclRWTlJHdUhFcFB6aEFHdTJRSkI4L25NbFp3ekdLeFA1OUlCaktV?= =?utf-8?B?RWtVT0NaUmIzT3MzTnNwMENpbHp2MUxjQnQxaXNNRFlhaTBBd1hyNFNwZEVE?= =?utf-8?B?UHBYeStJUGVxeHNHdjdDai9ISGkyMzMyWllvY3hlY2F5bWhIK3BNdVczQmlF?= =?utf-8?B?SXFQVlpIMHFzK1lPQXdSRWtoRTZleWhxTE9XbjRYSnhEdjBWUFdyT2x1cjRN?= =?utf-8?B?eExjTnhLT1pVaFVrMWVjWW95UDB3dWZFcFV0YVZ1YllVaEc5U0NZYldPSGE1?= =?utf-8?B?MmMvdC9Xck5iRzE4YWhOVnE3bmtCSGlQN1ZYd0NUWk1PWTAxUnZTc2Z2ejNl?= =?utf-8?B?dkN5UHQwcDRuT0JxR0x5TExqeCt4WFNwY1VrUitZUEgzR2ZqOHdPRmJPWEY5?= =?utf-8?B?MDB6Tkh2UkI2aHFkZUR0USsxRUh4QnJ1WUNTLy9CTGdheitmQmorMXpJQXhn?= =?utf-8?B?NFFybE04VlFZNXBzeG5nRnFyNTUrNmdkVENxSzVsRlNScnh3ZjZ0UmxDckF2?= =?utf-8?B?R0pqUHIvKzFqYUZiNUxLdERKNVpQSUtpT1htRHhHMG5aS2lKK2VweS9HcE5m?= =?utf-8?B?T3hMek5qSDZYS2NjODdEVkhGRUROSFVqMDlXTnlwZ25rZWU2cWlCb01DcENG?= =?utf-8?B?ai9FcHFGaHU5MFBuRzFIek13Y05Pa1Jjc2dvWXlqdWprNkNzQndjTVhNVlVu?= =?utf-8?B?Yk1SSisrMDJIYnIrR0JzZm9xUlNobkJYODdFVUZKaHFVMW8xQXFpLzdtZWNH?= =?utf-8?B?OGI3RitGSzRtcEZEaUxuajQrd2Z2bU1LZTFCMzMrNWkyMHRhbmxoNGdRU0dM?= =?utf-8?B?T3c5Tm9GQmY2VWVpOEozdUYySXBwMzJ0WG1jR3NPejF5aEIwMDYxbmN5SFMy?= =?utf-8?B?V1Bpejd4S05TUkQyYTROVXQxZ2k5aDZTSGl3WkNpa2c0WklYSmZkK1IyNW5Y?= =?utf-8?Q?voKaK1cgN+M=3D?= X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtNV0hQUjEyTUIxMTUyOzY6cW9jSkRMKy9jZnVCWGlDVUgxdkFOVWVORUFO?= =?utf-8?B?dGZpVFAvMGJDUjhMYmJrZmlWMm5YMmsxWlF4VndZaFVlVEY4b3NOdmFrSExx?= =?utf-8?B?M0s1Vlp3dWhFWG9YaGZKMTYxOWZBRDdiRW9uS01od1RFZUwvTDlDODU4K25J?= =?utf-8?B?NFBJL1c0OTFSSFd0OC8yY2VJVjkxaWMzUlBGUExwOCs1ZUZPNWtPS3UzTWJY?= =?utf-8?B?blhEamxSbXdCZjAzTzRNcEFWdXBOUThVSmRFcER2VUlBV0N6MEoyZm1wVmI5?= =?utf-8?B?MjJ0M09ES2pJM2FpOU5Nd2k3TDZiKzRLeCsrdGo4TG5yS0poVENqL1IxNUZF?= =?utf-8?B?eW13WGdQRDRPTjE3c2NMYVphV2JRU2N0VkpGK3RnOERraGpFbXVhd3U4Q21U?= =?utf-8?B?cEg4V0lacktQSlY0L2pMMDRWaFl4SnhpK0U3MEFkVWVsTFBYTFJTWTlUb1VC?= =?utf-8?B?OE9mdzNTWjc4aWpwaHhMU0d1S1B5dWF1a0RBNy9KWmlXNFZQRTZLVmhOaTVw?= =?utf-8?B?bzh4T3U5VDdKKy8zUUlsclEvTVpGeGNnaTRsL0FTMXc0N0NVLzhXZCtFZHdm?= =?utf-8?B?VXlDRGd0MzlGOW1jVTFNZ3VsUUkxYmlZb0xxMHQwUU1tWHozQ2JNVDJ0WGNB?= =?utf-8?B?M2tyR1VsYXZRRTM5dnZIWVA2Ry9IUHNhT3lUaVoreklkZ25JcjBaQmlIVEpw?= =?utf-8?B?dS9sQ3ZjNEFnaUMzUEoyTWgyWjhzZXJkanlPZk1lN2ExN2ZPejFlVFh3TVJ6?= =?utf-8?B?TW16U1VlY0V3RG9IQ1hFZDAvZHJZc0lWcjlzVHkzcHpBWW1xUEpBb1QzNlJG?= =?utf-8?B?QzB5aEtBV0NBTVQwN1BXRVpmL1djRy9jZm1DQzRMM3dOREJKTlRFdkxnVWo0?= =?utf-8?B?czlhT0JnS3RLd0VPYVkrcnlLUWxubHV3cjMrbmE2WEt6V2pSTTVoK0I2THY1?= =?utf-8?B?QVBQUk8wSXJ0RU1aeGRUdWZxZzdMWEpOdlVsNG40VWszU2FPZUxRNndETk4r?= =?utf-8?B?alZud1NWTStnaGtSbWQ2dFl3aVBSSlA5U0xUUzZWVkZnQVBSTDdid2paMysz?= =?utf-8?B?S1VZcUkzcjRTQW84aVNTTEZ2K1MwNGJ4OUVJUDF2TzVQcEtGbWVyNHJhOFhH?= =?utf-8?B?S3BsNU5mNitVNmlCQ3Y0UjJqRFg4SWh5NTd6ckgydEl5VWE1eVZZWVNmS2FG?= =?utf-8?B?d25keFowNW9NQ253dUpmRVNoK01rOGNxbndEdFVGZHpqZVFacjRLeUxtY1p5?= =?utf-8?B?UWpXWGVCSTRtMG9TR1B4Zk44TFNOeFFhMFZKMGtHZW1jUndLY2dTVGx3dGxv?= =?utf-8?B?RTFzLzNReVR0VUxaVVZvTTVFRWRuMVcrb1Z5V2NvZnRjNnJwbXRHZ3BZVTFp?= =?utf-8?Q?Wh1pBNN?= X-Microsoft-Exchange-Diagnostics: 1;MWHPR12MB1152;5:pZZU7KtcFJahjvZulT0/RkocGTWHJOzK2/wZXj4xJe7s64ncfzS/oq3O/e7skG4eD5XFZ+GUHOdwG1IZTVuDr0eFLz2W5Lk9hXXDilcoGzEjtp1Xy0lHxigbibb+2eSNU7EgjGBGbauQK+JUt0KSL2zkEXfrJibjcEeziI7N7UugI9LzEa/UJQXuF0GEK1dJV1JjZ3DE8v4X7PlWBJ8hj7QQSm1GzrNg2y/rnGHbPcodsi7tDHPpMNAOClNhsRNfQgCgXDuDFE9j2khPCHv+Swm44XYleSfeXDy2948KhCI3N5PC+KLdro2seAl0XoNG+BUL8oJ0ZkNRadr+jnXbfXxFOoXy7tIB8BIPisIwYJmuUXYsJbbgQYiSGmJX3LI97HNPW9p/3CqEBUcFZisVMAGDfQi5qS5UmPmi1wlQa3xwnuimOgx5Ao6BbrVXYfveBVbuVCn1aHXyOquH9xzb2w6ahqfPzZ8I0jt+N2fxdPlkHrJMtvMFtPGjVR2JQOCJ;24:l7C71VFWyqNJ+za7GlB0fR+3TXlNYqB2LXTVDlFzJJaJcmSuHBfX9RAbLOtKaf8AY0uq8t42XlLnKYekURg25rvq7XIzrG6H1WUeGs/28kU= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;MWHPR12MB1152;7:nlTs4WYZRkf2V18507ugUCi+NrftfIB5DKTCBZT7zOvza+/ke2GXMn2hA8hz1LS7ymucPxRS95+luOlXVQvnXuv5PwKxCFtjOm4Nuujo80b3S5JA5tqq4KpKE57Owz32hOyUxiG3udKKFBMsRjsLX2cicXnJd7JyjWmjStd7PUPG43Nh4+pLOSVtWrNHkbwJfxXC2m/fmBCbQtMGJnXsrQPhYjpc9GdrW19MsQX5qGRlYAK3Hl6wCl3xWQAkltQF9dnL/m8sNSGtKQPpxXKeN3+b4A5ZD8PFswPc82DLPLwgHMv0rB3J2l4LEjoM8WApYFKNxpUeJvNNE9TDqFmaLYfvQxCtwx4tDoRRUN9/z/nPFpLtXjuBeB+qqu63en6Jif9mXJdTYLwmYbldgsoPctoEqsO14vHAkoAuv3kihfF0Ln4svWWo5SnDY2G9bm0eeOpTrhfq4gjogT8AyHbRwa3VupJ0UOz8tlrKUFV7DcaygfRTclcjSyb/Opc+TWEPNQB33WzwDbI6skzsWMJz2XR6IIMGr0YjkCroyeBPwFSMeMzMFatOjIY258DTL8My8bywuH07/ptMCAbYDiyZ/j7rUqSujBzYqs66KtZWniukbxkD+c3dqO1AUigiP184btvFX7q0yesSru18pgUA43E/NSHKy03rqL8si610f7pCxU4W95igAgbFk0TlwnvS3pGdf66yntDKI/U3ZxIKxWjqpdo241DfMVgoX7yGc/7qCnQwaSnPbIzLrqP/Z6INIKwJmriFdUmaCtBFCxUxOWUzbw3/OZFCm/t324w0bIE= X-Microsoft-Exchange-Diagnostics: 1;MWHPR12MB1152;20:XEBvTBU2FLUCyhFkfALD3EaaO17lx8NKb1jGjF1iWINjL4G96ffsyiRbewoo5gXqJAT7FWzwbI01LL8ARhnG1EvRLFt0+2OVU2N6Pp/pnKu4TXV4vjvjVb34VdDOAGRtRvQbdKXI/hzvKNorg05f+f6IMf2wLg7RUTFUPtcv425k4GqTYQe8mVuEqFuB8z7xxaq5nf6b8Gc37v7Ajaa01KS6/qiDd4cGnyzzsE5HA2qnLODRHoeBy990p5nZE5nZ X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jun 2017 15:37:45.4173 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR12MB1152 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/21/2017 5:50 AM, Borislav Petkov wrote: > On Fri, Jun 16, 2017 at 01:54:36PM -0500, Tom Lendacky wrote: >> Add warnings to let the user know when bounce buffers are being used for >> DMA when SME is active. Since the bounce buffers are not in encrypted >> memory, these notifications are to allow the user to determine some >> appropriate action - if necessary. Actions can range from utilizing an >> IOMMU, replacing the device with another device that can support 64-bit >> DMA, ignoring the message if the device isn't used much, etc. >> >> Signed-off-by: Tom Lendacky >> --- >> include/linux/dma-mapping.h | 11 +++++++++++ >> include/linux/mem_encrypt.h | 8 ++++++++ >> lib/swiotlb.c | 3 +++ >> 3 files changed, 22 insertions(+) >> >> diff --git a/include/linux/dma-mapping.h b/include/linux/dma-mapping.h >> index 4f3eece..ee2307e 100644 >> --- a/include/linux/dma-mapping.h >> +++ b/include/linux/dma-mapping.h >> @@ -10,6 +10,7 @@ >> #include >> #include >> #include >> +#include >> >> /** >> * List of possible attributes associated with a DMA mapping. The semantics >> @@ -577,6 +578,11 @@ static inline int dma_set_mask(struct device *dev, u64 mask) >> >> if (!dev->dma_mask || !dma_supported(dev, mask)) >> return -EIO; >> + >> + /* Since mask is unsigned, this can only be true if SME is active */ >> + if (mask < sme_dma_mask()) >> + dev_warn(dev, "SME is active, device will require DMA bounce buffers\n"); >> + >> *dev->dma_mask = mask; >> return 0; >> } >> @@ -596,6 +602,11 @@ static inline int dma_set_coherent_mask(struct device *dev, u64 mask) >> { >> if (!dma_supported(dev, mask)) >> return -EIO; >> + >> + /* Since mask is unsigned, this can only be true if SME is active */ >> + if (mask < sme_dma_mask()) >> + dev_warn(dev, "SME is active, device will require DMA bounce buffers\n"); > > Looks to me like those two checks above need to be a: > > void sme_check_mask(struct device *dev, u64 mask) > { > if (!sme_me_mask) > return; > > /* Since mask is unsigned, this can only be true if SME is active */ > if (mask < (((u64)sme_me_mask << 1) - 1)) > dev_warn(dev, "SME is active, device will require DMA bounce buffers\n"); > } > > which gets called and sme_dma_mask() is not really needed. Makes a lot of sense, I'll update the patch. Thanks, Tom > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Lendacky Subject: Re: [PATCH v7 25/36] swiotlb: Add warnings for use of bounce buffers with SME Date: Wed, 21 Jun 2017 10:37:41 -0500 Message-ID: <7b9f8b6d-60f2-0a78-b582-0821401d17eb@amd.com> References: <20170616184947.18967.84890.stgit@tlendack-t1.amdoffice.net> <20170616185435.18967.26665.stgit@tlendack-t1.amdoffice.net> <20170621105026.lcbtkklaenyi2wqe@pd.tnic> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20170621105026.lcbtkklaenyi2wqe@pd.tnic> Content-Language: en-US Sender: owner-linux-mm@kvack.org To: Borislav Petkov Cc: linux-arch@vger.kernel.org, linux-efi@vger.kernel.org, kvm@vger.kernel.org, linux-doc@vger.kernel.org, x86@kernel.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, xen-devel@lists.xen.org, linux-mm@kvack.org, iommu@lists.linux-foundation.org, Brijesh Singh , Toshimitsu Kani , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Matt Fleming , Alexander Potapenko , "H. Peter Anvin" , Larry Woodman , Jonathan Corbet , Joerg Roedel , "Michael S. Tsirkin" , Ingo Molnar , Andrey Ryabinin , Dave Young , Rik van Riel , Arnd Bergmann , Konrad Rzeszutek Wilk List-Id: linux-efi@vger.kernel.org On 6/21/2017 5:50 AM, Borislav Petkov wrote: > On Fri, Jun 16, 2017 at 01:54:36PM -0500, Tom Lendacky wrote: >> Add warnings to let the user know when bounce buffers are being used for >> DMA when SME is active. Since the bounce buffers are not in encrypted >> memory, these notifications are to allow the user to determine some >> appropriate action - if necessary. Actions can range from utilizing an >> IOMMU, replacing the device with another device that can support 64-bit >> DMA, ignoring the message if the device isn't used much, etc. >> >> Signed-off-by: Tom Lendacky >> --- >> include/linux/dma-mapping.h | 11 +++++++++++ >> include/linux/mem_encrypt.h | 8 ++++++++ >> lib/swiotlb.c | 3 +++ >> 3 files changed, 22 insertions(+) >> >> diff --git a/include/linux/dma-mapping.h b/include/linux/dma-mapping.h >> index 4f3eece..ee2307e 100644 >> --- a/include/linux/dma-mapping.h >> +++ b/include/linux/dma-mapping.h >> @@ -10,6 +10,7 @@ >> #include >> #include >> #include >> +#include >> >> /** >> * List of possible attributes associated with a DMA mapping. The semantics >> @@ -577,6 +578,11 @@ static inline int dma_set_mask(struct device *dev, u64 mask) >> >> if (!dev->dma_mask || !dma_supported(dev, mask)) >> return -EIO; >> + >> + /* Since mask is unsigned, this can only be true if SME is active */ >> + if (mask < sme_dma_mask()) >> + dev_warn(dev, "SME is active, device will require DMA bounce buffers\n"); >> + >> *dev->dma_mask = mask; >> return 0; >> } >> @@ -596,6 +602,11 @@ static inline int dma_set_coherent_mask(struct device *dev, u64 mask) >> { >> if (!dma_supported(dev, mask)) >> return -EIO; >> + >> + /* Since mask is unsigned, this can only be true if SME is active */ >> + if (mask < sme_dma_mask()) >> + dev_warn(dev, "SME is active, device will require DMA bounce buffers\n"); > > Looks to me like those two checks above need to be a: > > void sme_check_mask(struct device *dev, u64 mask) > { > if (!sme_me_mask) > return; > > /* Since mask is unsigned, this can only be true if SME is active */ > if (mask < (((u64)sme_me_mask << 1) - 1)) > dev_warn(dev, "SME is active, device will require DMA bounce buffers\n"); > } > > which gets called and sme_dma_mask() is not really needed. Makes a lot of sense, I'll update the patch. Thanks, Tom > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f200.google.com (mail-pf0-f200.google.com [209.85.192.200]) by kanga.kvack.org (Postfix) with ESMTP id 9ED616B0412 for ; Wed, 21 Jun 2017 11:37:51 -0400 (EDT) Received: by mail-pf0-f200.google.com with SMTP id d62so40888762pfb.13 for ; Wed, 21 Jun 2017 08:37:51 -0700 (PDT) Received: from NAM03-CO1-obe.outbound.protection.outlook.com (mail-co1nam03on0060.outbound.protection.outlook.com. [104.47.40.60]) by mx.google.com with ESMTPS id g185si13449612pfc.19.2017.06.21.08.37.50 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 21 Jun 2017 08:37:50 -0700 (PDT) Subject: Re: [PATCH v7 25/36] swiotlb: Add warnings for use of bounce buffers with SME References: <20170616184947.18967.84890.stgit@tlendack-t1.amdoffice.net> <20170616185435.18967.26665.stgit@tlendack-t1.amdoffice.net> <20170621105026.lcbtkklaenyi2wqe@pd.tnic> From: Tom Lendacky Message-ID: <7b9f8b6d-60f2-0a78-b582-0821401d17eb@amd.com> Date: Wed, 21 Jun 2017 10:37:41 -0500 MIME-Version: 1.0 In-Reply-To: <20170621105026.lcbtkklaenyi2wqe@pd.tnic> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Borislav Petkov Cc: linux-arch@vger.kernel.org, linux-efi@vger.kernel.org, kvm@vger.kernel.org, linux-doc@vger.kernel.org, x86@kernel.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, xen-devel@lists.xen.org, linux-mm@kvack.org, iommu@lists.linux-foundation.org, Brijesh Singh , Toshimitsu Kani , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Matt Fleming , Alexander Potapenko , "H. Peter Anvin" , Larry Woodman , Jonathan Corbet , Joerg Roedel , "Michael S. Tsirkin" , Ingo Molnar , Andrey Ryabinin , Dave Young , Rik van Riel , Arnd Bergmann , Konrad Rzeszutek Wilk , Andy Lutomirski , Boris Ostrovsky , Dmitry Vyukov , Juergen Gross , Thomas Gleixner , Paolo Bonzini On 6/21/2017 5:50 AM, Borislav Petkov wrote: > On Fri, Jun 16, 2017 at 01:54:36PM -0500, Tom Lendacky wrote: >> Add warnings to let the user know when bounce buffers are being used for >> DMA when SME is active. Since the bounce buffers are not in encrypted >> memory, these notifications are to allow the user to determine some >> appropriate action - if necessary. Actions can range from utilizing an >> IOMMU, replacing the device with another device that can support 64-bit >> DMA, ignoring the message if the device isn't used much, etc. >> >> Signed-off-by: Tom Lendacky >> --- >> include/linux/dma-mapping.h | 11 +++++++++++ >> include/linux/mem_encrypt.h | 8 ++++++++ >> lib/swiotlb.c | 3 +++ >> 3 files changed, 22 insertions(+) >> >> diff --git a/include/linux/dma-mapping.h b/include/linux/dma-mapping.h >> index 4f3eece..ee2307e 100644 >> --- a/include/linux/dma-mapping.h >> +++ b/include/linux/dma-mapping.h >> @@ -10,6 +10,7 @@ >> #include >> #include >> #include >> +#include >> >> /** >> * List of possible attributes associated with a DMA mapping. The semantics >> @@ -577,6 +578,11 @@ static inline int dma_set_mask(struct device *dev, u64 mask) >> >> if (!dev->dma_mask || !dma_supported(dev, mask)) >> return -EIO; >> + >> + /* Since mask is unsigned, this can only be true if SME is active */ >> + if (mask < sme_dma_mask()) >> + dev_warn(dev, "SME is active, device will require DMA bounce buffers\n"); >> + >> *dev->dma_mask = mask; >> return 0; >> } >> @@ -596,6 +602,11 @@ static inline int dma_set_coherent_mask(struct device *dev, u64 mask) >> { >> if (!dma_supported(dev, mask)) >> return -EIO; >> + >> + /* Since mask is unsigned, this can only be true if SME is active */ >> + if (mask < sme_dma_mask()) >> + dev_warn(dev, "SME is active, device will require DMA bounce buffers\n"); > > Looks to me like those two checks above need to be a: > > void sme_check_mask(struct device *dev, u64 mask) > { > if (!sme_me_mask) > return; > > /* Since mask is unsigned, this can only be true if SME is active */ > if (mask < (((u64)sme_me_mask << 1) - 1)) > dev_warn(dev, "SME is active, device will require DMA bounce buffers\n"); > } > > which gets called and sme_dma_mask() is not really needed. Makes a lot of sense, I'll update the patch. Thanks, Tom > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-bn3nam01on0041.outbound.protection.outlook.com ([104.47.33.41] helo=NAM01-BN3-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1dNhhr-0005s8-Ul for kexec@lists.infradead.org; Wed, 21 Jun 2017 15:38:13 +0000 Subject: Re: [PATCH v7 25/36] swiotlb: Add warnings for use of bounce buffers with SME References: <20170616184947.18967.84890.stgit@tlendack-t1.amdoffice.net> <20170616185435.18967.26665.stgit@tlendack-t1.amdoffice.net> <20170621105026.lcbtkklaenyi2wqe@pd.tnic> From: Tom Lendacky Message-ID: <7b9f8b6d-60f2-0a78-b582-0821401d17eb@amd.com> Date: Wed, 21 Jun 2017 10:37:41 -0500 MIME-Version: 1.0 In-Reply-To: <20170621105026.lcbtkklaenyi2wqe@pd.tnic> Content-Language: en-US List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Borislav Petkov Cc: linux-efi@vger.kernel.org, Brijesh Singh , Toshimitsu Kani , linux-doc@vger.kernel.org, Matt Fleming , x86@kernel.org, linux-mm@kvack.org, =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Alexander Potapenko , "H. Peter Anvin" , Larry Woodman , linux-arch@vger.kernel.org, kvm@vger.kernel.org, Jonathan Corbet , Joerg Roedel , "Michael S. Tsirkin" , kasan-dev@googlegroups.com, Ingo Molnar , Andrey Ryabinin , Dave Young , Rik van Riel , Arnd Bergmann , Konrad Rzeszutek Wilk , Andy Lutomirski , Boris Ostrovsky , Dmitry Vyukov , Juergen Gross , kexec@lists.infradead.org, linux-kernel@vger.kernel.org, xen-devel@lists.xen.org, iommu@lists.linux-foundation.org, Thomas Gleixner , Paolo Bonzini On 6/21/2017 5:50 AM, Borislav Petkov wrote: > On Fri, Jun 16, 2017 at 01:54:36PM -0500, Tom Lendacky wrote: >> Add warnings to let the user know when bounce buffers are being used for >> DMA when SME is active. Since the bounce buffers are not in encrypted >> memory, these notifications are to allow the user to determine some >> appropriate action - if necessary. Actions can range from utilizing an >> IOMMU, replacing the device with another device that can support 64-bit >> DMA, ignoring the message if the device isn't used much, etc. >> >> Signed-off-by: Tom Lendacky >> --- >> include/linux/dma-mapping.h | 11 +++++++++++ >> include/linux/mem_encrypt.h | 8 ++++++++ >> lib/swiotlb.c | 3 +++ >> 3 files changed, 22 insertions(+) >> >> diff --git a/include/linux/dma-mapping.h b/include/linux/dma-mapping.h >> index 4f3eece..ee2307e 100644 >> --- a/include/linux/dma-mapping.h >> +++ b/include/linux/dma-mapping.h >> @@ -10,6 +10,7 @@ >> #include >> #include >> #include >> +#include >> >> /** >> * List of possible attributes associated with a DMA mapping. The semantics >> @@ -577,6 +578,11 @@ static inline int dma_set_mask(struct device *dev, u64 mask) >> >> if (!dev->dma_mask || !dma_supported(dev, mask)) >> return -EIO; >> + >> + /* Since mask is unsigned, this can only be true if SME is active */ >> + if (mask < sme_dma_mask()) >> + dev_warn(dev, "SME is active, device will require DMA bounce buffers\n"); >> + >> *dev->dma_mask = mask; >> return 0; >> } >> @@ -596,6 +602,11 @@ static inline int dma_set_coherent_mask(struct device *dev, u64 mask) >> { >> if (!dma_supported(dev, mask)) >> return -EIO; >> + >> + /* Since mask is unsigned, this can only be true if SME is active */ >> + if (mask < sme_dma_mask()) >> + dev_warn(dev, "SME is active, device will require DMA bounce buffers\n"); > > Looks to me like those two checks above need to be a: > > void sme_check_mask(struct device *dev, u64 mask) > { > if (!sme_me_mask) > return; > > /* Since mask is unsigned, this can only be true if SME is active */ > if (mask < (((u64)sme_me_mask << 1) - 1)) > dev_warn(dev, "SME is active, device will require DMA bounce buffers\n"); > } > > which gets called and sme_dma_mask() is not really needed. Makes a lot of sense, I'll update the patch. Thanks, Tom > _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec