Re: [PATCH] Remove ambiguities in the COPYING file; add CONTRIBUTING file

[George Dunlap <george.dunlap@citrix.com>]

On 10/08/16 12:30, Lars Kurth wrote:
> COPYING file:
> The motivation of this change is to make it easier for new
> contributors to conduct a license and patent review, WITHOUT
> changing any licenses.
> - Remove references to BSD-style licenses as we have more
>   common license exceptions and replace with "other license
>   stanzas"
> - List the most common situations under which code is licensed
>   under licenses other than GPLv2 (section "Licensing Exceptions")
> - List the most common non-GPLv2 licenses that are in use in
>   this repository based on a recent FOSSology scan (section
>   "Licensing Exceptions")
> - List other license related conventions within the project
>   to make it easier to conduct a license review.
> - Clarify the incoming license as its omission has confused
>   past contributors (section "Contributions")
> 
> CONTRIBUTION file:
> The motivation of this file is to make it easier for contributors
> to find contribution related resources. Add information on existing
> license related conventions to avoid unintentional future licensing
> issues. Provide templates for copyright headers for the most commonly
> used licenses in this repository.
> 
> Signed-off-by: Lars Kurth <lars.kurth@citrix.com>
> ---
>  CONTRIBUTING | 210 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  COPYING      |  64 ++++++++++++++----
>  2 files changed, 260 insertions(+), 14 deletions(-)
>  create mode 100644 CONTRIBUTING
> 
> diff --git a/CONTRIBUTING b/CONTRIBUTING
> new file mode 100644
> index 0000000..7af13c4
> --- /dev/null
> +++ b/CONTRIBUTING
> @@ -0,0 +1,210 @@
> +
> +CONTRIBUTING
> +============
> +
> +INBOUND LICENSE
> +---------------
> +
> +Contributions are governed by the license that applies to relevant 
> +specific file or by the license specified in the COPYING file, that
> +governs the license of its containing directory and its subdirectories.
> +
> +Most of the Xen Project code is licensed under GPLv2, but a number of 
> +directories are primarily licensed under different licenses. 
> +
> +Most notably:
> + - tools/blktap2      : BSD-Modified
> + - tools/libxc        : LGPL v2.1
> + - tools/libxl        : LGPL v2.1
> + - xen/include/public : MIT license
> +
> +When creating new components and directories that contain a 
> +significant amount of files that are licensed under licenses other 
> +than GPLv2 or the license specified in the COPYING file, please 
> +create a new COPYING file in that directory containing a copy of the 
> +license text and a rationale for using a different license. This helps 
> +ensure that the license of this new component/directory is maintained 
> +consistently with the original intention.
> +
> +When importing code from other upstream projects into this repository, 
> +please create a README.source file in the directory the code is imported 
> +to, listing the original source of the code. An example can be found at 
> +m4/README.source
> +
> +The COMMON COPYRIGHT NOTICES section of this document contains 
> +sample copyright notices for the most common licenses used within 
> +this repository.
> +
> +Developer's Certificate of Origin
> +---------------------------------
> +
> +All patches to the Xen Project code base must include the the line 
> +"Signed-off-by: your_name <your_email>" at the end of the change 
> +description. This is required and indicates that you certify the patch 
> +under the "Developer's Certificate of Origin" which states:
> +
> +  Developer's Certificate of Origin 1.1
> +
> +  By making a contribution to this project, I certify that:
> +
> +  (a) The contribution was created in whole or in part by me and I
> +      have the right to submit it under the open source license
> +      indicated in the file; or
> +
> +  (b) The contribution is based upon previous work that, to the best
> +      of my knowledge, is covered under an appropriate open source
> +      license and I have the right under that license to submit that
> +      work with modifications, whether created in whole or in part
> +      by me, under the same open source license (unless I am
> +      permitted to submit under a different license), as indicated
> +      in the file; or
> +
> +  (c) The contribution was provided directly to me by some other
> +      person who certified (a), (b) or (c) and I have not modified
> +      it.
> +
> +  (d) I understand and agree that this project and the contribution
> +      are public and that a record of the contribution (including all
> +      personal information I submit with it, including my sign-off) is
> +      maintained indefinitely and may be redistributed consistent with
> +      this project or the open source license(s) involved.
> +
> +GOVERNANCE AND WORKFLOW
> +-----------------------
> +
> +The following documents provide a general overview of governance and
> +contribution guidelines for the Xen Project:
> + - https://xenproject.org/governance.html  
> + - https://xenproject.org/help/contribution-guidelines.html 
> +
> +For more information on contributing to this repository, see
> + - CODING_STYLE file in this directory
> + - https://wiki.xenproject.org/wiki/Submitting_Xen_Project_Patches
> + - https://wiki.xenproject.org/wiki/Submitting_Xen_Patches_with_Git
> + - https://wiki.xenproject.org/wiki/Asking_Developer_Questions
> + - https://wiki.xenproject.org/wiki/Category:Developers
> +
> +
> +COMMON COPYRIGHT NOTICES
> +========================
> +
> +The following section contains sample copyright notice for the most 
> +common licenses used within the Xen Project that is consistent with the
> +projects coding standards.
> +
> +GPL v2 License
> +--------------
> +
> +/*
> + * <File name>
> + *
> + * <One line description of the file and what it does>
> + * 
> + * Copyright (C) <year>  <name of author and/or company>
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public
> + * License v2 as published by the Free Software Foundation.

Should this line have "only" in it somewhere?

Other than that, looks great to me -- thanks Lars for all your hard work
on this.

 -George


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel