From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54468)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <wangww.fnst@cn.fujitsu.com>) id 1bptEd-0006Bg-HP
	for qemu-devel@nongnu.org; Fri, 30 Sep 2016 04:32:00 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <wangww.fnst@cn.fujitsu.com>) id 1bptEb-0006RV-JO
	for qemu-devel@nongnu.org; Fri, 30 Sep 2016 04:31:58 -0400
References: <1475040639-30203-1-git-send-email-wangww.fnst@cn.fujitsu.com>
	<20160928103144.GC4196@stefanha-x1.localdomain>
	<cd9164ce-0e8b-4b2a-f32e-36bee65934e4@redhat.com>
From: wangweiwei <wangww.fnst@cn.fujitsu.com>
Message-ID: <7bb73307-effb-c9d6-b988-807b2b3a5633@cn.fujitsu.com>
Date: Fri, 30 Sep 2016 16:30:24 +0800
MIME-Version: 1.0
In-Reply-To: <cd9164ce-0e8b-4b2a-f32e-36bee65934e4@redhat.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH] block: modify top-id's
 comments
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>, Stefan Hajnoczi <stefanha@gmail.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Changlong Xie <xiecl.fnst@cn.fujitsu.com>, Fam Zheng <famz@redhat.com>, zhanghailiang <zhang.zhanghailiang@huawei.com>, qemu block <qemu-block@nongnu.org>, Markus Armbruster <armbru@redhat.com>, Jeff Cody <jcody@redhat.com>, Jiang Yunhong <yunhong.jiang@intel.com>, Dong Eddie <eddie.dong@intel.com>, qemu devel <qemu-devel@nongnu.org>, Max Reitz <mreitz@redhat.com>, Gonglei <arei.gonglei@huawei.com>, Stefan Hajnoczi <stefanha@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, "Dr. David Alan
	Gilbert" <dgilbert@redhat.com>

Ok, I'wll wrap it.
On 09/29/2016 09:35 PM, Eric Blake wrote:
> On 09/28/2016 05:31 AM, Stefan Hajnoczi wrote:
>> On Wed, Sep 28, 2016 at 01:30:39PM +0800, Wang WeiWei wrote:
>>
>> Please send a proper commit message and commit description.  "modify
>> top-id's comments" says almost nothing and there is no commit
>> description.  I don't know why you are making this change so I can't
>> review and apply it.
>>
>
>>> +++ b/qapi/block-core.json
>>> @@ -2184,7 +2184,7 @@
>>>  # @mode: the replication mode
>>>  #
>>>  # @top-id: #optional In secondary mode, node name or device ID of the root
>>> -#          node who owns the replication node chain. Ignored in primary mode.
>>> +#          node who owns the replication node chain. Must not be given in primary mode.
>
> That, and your line exceeds 80 columns; please wrap it.
>