From: David Ahern <dsahern@gmail.com>
To: Moshe Shemesh <moshe@mellanox.com>,
Stephen Hemminger <stephen@networkplumber.org>,
Jakub Kicinski <kuba@kernel.org>, Jiri Pirko <jiri@nvidia.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH iproute2-net v2 1/3] devlink: Add devlink reload action and limit options
Date: Tue, 8 Dec 2020 19:46:43 -0700 [thread overview]
Message-ID: <7bb89ef8-78bf-1264-6921-1d9f15ec2b12@gmail.com> (raw)
In-Reply-To: <1607319322-20970-2-git-send-email-moshe@mellanox.com>
On 12/6/20 10:35 PM, Moshe Shemesh wrote:
> + print_string(PRINT_ANY, NULL, "%s", reload_action_name(action));
That line should be:
print_string(PRINT_ANY, NULL, "%s",
reload_action_name(action));
to fit preferred column widths. By print strings in my previous comment,
I meant don't wrap quoted text.
Fixed and applied.
next prev parent reply other threads:[~2020-12-09 2:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-07 5:35 [PATCH iproute2-net v2 0/3] devlink: Add devlink reload action limit and stats Moshe Shemesh
2020-12-07 5:35 ` [PATCH iproute2-net v2 1/3] devlink: Add devlink reload action and limit options Moshe Shemesh
2020-12-09 2:46 ` David Ahern [this message]
2020-12-09 5:32 ` Moshe Shemesh
2020-12-07 5:35 ` [PATCH iproute2-net v2 2/3] devlink: Add pr_out_dev() helper function Moshe Shemesh
2020-12-07 5:35 ` [PATCH iproute2-net v2 3/3] devlink: Add reload stats to dev show Moshe Shemesh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7bb89ef8-78bf-1264-6921-1d9f15ec2b12@gmail.com \
--to=dsahern@gmail.com \
--cc=jiri@nvidia.com \
--cc=kuba@kernel.org \
--cc=moshe@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.