From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7253CC2D0E4 for ; Mon, 23 Nov 2020 10:49:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0BA4B207FF for ; Mon, 23 Nov 2020 10:49:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="GZiTm1ui" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728796AbgKWKt2 (ORCPT ); Mon, 23 Nov 2020 05:49:28 -0500 Received: from mail.kernel.org ([198.145.29.99]:42170 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728523AbgKWKt1 (ORCPT ); Mon, 23 Nov 2020 05:49:27 -0500 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5E85F20721; Mon, 23 Nov 2020 10:49:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1606128565; bh=FVXXoRtxeNSHeXC+MN7Fmb60y4SrrZ1lu3dPmXQA4V0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=GZiTm1uizupDL2CKQ2nO6GOQBW7NrtZuOYT8myiVKZU4qg1AtN46rvO47OtuhmkFu 4ViSzyeuCTau501Xr3H/6oArwCEOIDsSLeGKEhubGdrq2G0AM0Q1+YvQDdrLAOzwjG 9oc8TcdPJYxO5j6fEZ2iZFKl2girgr8TzfWmNqb8= Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94) (envelope-from ) id 1kh9PP-00Ct2d-3n; Mon, 23 Nov 2020 10:49:23 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 23 Nov 2020 10:49:23 +0000 From: Marc Zyngier To: Jianyong Wu Cc: netdev@vger.kernel.org, yangbo.lu@nxp.com, john.stultz@linaro.org, tglx@linutronix.de, pbonzini@redhat.com, sean.j.christopherson@intel.com, richardcochran@gmail.com, Mark.Rutland@arm.com, will@kernel.org, suzuki.poulose@arm.com, Andre.Przywara@arm.com, steven.price@arm.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, Steve.Capper@arm.com, justin.he@arm.com, nd@arm.com Subject: Re: [PATCH v15 7/9] ptp: arm/arm64: Enable ptp_kvm for arm/arm64 In-Reply-To: <20201111062211.33144-8-jianyong.wu@arm.com> References: <20201111062211.33144-1-jianyong.wu@arm.com> <20201111062211.33144-8-jianyong.wu@arm.com> User-Agent: Roundcube Webmail/1.4.9 Message-ID: <7bd3a66253ca4b7adbe2294eb598a23f@kernel.org> X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: jianyong.wu@arm.com, netdev@vger.kernel.org, yangbo.lu@nxp.com, john.stultz@linaro.org, tglx@linutronix.de, pbonzini@redhat.com, sean.j.christopherson@intel.com, richardcochran@gmail.com, Mark.Rutland@arm.com, will@kernel.org, suzuki.poulose@arm.com, Andre.Przywara@arm.com, steven.price@arm.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, Steve.Capper@arm.com, justin.he@arm.com, nd@arm.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020-11-11 06:22, Jianyong Wu wrote: > Currently, there is no mechanism to keep time sync between guest and > host > in arm/arm64 virtualization environment. Time in guest will drift > compared > with host after boot up as they may both use third party time sources > to correct their time respectively. The time deviation will be in order > of milliseconds. But in some scenarios,like in cloud envirenment, we > ask environment > for higher time precision. > > kvm ptp clock, which chooses the host clock source as a reference > clock to sync time between guest and host, has been adopted by x86 > which takes the time sync order from milliseconds to nanoseconds. > > This patch enables kvm ptp clock for arm/arm64 and improves clock sync > precison precision > significantly. > > Test result comparisons between with kvm ptp clock and without it in > arm/arm64 > are as follows. This test derived from the result of command 'chronyc > sources'. we should take more care of the last sample column which > shows > the offset between the local clock and the source at the last > measurement. > > no kvm ptp in guest: > MS Name/IP address Stratum Poll Reach LastRx Last sample > ======================================================================== > ^* dns1.synet.edu.cn 2 6 377 13 +1040us[+1581us] +/- > 21ms > ^* dns1.synet.edu.cn 2 6 377 21 +1040us[+1581us] +/- > 21ms > ^* dns1.synet.edu.cn 2 6 377 29 +1040us[+1581us] +/- > 21ms > ^* dns1.synet.edu.cn 2 6 377 37 +1040us[+1581us] +/- > 21ms > ^* dns1.synet.edu.cn 2 6 377 45 +1040us[+1581us] +/- > 21ms > ^* dns1.synet.edu.cn 2 6 377 53 +1040us[+1581us] +/- > 21ms > ^* dns1.synet.edu.cn 2 6 377 61 +1040us[+1581us] +/- > 21ms > ^* dns1.synet.edu.cn 2 6 377 4 -130us[ +796us] +/- > 21ms > ^* dns1.synet.edu.cn 2 6 377 12 -130us[ +796us] +/- > 21ms > ^* dns1.synet.edu.cn 2 6 377 20 -130us[ +796us] +/- > 21ms > > in host: > MS Name/IP address Stratum Poll Reach LastRx Last sample > ======================================================================== > ^* 120.25.115.20 2 7 377 72 -470us[ -603us] +/- > 18ms > ^* 120.25.115.20 2 7 377 92 -470us[ -603us] +/- > 18ms > ^* 120.25.115.20 2 7 377 112 -470us[ -603us] +/- > 18ms > ^* 120.25.115.20 2 7 377 2 +872ns[-6808ns] +/- > 17ms > ^* 120.25.115.20 2 7 377 22 +872ns[-6808ns] +/- > 17ms > ^* 120.25.115.20 2 7 377 43 +872ns[-6808ns] +/- > 17ms > ^* 120.25.115.20 2 7 377 63 +872ns[-6808ns] +/- > 17ms > ^* 120.25.115.20 2 7 377 83 +872ns[-6808ns] +/- > 17ms > ^* 120.25.115.20 2 7 377 103 +872ns[-6808ns] +/- > 17ms > ^* 120.25.115.20 2 7 377 123 +872ns[-6808ns] +/- > 17ms > > The dns1.synet.edu.cn is the network reference clock for guest and > 120.25.115.20 is the network reference clock for host. we can't get the > clock error between guest and host directly, but a roughly estimated > value > will be in order of hundreds of us to ms. > > with kvm ptp in guest: > chrony has been disabled in host to remove the disturb by network > clock. > > MS Name/IP address Stratum Poll Reach LastRx Last sample > ======================================================================== > * PHC0 0 3 377 8 -7ns[ +1ns] +/- > 3ns > * PHC0 0 3 377 8 +1ns[ +16ns] +/- > 3ns > * PHC0 0 3 377 6 -4ns[ -0ns] +/- > 6ns > * PHC0 0 3 377 6 -8ns[ -12ns] +/- > 5ns > * PHC0 0 3 377 5 +2ns[ +4ns] +/- > 4ns > * PHC0 0 3 377 13 +2ns[ +4ns] +/- > 4ns > * PHC0 0 3 377 12 -4ns[ -6ns] +/- > 4ns > * PHC0 0 3 377 11 -8ns[ -11ns] +/- > 6ns > * PHC0 0 3 377 10 -14ns[ -20ns] +/- > 4ns > * PHC0 0 3 377 8 +4ns[ +5ns] +/- > 4ns > > The PHC0 is the ptp clock which choose the host clock as its source > clock. So we can see that the clock difference between host and guest > is in order of ns. > > Signed-off-by: Jianyong Wu > --- > drivers/clocksource/arm_arch_timer.c | 28 ++++++++++++++++++ > drivers/ptp/Kconfig | 2 +- > drivers/ptp/Makefile | 1 + > drivers/ptp/ptp_kvm_arm.c | 44 ++++++++++++++++++++++++++++ > 4 files changed, 74 insertions(+), 1 deletion(-) > create mode 100644 drivers/ptp/ptp_kvm_arm.c > > diff --git a/drivers/clocksource/arm_arch_timer.c > b/drivers/clocksource/arm_arch_timer.c > index d55acffb0b90..b33c5a663d30 100644 > --- a/drivers/clocksource/arm_arch_timer.c > +++ b/drivers/clocksource/arm_arch_timer.c > @@ -25,6 +25,7 @@ > #include > #include > #include > +#include > > #include > #include > @@ -1650,3 +1651,30 @@ static int __init arch_timer_acpi_init(struct > acpi_table_header *table) > } > TIMER_ACPI_DECLARE(arch_timer, ACPI_SIG_GTDT, arch_timer_acpi_init); > #endif > + > +int kvm_arch_ptp_get_crosststamp(u64 *cycle, struct timespec64 *ts, > + struct clocksource **cs) > +{ > + struct arm_smccc_res hvc_res; > + ktime_t ktime; > + u32 ptp_counter; > + > + if (arch_timer_uses_ppi == ARCH_TIMER_VIRT_PPI) > + ptp_counter = ARM_PTP_VIRT_COUNTER; > + else > + ptp_counter = ARM_PTP_PHY_COUNTER; > + > + arm_smccc_1_1_invoke(ARM_SMCCC_VENDOR_HYP_KVM_PTP_FUNC_ID, > + ptp_counter, &hvc_res); > + > + if ((int)(hvc_res.a0) < 0) > + return -EOPNOTSUPP; > + > + ktime = (u64)hvc_res.a0 << 32 | hvc_res.a1; > + *ts = ktime_to_timespec64(ktime); > + *cycle = (u64)hvc_res.a2 << 32 | hvc_res.a3; Endianness. > + *cs = &clocksource_counter; > + > + return 0; > +} > +EXPORT_SYMBOL_GPL(kvm_arch_ptp_get_crosststamp); > diff --git a/drivers/ptp/Kconfig b/drivers/ptp/Kconfig > index 942f72d8151d..677c7f696b70 100644 > --- a/drivers/ptp/Kconfig > +++ b/drivers/ptp/Kconfig > @@ -106,7 +106,7 @@ config PTP_1588_CLOCK_PCH > config PTP_1588_CLOCK_KVM > tristate "KVM virtual PTP clock" > depends on PTP_1588_CLOCK > - depends on KVM_GUEST && X86 > + depends on KVM_GUEST && X86 || (HAVE_ARM_SMCCC_DISCOVERY && > ARM_ARCH_TIMER) > default y > help > This driver adds support for using kvm infrastructure as a PTP > diff --git a/drivers/ptp/Makefile b/drivers/ptp/Makefile > index 699a4e4d19c2..9fa5ede44b2b 100644 > --- a/drivers/ptp/Makefile > +++ b/drivers/ptp/Makefile > @@ -5,6 +5,7 @@ > > ptp-y := ptp_clock.o ptp_chardev.o ptp_sysfs.o > ptp_kvm-$(CONFIG_X86) := ptp_kvm_x86.o ptp_kvm_common.o > +ptp_kvm-$(CONFIG_HAVE_ARM_SMCCC) := ptp_kvm_arm.o ptp_kvm_common.o > obj-$(CONFIG_PTP_1588_CLOCK) += ptp.o > obj-$(CONFIG_PTP_1588_CLOCK_DTE) += ptp_dte.o > obj-$(CONFIG_PTP_1588_CLOCK_INES) += ptp_ines.o > diff --git a/drivers/ptp/ptp_kvm_arm.c b/drivers/ptp/ptp_kvm_arm.c > new file mode 100644 > index 000000000000..2212827c0384 > --- /dev/null > +++ b/drivers/ptp/ptp_kvm_arm.c > @@ -0,0 +1,44 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/* > + * Virtual PTP 1588 clock for use with KVM guests > + * Copyright (C) 2019 ARM Ltd. > + * All Rights Reserved > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +int kvm_arch_ptp_init(void) > +{ > + int ret; > + > + ret = kvm_arm_hyp_service_available(ARM_SMCCC_KVM_FUNC_KVM_PTP); > + if (ret <= 0) > + return -EOPNOTSUPP; > + > + return 0; > +} > + > +int kvm_arch_ptp_get_clock(struct timespec64 *ts) > +{ > + ktime_t ktime; > + struct arm_smccc_res hvc_res; > + > + arm_smccc_1_1_invoke(ARM_SMCCC_VENDOR_HYP_KVM_PTP_FUNC_ID, > + ARM_PTP_NONE_COUNTER, &hvc_res); I really don't see the need to use a non-architectural counter ID. Using the virtual counter ID should just be fine, and shouldn't lead to any issue. Am I missing something? > + if ((int)(hvc_res.a0) < 0) > + return -EOPNOTSUPP; > + > + ktime = (u64)hvc_res.a0 << 32 | hvc_res.a1; Endianness. > + *ts = ktime_to_timespec64(ktime); > + > + return 0; > +} Thanks, M. -- Jazz is not dead. It just smells funny... From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B15C7C2D0E4 for ; Mon, 23 Nov 2020 10:49:35 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id F0A0820721 for ; Mon, 23 Nov 2020 10:49:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="GZiTm1ui" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F0A0820721 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 3CAD44B74D; Mon, 23 Nov 2020 05:49:34 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@kernel.org Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xZuYF+ulkxlU; Mon, 23 Nov 2020 05:49:29 -0500 (EST) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 87A274BAC3; Mon, 23 Nov 2020 05:49:29 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 4BDAA4B762 for ; Mon, 23 Nov 2020 05:49:28 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id K-UegxkaUWeX for ; Mon, 23 Nov 2020 05:49:26 -0500 (EST) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id B240E4B74D for ; Mon, 23 Nov 2020 05:49:26 -0500 (EST) Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5E85F20721; Mon, 23 Nov 2020 10:49:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1606128565; bh=FVXXoRtxeNSHeXC+MN7Fmb60y4SrrZ1lu3dPmXQA4V0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=GZiTm1uizupDL2CKQ2nO6GOQBW7NrtZuOYT8myiVKZU4qg1AtN46rvO47OtuhmkFu 4ViSzyeuCTau501Xr3H/6oArwCEOIDsSLeGKEhubGdrq2G0AM0Q1+YvQDdrLAOzwjG 9oc8TcdPJYxO5j6fEZ2iZFKl2girgr8TzfWmNqb8= Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94) (envelope-from ) id 1kh9PP-00Ct2d-3n; Mon, 23 Nov 2020 10:49:23 +0000 MIME-Version: 1.0 Date: Mon, 23 Nov 2020 10:49:23 +0000 From: Marc Zyngier To: Jianyong Wu Subject: Re: [PATCH v15 7/9] ptp: arm/arm64: Enable ptp_kvm for arm/arm64 In-Reply-To: <20201111062211.33144-8-jianyong.wu@arm.com> References: <20201111062211.33144-1-jianyong.wu@arm.com> <20201111062211.33144-8-jianyong.wu@arm.com> User-Agent: Roundcube Webmail/1.4.9 Message-ID: <7bd3a66253ca4b7adbe2294eb598a23f@kernel.org> X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: jianyong.wu@arm.com, netdev@vger.kernel.org, yangbo.lu@nxp.com, john.stultz@linaro.org, tglx@linutronix.de, pbonzini@redhat.com, sean.j.christopherson@intel.com, richardcochran@gmail.com, Mark.Rutland@arm.com, will@kernel.org, suzuki.poulose@arm.com, Andre.Przywara@arm.com, steven.price@arm.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, Steve.Capper@arm.com, justin.he@arm.com, nd@arm.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Cc: justin.he@arm.com, kvm@vger.kernel.org, netdev@vger.kernel.org, richardcochran@gmail.com, linux-kernel@vger.kernel.org, sean.j.christopherson@intel.com, steven.price@arm.com, Andre.Przywara@arm.com, john.stultz@linaro.org, yangbo.lu@nxp.com, pbonzini@redhat.com, tglx@linutronix.de, nd@arm.com, will@kernel.org, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On 2020-11-11 06:22, Jianyong Wu wrote: > Currently, there is no mechanism to keep time sync between guest and > host > in arm/arm64 virtualization environment. Time in guest will drift > compared > with host after boot up as they may both use third party time sources > to correct their time respectively. The time deviation will be in order > of milliseconds. But in some scenarios,like in cloud envirenment, we > ask environment > for higher time precision. > > kvm ptp clock, which chooses the host clock source as a reference > clock to sync time between guest and host, has been adopted by x86 > which takes the time sync order from milliseconds to nanoseconds. > > This patch enables kvm ptp clock for arm/arm64 and improves clock sync > precison precision > significantly. > > Test result comparisons between with kvm ptp clock and without it in > arm/arm64 > are as follows. This test derived from the result of command 'chronyc > sources'. we should take more care of the last sample column which > shows > the offset between the local clock and the source at the last > measurement. > > no kvm ptp in guest: > MS Name/IP address Stratum Poll Reach LastRx Last sample > ======================================================================== > ^* dns1.synet.edu.cn 2 6 377 13 +1040us[+1581us] +/- > 21ms > ^* dns1.synet.edu.cn 2 6 377 21 +1040us[+1581us] +/- > 21ms > ^* dns1.synet.edu.cn 2 6 377 29 +1040us[+1581us] +/- > 21ms > ^* dns1.synet.edu.cn 2 6 377 37 +1040us[+1581us] +/- > 21ms > ^* dns1.synet.edu.cn 2 6 377 45 +1040us[+1581us] +/- > 21ms > ^* dns1.synet.edu.cn 2 6 377 53 +1040us[+1581us] +/- > 21ms > ^* dns1.synet.edu.cn 2 6 377 61 +1040us[+1581us] +/- > 21ms > ^* dns1.synet.edu.cn 2 6 377 4 -130us[ +796us] +/- > 21ms > ^* dns1.synet.edu.cn 2 6 377 12 -130us[ +796us] +/- > 21ms > ^* dns1.synet.edu.cn 2 6 377 20 -130us[ +796us] +/- > 21ms > > in host: > MS Name/IP address Stratum Poll Reach LastRx Last sample > ======================================================================== > ^* 120.25.115.20 2 7 377 72 -470us[ -603us] +/- > 18ms > ^* 120.25.115.20 2 7 377 92 -470us[ -603us] +/- > 18ms > ^* 120.25.115.20 2 7 377 112 -470us[ -603us] +/- > 18ms > ^* 120.25.115.20 2 7 377 2 +872ns[-6808ns] +/- > 17ms > ^* 120.25.115.20 2 7 377 22 +872ns[-6808ns] +/- > 17ms > ^* 120.25.115.20 2 7 377 43 +872ns[-6808ns] +/- > 17ms > ^* 120.25.115.20 2 7 377 63 +872ns[-6808ns] +/- > 17ms > ^* 120.25.115.20 2 7 377 83 +872ns[-6808ns] +/- > 17ms > ^* 120.25.115.20 2 7 377 103 +872ns[-6808ns] +/- > 17ms > ^* 120.25.115.20 2 7 377 123 +872ns[-6808ns] +/- > 17ms > > The dns1.synet.edu.cn is the network reference clock for guest and > 120.25.115.20 is the network reference clock for host. we can't get the > clock error between guest and host directly, but a roughly estimated > value > will be in order of hundreds of us to ms. > > with kvm ptp in guest: > chrony has been disabled in host to remove the disturb by network > clock. > > MS Name/IP address Stratum Poll Reach LastRx Last sample > ======================================================================== > * PHC0 0 3 377 8 -7ns[ +1ns] +/- > 3ns > * PHC0 0 3 377 8 +1ns[ +16ns] +/- > 3ns > * PHC0 0 3 377 6 -4ns[ -0ns] +/- > 6ns > * PHC0 0 3 377 6 -8ns[ -12ns] +/- > 5ns > * PHC0 0 3 377 5 +2ns[ +4ns] +/- > 4ns > * PHC0 0 3 377 13 +2ns[ +4ns] +/- > 4ns > * PHC0 0 3 377 12 -4ns[ -6ns] +/- > 4ns > * PHC0 0 3 377 11 -8ns[ -11ns] +/- > 6ns > * PHC0 0 3 377 10 -14ns[ -20ns] +/- > 4ns > * PHC0 0 3 377 8 +4ns[ +5ns] +/- > 4ns > > The PHC0 is the ptp clock which choose the host clock as its source > clock. So we can see that the clock difference between host and guest > is in order of ns. > > Signed-off-by: Jianyong Wu > --- > drivers/clocksource/arm_arch_timer.c | 28 ++++++++++++++++++ > drivers/ptp/Kconfig | 2 +- > drivers/ptp/Makefile | 1 + > drivers/ptp/ptp_kvm_arm.c | 44 ++++++++++++++++++++++++++++ > 4 files changed, 74 insertions(+), 1 deletion(-) > create mode 100644 drivers/ptp/ptp_kvm_arm.c > > diff --git a/drivers/clocksource/arm_arch_timer.c > b/drivers/clocksource/arm_arch_timer.c > index d55acffb0b90..b33c5a663d30 100644 > --- a/drivers/clocksource/arm_arch_timer.c > +++ b/drivers/clocksource/arm_arch_timer.c > @@ -25,6 +25,7 @@ > #include > #include > #include > +#include > > #include > #include > @@ -1650,3 +1651,30 @@ static int __init arch_timer_acpi_init(struct > acpi_table_header *table) > } > TIMER_ACPI_DECLARE(arch_timer, ACPI_SIG_GTDT, arch_timer_acpi_init); > #endif > + > +int kvm_arch_ptp_get_crosststamp(u64 *cycle, struct timespec64 *ts, > + struct clocksource **cs) > +{ > + struct arm_smccc_res hvc_res; > + ktime_t ktime; > + u32 ptp_counter; > + > + if (arch_timer_uses_ppi == ARCH_TIMER_VIRT_PPI) > + ptp_counter = ARM_PTP_VIRT_COUNTER; > + else > + ptp_counter = ARM_PTP_PHY_COUNTER; > + > + arm_smccc_1_1_invoke(ARM_SMCCC_VENDOR_HYP_KVM_PTP_FUNC_ID, > + ptp_counter, &hvc_res); > + > + if ((int)(hvc_res.a0) < 0) > + return -EOPNOTSUPP; > + > + ktime = (u64)hvc_res.a0 << 32 | hvc_res.a1; > + *ts = ktime_to_timespec64(ktime); > + *cycle = (u64)hvc_res.a2 << 32 | hvc_res.a3; Endianness. > + *cs = &clocksource_counter; > + > + return 0; > +} > +EXPORT_SYMBOL_GPL(kvm_arch_ptp_get_crosststamp); > diff --git a/drivers/ptp/Kconfig b/drivers/ptp/Kconfig > index 942f72d8151d..677c7f696b70 100644 > --- a/drivers/ptp/Kconfig > +++ b/drivers/ptp/Kconfig > @@ -106,7 +106,7 @@ config PTP_1588_CLOCK_PCH > config PTP_1588_CLOCK_KVM > tristate "KVM virtual PTP clock" > depends on PTP_1588_CLOCK > - depends on KVM_GUEST && X86 > + depends on KVM_GUEST && X86 || (HAVE_ARM_SMCCC_DISCOVERY && > ARM_ARCH_TIMER) > default y > help > This driver adds support for using kvm infrastructure as a PTP > diff --git a/drivers/ptp/Makefile b/drivers/ptp/Makefile > index 699a4e4d19c2..9fa5ede44b2b 100644 > --- a/drivers/ptp/Makefile > +++ b/drivers/ptp/Makefile > @@ -5,6 +5,7 @@ > > ptp-y := ptp_clock.o ptp_chardev.o ptp_sysfs.o > ptp_kvm-$(CONFIG_X86) := ptp_kvm_x86.o ptp_kvm_common.o > +ptp_kvm-$(CONFIG_HAVE_ARM_SMCCC) := ptp_kvm_arm.o ptp_kvm_common.o > obj-$(CONFIG_PTP_1588_CLOCK) += ptp.o > obj-$(CONFIG_PTP_1588_CLOCK_DTE) += ptp_dte.o > obj-$(CONFIG_PTP_1588_CLOCK_INES) += ptp_ines.o > diff --git a/drivers/ptp/ptp_kvm_arm.c b/drivers/ptp/ptp_kvm_arm.c > new file mode 100644 > index 000000000000..2212827c0384 > --- /dev/null > +++ b/drivers/ptp/ptp_kvm_arm.c > @@ -0,0 +1,44 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/* > + * Virtual PTP 1588 clock for use with KVM guests > + * Copyright (C) 2019 ARM Ltd. > + * All Rights Reserved > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +int kvm_arch_ptp_init(void) > +{ > + int ret; > + > + ret = kvm_arm_hyp_service_available(ARM_SMCCC_KVM_FUNC_KVM_PTP); > + if (ret <= 0) > + return -EOPNOTSUPP; > + > + return 0; > +} > + > +int kvm_arch_ptp_get_clock(struct timespec64 *ts) > +{ > + ktime_t ktime; > + struct arm_smccc_res hvc_res; > + > + arm_smccc_1_1_invoke(ARM_SMCCC_VENDOR_HYP_KVM_PTP_FUNC_ID, > + ARM_PTP_NONE_COUNTER, &hvc_res); I really don't see the need to use a non-architectural counter ID. Using the virtual counter ID should just be fine, and shouldn't lead to any issue. Am I missing something? > + if ((int)(hvc_res.a0) < 0) > + return -EOPNOTSUPP; > + > + ktime = (u64)hvc_res.a0 << 32 | hvc_res.a1; Endianness. > + *ts = ktime_to_timespec64(ktime); > + > + return 0; > +} Thanks, M. -- Jazz is not dead. It just smells funny... _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D324C2D0E4 for ; Mon, 23 Nov 2020 10:50:49 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7AA9820721 for ; Mon, 23 Nov 2020 10:50:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="zraSLP+a"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="GZiTm1ui" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7AA9820721 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:To:From: Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=DbGxufzQHJacFKqFKYYXWvua+zTzoyw09F7t/+sJgA4=; b=zraSLP+aIsK0z3vy8j0SRaoZy KrLOmZdYVHt/kiHXtrnwcZ9tp4EvCsDcL4QbK41lxHdEMDBG2+/shrw/EJrgXrnTmeZIRaRmT+rJa 6meLZ/KkUnfkEXFh+A5ZSqyKhp4Gw8PmdXJfeLKqysnQRBrZncbBTmjlUUqOLMMC9y5B01CucCgE0 Wsp8O5CTajIAjsOZEsb86XmHcU835w/vU9JVI4o/Yf5mmSdcdEBp0rXa1bQVivukjyH3l84G/CVRi AgKnJ+e2oTkNcy+96o0tRn80go6zxV7ZTxR5G4BMskj8Vpi/CNasjCnLq56eLsi8HXDUsMn7XErnt CxRI15LnA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kh9PY-0006Oe-8M; Mon, 23 Nov 2020 10:49:32 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kh9PS-0006Nx-M3 for linux-arm-kernel@lists.infradead.org; Mon, 23 Nov 2020 10:49:30 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5E85F20721; Mon, 23 Nov 2020 10:49:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1606128565; bh=FVXXoRtxeNSHeXC+MN7Fmb60y4SrrZ1lu3dPmXQA4V0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=GZiTm1uizupDL2CKQ2nO6GOQBW7NrtZuOYT8myiVKZU4qg1AtN46rvO47OtuhmkFu 4ViSzyeuCTau501Xr3H/6oArwCEOIDsSLeGKEhubGdrq2G0AM0Q1+YvQDdrLAOzwjG 9oc8TcdPJYxO5j6fEZ2iZFKl2girgr8TzfWmNqb8= Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94) (envelope-from ) id 1kh9PP-00Ct2d-3n; Mon, 23 Nov 2020 10:49:23 +0000 MIME-Version: 1.0 Date: Mon, 23 Nov 2020 10:49:23 +0000 From: Marc Zyngier To: Jianyong Wu Subject: Re: [PATCH v15 7/9] ptp: arm/arm64: Enable ptp_kvm for arm/arm64 In-Reply-To: <20201111062211.33144-8-jianyong.wu@arm.com> References: <20201111062211.33144-1-jianyong.wu@arm.com> <20201111062211.33144-8-jianyong.wu@arm.com> User-Agent: Roundcube Webmail/1.4.9 Message-ID: <7bd3a66253ca4b7adbe2294eb598a23f@kernel.org> X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: jianyong.wu@arm.com, netdev@vger.kernel.org, yangbo.lu@nxp.com, john.stultz@linaro.org, tglx@linutronix.de, pbonzini@redhat.com, sean.j.christopherson@intel.com, richardcochran@gmail.com, Mark.Rutland@arm.com, will@kernel.org, suzuki.poulose@arm.com, Andre.Przywara@arm.com, steven.price@arm.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, Steve.Capper@arm.com, justin.he@arm.com, nd@arm.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201123_054926_873937_59B502CF X-CRM114-Status: GOOD ( 36.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark.Rutland@arm.com, justin.he@arm.com, kvm@vger.kernel.org, suzuki.poulose@arm.com, netdev@vger.kernel.org, richardcochran@gmail.com, Steve.Capper@arm.com, linux-kernel@vger.kernel.org, sean.j.christopherson@intel.com, steven.price@arm.com, Andre.Przywara@arm.com, john.stultz@linaro.org, yangbo.lu@nxp.com, pbonzini@redhat.com, tglx@linutronix.de, nd@arm.com, will@kernel.org, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2020-11-11 06:22, Jianyong Wu wrote: > Currently, there is no mechanism to keep time sync between guest and > host > in arm/arm64 virtualization environment. Time in guest will drift > compared > with host after boot up as they may both use third party time sources > to correct their time respectively. The time deviation will be in order > of milliseconds. But in some scenarios,like in cloud envirenment, we > ask environment > for higher time precision. > > kvm ptp clock, which chooses the host clock source as a reference > clock to sync time between guest and host, has been adopted by x86 > which takes the time sync order from milliseconds to nanoseconds. > > This patch enables kvm ptp clock for arm/arm64 and improves clock sync > precison precision > significantly. > > Test result comparisons between with kvm ptp clock and without it in > arm/arm64 > are as follows. This test derived from the result of command 'chronyc > sources'. we should take more care of the last sample column which > shows > the offset between the local clock and the source at the last > measurement. > > no kvm ptp in guest: > MS Name/IP address Stratum Poll Reach LastRx Last sample > ======================================================================== > ^* dns1.synet.edu.cn 2 6 377 13 +1040us[+1581us] +/- > 21ms > ^* dns1.synet.edu.cn 2 6 377 21 +1040us[+1581us] +/- > 21ms > ^* dns1.synet.edu.cn 2 6 377 29 +1040us[+1581us] +/- > 21ms > ^* dns1.synet.edu.cn 2 6 377 37 +1040us[+1581us] +/- > 21ms > ^* dns1.synet.edu.cn 2 6 377 45 +1040us[+1581us] +/- > 21ms > ^* dns1.synet.edu.cn 2 6 377 53 +1040us[+1581us] +/- > 21ms > ^* dns1.synet.edu.cn 2 6 377 61 +1040us[+1581us] +/- > 21ms > ^* dns1.synet.edu.cn 2 6 377 4 -130us[ +796us] +/- > 21ms > ^* dns1.synet.edu.cn 2 6 377 12 -130us[ +796us] +/- > 21ms > ^* dns1.synet.edu.cn 2 6 377 20 -130us[ +796us] +/- > 21ms > > in host: > MS Name/IP address Stratum Poll Reach LastRx Last sample > ======================================================================== > ^* 120.25.115.20 2 7 377 72 -470us[ -603us] +/- > 18ms > ^* 120.25.115.20 2 7 377 92 -470us[ -603us] +/- > 18ms > ^* 120.25.115.20 2 7 377 112 -470us[ -603us] +/- > 18ms > ^* 120.25.115.20 2 7 377 2 +872ns[-6808ns] +/- > 17ms > ^* 120.25.115.20 2 7 377 22 +872ns[-6808ns] +/- > 17ms > ^* 120.25.115.20 2 7 377 43 +872ns[-6808ns] +/- > 17ms > ^* 120.25.115.20 2 7 377 63 +872ns[-6808ns] +/- > 17ms > ^* 120.25.115.20 2 7 377 83 +872ns[-6808ns] +/- > 17ms > ^* 120.25.115.20 2 7 377 103 +872ns[-6808ns] +/- > 17ms > ^* 120.25.115.20 2 7 377 123 +872ns[-6808ns] +/- > 17ms > > The dns1.synet.edu.cn is the network reference clock for guest and > 120.25.115.20 is the network reference clock for host. we can't get the > clock error between guest and host directly, but a roughly estimated > value > will be in order of hundreds of us to ms. > > with kvm ptp in guest: > chrony has been disabled in host to remove the disturb by network > clock. > > MS Name/IP address Stratum Poll Reach LastRx Last sample > ======================================================================== > * PHC0 0 3 377 8 -7ns[ +1ns] +/- > 3ns > * PHC0 0 3 377 8 +1ns[ +16ns] +/- > 3ns > * PHC0 0 3 377 6 -4ns[ -0ns] +/- > 6ns > * PHC0 0 3 377 6 -8ns[ -12ns] +/- > 5ns > * PHC0 0 3 377 5 +2ns[ +4ns] +/- > 4ns > * PHC0 0 3 377 13 +2ns[ +4ns] +/- > 4ns > * PHC0 0 3 377 12 -4ns[ -6ns] +/- > 4ns > * PHC0 0 3 377 11 -8ns[ -11ns] +/- > 6ns > * PHC0 0 3 377 10 -14ns[ -20ns] +/- > 4ns > * PHC0 0 3 377 8 +4ns[ +5ns] +/- > 4ns > > The PHC0 is the ptp clock which choose the host clock as its source > clock. So we can see that the clock difference between host and guest > is in order of ns. > > Signed-off-by: Jianyong Wu > --- > drivers/clocksource/arm_arch_timer.c | 28 ++++++++++++++++++ > drivers/ptp/Kconfig | 2 +- > drivers/ptp/Makefile | 1 + > drivers/ptp/ptp_kvm_arm.c | 44 ++++++++++++++++++++++++++++ > 4 files changed, 74 insertions(+), 1 deletion(-) > create mode 100644 drivers/ptp/ptp_kvm_arm.c > > diff --git a/drivers/clocksource/arm_arch_timer.c > b/drivers/clocksource/arm_arch_timer.c > index d55acffb0b90..b33c5a663d30 100644 > --- a/drivers/clocksource/arm_arch_timer.c > +++ b/drivers/clocksource/arm_arch_timer.c > @@ -25,6 +25,7 @@ > #include > #include > #include > +#include > > #include > #include > @@ -1650,3 +1651,30 @@ static int __init arch_timer_acpi_init(struct > acpi_table_header *table) > } > TIMER_ACPI_DECLARE(arch_timer, ACPI_SIG_GTDT, arch_timer_acpi_init); > #endif > + > +int kvm_arch_ptp_get_crosststamp(u64 *cycle, struct timespec64 *ts, > + struct clocksource **cs) > +{ > + struct arm_smccc_res hvc_res; > + ktime_t ktime; > + u32 ptp_counter; > + > + if (arch_timer_uses_ppi == ARCH_TIMER_VIRT_PPI) > + ptp_counter = ARM_PTP_VIRT_COUNTER; > + else > + ptp_counter = ARM_PTP_PHY_COUNTER; > + > + arm_smccc_1_1_invoke(ARM_SMCCC_VENDOR_HYP_KVM_PTP_FUNC_ID, > + ptp_counter, &hvc_res); > + > + if ((int)(hvc_res.a0) < 0) > + return -EOPNOTSUPP; > + > + ktime = (u64)hvc_res.a0 << 32 | hvc_res.a1; > + *ts = ktime_to_timespec64(ktime); > + *cycle = (u64)hvc_res.a2 << 32 | hvc_res.a3; Endianness. > + *cs = &clocksource_counter; > + > + return 0; > +} > +EXPORT_SYMBOL_GPL(kvm_arch_ptp_get_crosststamp); > diff --git a/drivers/ptp/Kconfig b/drivers/ptp/Kconfig > index 942f72d8151d..677c7f696b70 100644 > --- a/drivers/ptp/Kconfig > +++ b/drivers/ptp/Kconfig > @@ -106,7 +106,7 @@ config PTP_1588_CLOCK_PCH > config PTP_1588_CLOCK_KVM > tristate "KVM virtual PTP clock" > depends on PTP_1588_CLOCK > - depends on KVM_GUEST && X86 > + depends on KVM_GUEST && X86 || (HAVE_ARM_SMCCC_DISCOVERY && > ARM_ARCH_TIMER) > default y > help > This driver adds support for using kvm infrastructure as a PTP > diff --git a/drivers/ptp/Makefile b/drivers/ptp/Makefile > index 699a4e4d19c2..9fa5ede44b2b 100644 > --- a/drivers/ptp/Makefile > +++ b/drivers/ptp/Makefile > @@ -5,6 +5,7 @@ > > ptp-y := ptp_clock.o ptp_chardev.o ptp_sysfs.o > ptp_kvm-$(CONFIG_X86) := ptp_kvm_x86.o ptp_kvm_common.o > +ptp_kvm-$(CONFIG_HAVE_ARM_SMCCC) := ptp_kvm_arm.o ptp_kvm_common.o > obj-$(CONFIG_PTP_1588_CLOCK) += ptp.o > obj-$(CONFIG_PTP_1588_CLOCK_DTE) += ptp_dte.o > obj-$(CONFIG_PTP_1588_CLOCK_INES) += ptp_ines.o > diff --git a/drivers/ptp/ptp_kvm_arm.c b/drivers/ptp/ptp_kvm_arm.c > new file mode 100644 > index 000000000000..2212827c0384 > --- /dev/null > +++ b/drivers/ptp/ptp_kvm_arm.c > @@ -0,0 +1,44 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/* > + * Virtual PTP 1588 clock for use with KVM guests > + * Copyright (C) 2019 ARM Ltd. > + * All Rights Reserved > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +int kvm_arch_ptp_init(void) > +{ > + int ret; > + > + ret = kvm_arm_hyp_service_available(ARM_SMCCC_KVM_FUNC_KVM_PTP); > + if (ret <= 0) > + return -EOPNOTSUPP; > + > + return 0; > +} > + > +int kvm_arch_ptp_get_clock(struct timespec64 *ts) > +{ > + ktime_t ktime; > + struct arm_smccc_res hvc_res; > + > + arm_smccc_1_1_invoke(ARM_SMCCC_VENDOR_HYP_KVM_PTP_FUNC_ID, > + ARM_PTP_NONE_COUNTER, &hvc_res); I really don't see the need to use a non-architectural counter ID. Using the virtual counter ID should just be fine, and shouldn't lead to any issue. Am I missing something? > + if ((int)(hvc_res.a0) < 0) > + return -EOPNOTSUPP; > + > + ktime = (u64)hvc_res.a0 << 32 | hvc_res.a1; Endianness. > + *ts = ktime_to_timespec64(ktime); > + > + return 0; > +} Thanks, M. -- Jazz is not dead. It just smells funny... _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel