From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kever Yang Subject: Re: [PATCH v6 03/13] Kconfig: Add default SPL_FIT_GENERATOR for rockchip Date: Tue, 7 May 2019 12:05:44 +0800 Message-ID: <7bd53b02-2a0f-d242-31bc-2baba0a69405@rock-chips.com> References: <20190427114852.7608-1-jagan@amarulasolutions.com> <20190427114852.7608-4-jagan@amarulasolutions.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20190427114852.7608-4-jagan@amarulasolutions.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" To: Jagan Teki , Simon Glass , Philipp Tomsich , Akash Gajjar , Tom Rini , Manivannan Sadhasivam Cc: linux-rockchip@lists.infradead.org, linux-amarula@amarulasolutions.com, u-boot@lists.denx.de List-Id: linux-rockchip.vger.kernel.org SGkgSmFnYW4sCgoKT24gMDQvMjcvMjAxOSAwNzo0OCBQTSwgSmFnYW4gVGVraSB3cm90ZToKPiBB ZGQgZGVmYXVsdCBTUExfRklUX0dFTkVSQVRPUiBweSBzY3JpcHQgZm9yIHJvY2tjaGlwIHBsYXRm b3JtcyBpZgo+IHNwZWNpZmljIHRhcmdldCBlbmFibGVkIFNQTF9MT0FEX0ZJVC4KPgo+IFNvLCB0 aGlzIHdvdWxkIGhlbHAgZ2V0IHJpZCBvZiBleHBsaWNpdGx5IG1lbnRpb25pbmcgdGhlIGRlZmF1 bHQKPiBTUEwgRklUIGdlbmVyYXRvciBpbiBkZWZjb25maWdzLiBob3dldmVyIHNvbWUgdGFyZ2V0 cywgbGlrZSBwdW1hX3JrMzM5OQo+IHN0aWxsIHJlcXVpcmUgdGhlaXIgb3duIEZJVCBnZW5lcmF0 b3Igc28gaW4gdGhvc2UgY2FzZXMgdGhlIGRlZmF1bHQgd2lsbAo+IG92ZXJyaWRlIHdpdGggZGVm Y29uZmlnIGRlZmluZWQgZ2VuZXJhdG9yLgo+Cj4gU2lnbmVkLW9mZi1ieTogSmFnYW4gVGVraSA8 amFnYW5AYW1hcnVsYXNvbHV0aW9ucy5jb20+Cj4gUmV2aWV3ZWQtYnk6IFBhdWwgS29jaWFsa293 c2tpIDxwYXVsLmtvY2lhbGtvd3NraUBib290bGluLmNvbT4KPiAtLS0KPiAgS2NvbmZpZyAgICAg ICAgICAgICAgICAgICAgICAgICAgfCAxICsKPiAgY29uZmlncy9jaHJvbWVib29rX2JvYl9kZWZj b25maWcgfCAxIC0KPiAgY29uZmlncy9ldmItcmszMzk5X2RlZmNvbmZpZyAgICAgfCAxIC0KPiAg Y29uZmlncy9maWN1cy1yazMzOTlfZGVmY29uZmlnICAgfCAxIC0KPiAgY29uZmlncy9maXJlZmx5 LXJrMzM5OV9kZWZjb25maWcgfCAxIC0KPiAgY29uZmlncy9yb2NrOTYwLXJrMzM5OV9kZWZjb25m aWcgfCAxIC0KPiAgNiBmaWxlcyBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgNSBkZWxldGlvbnMo LSkKPgo+IGRpZmYgLS1naXQgYS9LY29uZmlnIGIvS2NvbmZpZwo+IGluZGV4IDMwNWIyNjVlZDcu LjU2NzlhMjg4ZWMgMTAwNjQ0Cj4gLS0tIGEvS2NvbmZpZwo+ICsrKyBiL0tjb25maWcKPiBAQCAt NDI0LDYgKzQyNCw3IEBAIGNvbmZpZyBTUExfRklUX0dFTkVSQVRPUgo+ICAJc3RyaW5nICIuaXRz IGZpbGUgZ2VuZXJhdG9yIHNjcmlwdCBmb3IgVS1Cb290IEZJVCBpbWFnZSIKPiAgCWRlcGVuZHMg b24gU1BMX0ZJVAo+ICAJZGVmYXVsdCAiYm9hcmQvc3VueGkvbWtzdW54aV9maXRfYXRmLnNoIiBp ZiBTUExfTE9BRF9GSVQgJiYgQVJDSF9TVU5YSQo+ICsJZGVmYXVsdCAiYXJjaC9hcm0vbWFjaC1y b2NrY2hpcC9tYWtlX2ZpdF9hdGYucHkiIGlmIFNQTF9MT0FEX0ZJVCAmJiBBUkNIX1JPQ0tDSElQ CgpXaGF0IGhhcHBlbnMgdG8gcHVtYS1yazMzOTkgYm9hcmQgd2l0aCB0aGlzIHBhdGNoPyBGb3Ig aXQgdXNlIGRlZGljYXRlCml0cyBmaWxlIG5vdy4KY29uZmlncy9wdW1hLXJrMzM5OV9kZWZjb25m aWcKQ09ORklHX1NQTF9GSVRfU09VUkNFPSJib2FyZC90aGVvYnJvbWEtc3lzdGVtcy9wdW1hX3Jr MzM5OS9maXRfc3BsX2F0Zi5pdHMiCgpUaGFua3MsCi0gS2V2ZXIKPiAgCWhlbHAKPiAgCSAgU3Bl Y2lmaWVzIGEgKHBsYXRmb3JtIHNwZWNpZmljKSBzY3JpcHQgZmlsZSB0byBnZW5lcmF0ZSB0aGUg RklUCj4gIAkgIHNvdXJjZSBmaWxlIHVzZWQgdG8gYnVpbGQgdGhlIFUtQm9vdCBGSVQgaW1hZ2Ug ZmlsZS4gVGhpcyBnZXRzCj4gZGlmZiAtLWdpdCBhL2NvbmZpZ3MvY2hyb21lYm9va19ib2JfZGVm Y29uZmlnIGIvY29uZmlncy9jaHJvbWVib29rX2JvYl9kZWZjb25maWcKPiBpbmRleCBjZTNkZWNj YjhhLi4wNGUyNWUxZDRmIDEwMDY0NAo+IC0tLSBhL2NvbmZpZ3MvY2hyb21lYm9va19ib2JfZGVm Y29uZmlnCj4gKysrIGIvY29uZmlncy9jaHJvbWVib29rX2JvYl9kZWZjb25maWcKPiBAQCAtMTks NyArMTksNiBAQCBDT05GSUdfREVCVUdfVUFSVD15Cj4gIENPTkZJR19OUl9EUkFNX0JBTktTPTEK PiAgQ09ORklHX0ZJVD15Cj4gIENPTkZJR19TUExfTE9BRF9GSVQ9eQo+IC1DT05GSUdfU1BMX0ZJ VF9HRU5FUkFUT1I9ImFyY2gvYXJtL21hY2gtcm9ja2NoaXAvbWFrZV9maXRfYXRmLnB5Igo+ICBD T05GSUdfREVGQVVMVF9GRFRfRklMRT0icm9ja2NoaXAvcmszMzk5LWdydS1ib2IuZHRiIgo+ICAj IENPTkZJR19ESVNQTEFZX0NQVUlORk8gaXMgbm90IHNldAo+ICBDT05GSUdfRElTUExBWV9CT0FS RElORk9fTEFURT15Cj4gZGlmZiAtLWdpdCBhL2NvbmZpZ3MvZXZiLXJrMzM5OV9kZWZjb25maWcg Yi9jb25maWdzL2V2Yi1yazMzOTlfZGVmY29uZmlnCj4gaW5kZXggZDk4NTM1MzU3YS4uNDliMmUy ZTA4OSAxMDA2NDQKPiAtLS0gYS9jb25maWdzL2V2Yi1yazMzOTlfZGVmY29uZmlnCj4gKysrIGIv Y29uZmlncy9ldmItcmszMzk5X2RlZmNvbmZpZwo+IEBAIC0xMyw3ICsxMyw2IEBAIENPTkZJR19E RUJVR19VQVJUPXkKPiAgQ09ORklHX05SX0RSQU1fQkFOS1M9MQo+ICBDT05GSUdfRklUPXkKPiAg Q09ORklHX1NQTF9MT0FEX0ZJVD15Cj4gLUNPTkZJR19TUExfRklUX0dFTkVSQVRPUj0iYXJjaC9h cm0vbWFjaC1yb2NrY2hpcC9tYWtlX2ZpdF9hdGYucHkiCj4gIENPTkZJR19ERUZBVUxUX0ZEVF9G SUxFPSJyb2NrY2hpcC9yazMzOTktZXZiLmR0YiIKPiAgIyBDT05GSUdfRElTUExBWV9DUFVJTkZP IGlzIG5vdCBzZXQKPiAgQ09ORklHX0RJU1BMQVlfQk9BUkRJTkZPX0xBVEU9eQo+IGRpZmYgLS1n aXQgYS9jb25maWdzL2ZpY3VzLXJrMzM5OV9kZWZjb25maWcgYi9jb25maWdzL2ZpY3VzLXJrMzM5 OV9kZWZjb25maWcKPiBpbmRleCA5NGM1NjVlZmMyLi5mZTNiOTk2NGU4IDEwMDY0NAo+IC0tLSBh L2NvbmZpZ3MvZmljdXMtcmszMzk5X2RlZmNvbmZpZwo+ICsrKyBiL2NvbmZpZ3MvZmljdXMtcmsz Mzk5X2RlZmNvbmZpZwo+IEBAIC0xMyw3ICsxMyw2IEBAIENPTkZJR19TUExfU1RBQ0tfUl9BRERS PTB4ODAwMDAKPiAgQ09ORklHX0RFQlVHX1VBUlQ9eQo+ICBDT05GSUdfRklUPXkKPiAgQ09ORklH X1NQTF9MT0FEX0ZJVD15Cj4gLUNPTkZJR19TUExfRklUX0dFTkVSQVRPUj0iYXJjaC9hcm0vbWFj aC1yb2NrY2hpcC9tYWtlX2ZpdF9hdGYucHkiCj4gICMgQ09ORklHX0RJU1BMQVlfQ1BVSU5GTyBp cyBub3Qgc2V0Cj4gIENPTkZJR19ESVNQTEFZX0JPQVJESU5GT19MQVRFPXkKPiAgQ09ORklHX1NQ TF9TVEFDS19SPXkKPiBkaWZmIC0tZ2l0IGEvY29uZmlncy9maXJlZmx5LXJrMzM5OV9kZWZjb25m aWcgYi9jb25maWdzL2ZpcmVmbHktcmszMzk5X2RlZmNvbmZpZwo+IGluZGV4IDY3MjViNDg5NzAu LjkxNDMwNGJiNDMgMTAwNjQ0Cj4gLS0tIGEvY29uZmlncy9maXJlZmx5LXJrMzM5OV9kZWZjb25m aWcKPiArKysgYi9jb25maWdzL2ZpcmVmbHktcmszMzk5X2RlZmNvbmZpZwo+IEBAIC0xMyw3ICsx Myw2IEBAIENPTkZJR19ERUJVR19VQVJUPXkKPiAgQ09ORklHX05SX0RSQU1fQkFOS1M9MQo+ICBD T05GSUdfRklUPXkKPiAgQ09ORklHX1NQTF9MT0FEX0ZJVD15Cj4gLUNPTkZJR19TUExfRklUX0dF TkVSQVRPUj0iYXJjaC9hcm0vbWFjaC1yb2NrY2hpcC9tYWtlX2ZpdF9hdGYucHkiCj4gIENPTkZJ R19ERUZBVUxUX0ZEVF9GSUxFPSJyb2NrY2hpcC9yazMzOTktZmlyZWZseS5kdGIiCj4gICMgQ09O RklHX0RJU1BMQVlfQ1BVSU5GTyBpcyBub3Qgc2V0Cj4gIENPTkZJR19ESVNQTEFZX0JPQVJESU5G T19MQVRFPXkKPiBkaWZmIC0tZ2l0IGEvY29uZmlncy9yb2NrOTYwLXJrMzM5OV9kZWZjb25maWcg Yi9jb25maWdzL3JvY2s5NjAtcmszMzk5X2RlZmNvbmZpZwo+IGluZGV4IGNiNWEzNWY0ZjUuLjVl Njc3OGVhMjAgMTAwNjQ0Cj4gLS0tIGEvY29uZmlncy9yb2NrOTYwLXJrMzM5OV9kZWZjb25maWcK PiArKysgYi9jb25maWdzL3JvY2s5NjAtcmszMzk5X2RlZmNvbmZpZwo+IEBAIC0xMyw3ICsxMyw2 IEBAIENPTkZJR19TUExfU1RBQ0tfUl9BRERSPTB4ODAwMDAKPiAgQ09ORklHX0RFQlVHX1VBUlQ9 eQo+ICBDT05GSUdfRklUPXkKPiAgQ09ORklHX1NQTF9MT0FEX0ZJVD15Cj4gLUNPTkZJR19TUExf RklUX0dFTkVSQVRPUj0iYXJjaC9hcm0vbWFjaC1yb2NrY2hpcC9tYWtlX2ZpdF9hdGYucHkiCj4g IENPTkZJR19ERUZBVUxUX0ZEVF9GSUxFPSJyb2NrY2hpcC9yazMzOTktcm9jazk2MC5kdGIiCj4g ICMgQ09ORklHX0RJU1BMQVlfQ1BVSU5GTyBpcyBub3Qgc2V0Cj4gIENPTkZJR19ESVNQTEFZX0JP QVJESU5GT19MQVRFPXkKCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KVS1Cb290IG1haWxpbmcgbGlzdApVLUJvb3RAbGlzdHMuZGVueC5kZQpodHRwczov L2xpc3RzLmRlbnguZGUvbGlzdGluZm8vdS1ib290Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kever Yang Date: Tue, 7 May 2019 12:05:44 +0800 Subject: [U-Boot] [PATCH v6 03/13] Kconfig: Add default SPL_FIT_GENERATOR for rockchip In-Reply-To: <20190427114852.7608-4-jagan@amarulasolutions.com> References: <20190427114852.7608-1-jagan@amarulasolutions.com> <20190427114852.7608-4-jagan@amarulasolutions.com> Message-ID: <7bd53b02-2a0f-d242-31bc-2baba0a69405@rock-chips.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Jagan, On 04/27/2019 07:48 PM, Jagan Teki wrote: > Add default SPL_FIT_GENERATOR py script for rockchip platforms if > specific target enabled SPL_LOAD_FIT. > > So, this would help get rid of explicitly mentioning the default > SPL FIT generator in defconfigs. however some targets, like puma_rk3399 > still require their own FIT generator so in those cases the default will > override with defconfig defined generator. > > Signed-off-by: Jagan Teki > Reviewed-by: Paul Kocialkowski > --- > Kconfig | 1 + > configs/chromebook_bob_defconfig | 1 - > configs/evb-rk3399_defconfig | 1 - > configs/ficus-rk3399_defconfig | 1 - > configs/firefly-rk3399_defconfig | 1 - > configs/rock960-rk3399_defconfig | 1 - > 6 files changed, 1 insertion(+), 5 deletions(-) > > diff --git a/Kconfig b/Kconfig > index 305b265ed7..5679a288ec 100644 > --- a/Kconfig > +++ b/Kconfig > @@ -424,6 +424,7 @@ config SPL_FIT_GENERATOR > string ".its file generator script for U-Boot FIT image" > depends on SPL_FIT > default "board/sunxi/mksunxi_fit_atf.sh" if SPL_LOAD_FIT && ARCH_SUNXI > + default "arch/arm/mach-rockchip/make_fit_atf.py" if SPL_LOAD_FIT && ARCH_ROCKCHIP What happens to puma-rk3399 board with this patch? For it use dedicate its file now. configs/puma-rk3399_defconfig CONFIG_SPL_FIT_SOURCE="board/theobroma-systems/puma_rk3399/fit_spl_atf.its" Thanks, - Kever > help > Specifies a (platform specific) script file to generate the FIT > source file used to build the U-Boot FIT image file. This gets > diff --git a/configs/chromebook_bob_defconfig b/configs/chromebook_bob_defconfig > index ce3deccb8a..04e25e1d4f 100644 > --- a/configs/chromebook_bob_defconfig > +++ b/configs/chromebook_bob_defconfig > @@ -19,7 +19,6 @@ CONFIG_DEBUG_UART=y > CONFIG_NR_DRAM_BANKS=1 > CONFIG_FIT=y > CONFIG_SPL_LOAD_FIT=y > -CONFIG_SPL_FIT_GENERATOR="arch/arm/mach-rockchip/make_fit_atf.py" > CONFIG_DEFAULT_FDT_FILE="rockchip/rk3399-gru-bob.dtb" > # CONFIG_DISPLAY_CPUINFO is not set > CONFIG_DISPLAY_BOARDINFO_LATE=y > diff --git a/configs/evb-rk3399_defconfig b/configs/evb-rk3399_defconfig > index d98535357a..49b2e2e089 100644 > --- a/configs/evb-rk3399_defconfig > +++ b/configs/evb-rk3399_defconfig > @@ -13,7 +13,6 @@ CONFIG_DEBUG_UART=y > CONFIG_NR_DRAM_BANKS=1 > CONFIG_FIT=y > CONFIG_SPL_LOAD_FIT=y > -CONFIG_SPL_FIT_GENERATOR="arch/arm/mach-rockchip/make_fit_atf.py" > CONFIG_DEFAULT_FDT_FILE="rockchip/rk3399-evb.dtb" > # CONFIG_DISPLAY_CPUINFO is not set > CONFIG_DISPLAY_BOARDINFO_LATE=y > diff --git a/configs/ficus-rk3399_defconfig b/configs/ficus-rk3399_defconfig > index 94c565efc2..fe3b9964e8 100644 > --- a/configs/ficus-rk3399_defconfig > +++ b/configs/ficus-rk3399_defconfig > @@ -13,7 +13,6 @@ CONFIG_SPL_STACK_R_ADDR=0x80000 > CONFIG_DEBUG_UART=y > CONFIG_FIT=y > CONFIG_SPL_LOAD_FIT=y > -CONFIG_SPL_FIT_GENERATOR="arch/arm/mach-rockchip/make_fit_atf.py" > # CONFIG_DISPLAY_CPUINFO is not set > CONFIG_DISPLAY_BOARDINFO_LATE=y > CONFIG_SPL_STACK_R=y > diff --git a/configs/firefly-rk3399_defconfig b/configs/firefly-rk3399_defconfig > index 6725b48970..914304bb43 100644 > --- a/configs/firefly-rk3399_defconfig > +++ b/configs/firefly-rk3399_defconfig > @@ -13,7 +13,6 @@ CONFIG_DEBUG_UART=y > CONFIG_NR_DRAM_BANKS=1 > CONFIG_FIT=y > CONFIG_SPL_LOAD_FIT=y > -CONFIG_SPL_FIT_GENERATOR="arch/arm/mach-rockchip/make_fit_atf.py" > CONFIG_DEFAULT_FDT_FILE="rockchip/rk3399-firefly.dtb" > # CONFIG_DISPLAY_CPUINFO is not set > CONFIG_DISPLAY_BOARDINFO_LATE=y > diff --git a/configs/rock960-rk3399_defconfig b/configs/rock960-rk3399_defconfig > index cb5a35f4f5..5e6778ea20 100644 > --- a/configs/rock960-rk3399_defconfig > +++ b/configs/rock960-rk3399_defconfig > @@ -13,7 +13,6 @@ CONFIG_SPL_STACK_R_ADDR=0x80000 > CONFIG_DEBUG_UART=y > CONFIG_FIT=y > CONFIG_SPL_LOAD_FIT=y > -CONFIG_SPL_FIT_GENERATOR="arch/arm/mach-rockchip/make_fit_atf.py" > CONFIG_DEFAULT_FDT_FILE="rockchip/rk3399-rock960.dtb" > # CONFIG_DISPLAY_CPUINFO is not set > CONFIG_DISPLAY_BOARDINFO_LATE=y