From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from bh-25.webhostbox.net ([208.91.199.152]:51335 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751091AbcIIErk (ORCPT ); Fri, 9 Sep 2016 00:47:40 -0400 Subject: Re: [PATCH v5 00/10] watchdog: add watchdog pretimeout framework To: Vladimir Zapolskiy , Wolfram Sang References: <1472644370-16982-1-git-send-email-vladimir_zapolskiy@mentor.com> <20160905164923.GA1548@katana> <29631170-1687-fbd0-8072-6a65b8868009@mentor.com> Cc: Wim Van Sebroeck , linux-watchdog@vger.kernel.org From: Guenter Roeck Message-ID: <7bec61ce-8bab-d4be-cca4-ec3c0025e2fb@roeck-us.net> Date: Thu, 8 Sep 2016 21:47:37 -0700 MIME-Version: 1.0 In-Reply-To: <29631170-1687-fbd0-8072-6a65b8868009@mentor.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-watchdog-owner@vger.kernel.org List-Id: linux-watchdog@vger.kernel.org On 09/06/2016 03:33 AM, Vladimir Zapolskiy wrote: > Hi Wolfram, > > On 09/05/2016 07:49 PM, Wolfram Sang wrote: >> On Wed, Aug 31, 2016 at 02:52:40PM +0300, Vladimir Zapolskiy wrote: >>> The change adds a simple watchdog pretimeout framework infrastructure, >>> its purpose is to allow users to select a desired handling of watchdog >>> pretimeout events, which may be generated by a watchdog driver. >>> >>> The idea of adding this kind of a framework appeared after reviewing >>> several attempts to add hardcoded pretimeout event handling to some >>> watchdog driver and after a discussion with Guenter, see >>> https://lkml.org/lkml/2015/11/4/346 >>> >>> Watchdogs with WDIOF_PRETIMEOUT capability now may have three device >>> attributes in sysfs: read only pretimeout value attribute, read/write >>> pretimeout_governor attribute, read only pretimeout_available_governors >>> attribute. >>> >>> To throw a pretimeout event for further processing a watchdog driver >>> should call exported watchdog_notify_pretimeout(wdd) interface. >>> >>> In addition to the framework two simple watchdog pretimeout governors >>> are added for review: panic and noop. >>> >>> Changes from v4 to v5: >>> * fixed in source tree compilation issue, thanks to Wolfram >>> * replaced strncmp() with more suitable sysfs_streq() to >>> compare strings passed over sysfs (Wolfram) >>> * added Wolfram's implementation of pretimeout to softdog driver >>> * added watchdog pretimeout support to iMX2+ driver >>> * minor whitespace issue fixes reported by checkpatch >> >> Reviewed-by: Wolfram Sang >> Tested-by: Wolfram Sang >> > > thank you for testing and poking me to complete the work. > >> So, I checked it on my Renesas M3 Salvator board and it worked as >> expected. I also looked over the code and it looks good to me. Note that >> I looked quite often over the code, so a "fresh" view might not hurt. >> Despite that, I think the code is generally good to go. >> > > I suppose watchdog maintainers would like to provide more review comments, > so probably this is not the last version of the change, anyway do you > consider to send SH-Mobile watchdog driver changes for v4.9? > I am sure there is something I missed, but all I could find was nitpicks not worth a resend, so at least for my part I think we should get this in. Reviewed-by: Guenter Roeck