From: Lino Sanfilippo <LinoSanfilippo@gmx.de>
To: Jiri Slaby <jirislaby@kernel.org>, gregkh@linuxfoundation.org
Cc: linux@armlinux.org.uk, linux-serial@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] serial: amba-pl011: add RS485 support
Date: Thu, 17 Jun 2021 19:44:21 +0200 [thread overview]
Message-ID: <7c0ac56d-58da-5e8a-b6be-44bafb183443@gmx.de> (raw)
In-Reply-To: <5f00ff43-9287-4027-7d80-474da957703c@kernel.org>
Hi,
On 16.06.21 at 08:18, Jiri Slaby wrote:
mdelay(port->rs485.delay_rts_before_send);
>
> This is up to 1 second delay with interrupts disabled. Definitely not nice. 8250 clamps this to 100 ms at least, why did you choose 1000 ms?
>
AFAICS the 8250 driver does not clamp values read from the device tree property "rs485-rts-delay"
(set by uart_get_rs485_mode()). Is this on purpose?
Regards,
Lino
prev parent reply other threads:[~2021-06-17 17:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-10 13:50 [PATCH] serial: amba-pl011: add RS485 support Lino Sanfilippo
2021-06-16 6:18 ` Jiri Slaby
2021-06-16 6:29 ` Greg KH
2021-06-17 16:12 ` Lino Sanfilippo
2021-06-17 17:44 ` Lino Sanfilippo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7c0ac56d-58da-5e8a-b6be-44bafb183443@gmx.de \
--to=linosanfilippo@gmx.de \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.