From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5364BC38A2A for ; Fri, 8 May 2020 08:20:10 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2769D20735 for ; Fri, 8 May 2020 08:20:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2769D20735 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jWyEX-0005rF-Vl; Fri, 08 May 2020 08:19:49 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jWyEW-0005r9-P0 for xen-devel@lists.xenproject.org; Fri, 08 May 2020 08:19:48 +0000 X-Inumbo-ID: ae3a16ac-9104-11ea-ae69-bc764e2007e4 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id ae3a16ac-9104-11ea-ae69-bc764e2007e4; Fri, 08 May 2020 08:19:48 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id DCFD2B004; Fri, 8 May 2020 08:19:49 +0000 (UTC) Subject: Re: [PATCH 3/3] xen/cpupool: fix removing cpu from a cpupool To: Juergen Gross References: <20200430151559.1464-1-jgross@suse.com> <20200430151559.1464-4-jgross@suse.com> From: Jan Beulich Message-ID: <7c0c5c02-7bf8-8aa1-4c5d-586d18290d2f@suse.com> Date: Fri, 8 May 2020 10:19:46 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: xen-devel@lists.xenproject.org, George Dunlap , Dario Faggioli Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 07.05.2020 20:36, Dario Faggioli wrote: > On Thu, 2020-04-30 at 17:15 +0200, Juergen Gross wrote: >> Commit cb563d7665f2 ("xen/sched: support core scheduling for moving >> cpus to/from cpupools") introduced a regression when trying to remove >> an offline cpu from a cpupool, as the system would crash in this >> situation. >> >> Fix that by testing the cpu to be online. >> >> Fixes: cb563d7665f2 ("xen/sched: support core scheduling for moving >> cpus to/from cpupools") >> Signed-off-by: Juergen Gross >> > Acked-by: Dario Faggioli Jürgen, it looks like this is independent of the earlier two patches and hence could go in, while I understand there'll be v2 for the earlier ones. Please confirm. Jan