From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C0D7C61D97 for ; Sun, 29 Jan 2023 06:55:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230390AbjA2GzK (ORCPT ); Sun, 29 Jan 2023 01:55:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43942 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229436AbjA2GzJ (ORCPT ); Sun, 29 Jan 2023 01:55:09 -0500 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A346A1F4B2; Sat, 28 Jan 2023 22:55:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1674975308; x=1706511308; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=pLizHV3VOzyjL1m4zB1zP1MXn3GWDVvQuhcDoXLvhNk=; b=SVUAKmSL2rDzA2xPZTxPI45khwI5Nu7u6CmvmfgC/8JYDbew8oK3n3xU vmjrK73KKq1Wh6MxeAMmOu1nkE4X/2w9gNNg0SpYUZ25A2NQebhydv0tO VLBKXK5htQYZazxbNUBShhqP1AWBoKNK8tlUSt+/M/kqv3BKmsHmPvKBu W+sn5d1NrPj4rMlroa/RCswQ1Zstfh/484Cg983HWY6exD+g0rEahsoid PTe8YaYAgL+2Y4HVbOH2C8+K/BTOHx+R+u3wlCR4WwT9uMTXId+qGorRc pSiS9B0HnC4WiP3EiRhL/uF4k5e/dA5I2zVg6Xkm5kYpMXihsH92X9Dxp g==; X-IronPort-AV: E=McAfee;i="6500,9779,10604"; a="327385518" X-IronPort-AV: E=Sophos;i="5.97,254,1669104000"; d="scan'208";a="327385518" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jan 2023 22:55:07 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10604"; a="806297526" X-IronPort-AV: E=Sophos;i="5.97,254,1669104000"; d="scan'208";a="806297526" Received: from zhoufuro-mobl.ccr.corp.intel.com (HELO [10.254.211.56]) ([10.254.211.56]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jan 2023 22:55:02 -0800 Message-ID: <7c1d80b6-5db3-9955-0a67-908455bd77fa@linux.intel.com> Date: Sun, 29 Jan 2023 14:54:43 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [RFC PATCH v2 07/22] ASoC: Add SOC USB APIs for adding an USB backend To: Greg KH , Wesley Cheng Cc: srinivas.kandagatla@linaro.org, mathias.nyman@intel.com, perex@perex.cz, lgirdwood@gmail.com, andersson@kernel.org, krzysztof.kozlowski+dt@linaro.org, Thinh.Nguyen@synopsys.com, broonie@kernel.org, bgoswami@quicinc.com, tiwai@suse.com, robh+dt@kernel.org, agross@kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-usb@vger.kernel.org, quic_jackp@quicinc.com, quic_plai@quicinc.com References: <20230126031424.14582-1-quic_wcheng@quicinc.com> <20230126031424.14582-8-quic_wcheng@quicinc.com> Content-Language: en-US From: Zhou Furong In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org >> +void *snd_soc_usb_get_priv_data(struct device *usbdev) >> +{ >> + struct snd_soc_usb *ctx; >> + >> + if (!usbdev) >> + return NULL; > > How could usbdev ever be NULL? The method is exported to public, valid check should be reasonable as someone may call it by mistake > >> + >> + ctx = snd_soc_find_usb_ctx(usbdev); >> + >> + return ctx ? ctx->priv_data : NULL; >> +} >> +EXPORT_SYMBOL_GPL(snd_soc_usb_get_priv_data); >> + From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 540A9C05027 for ; Sun, 29 Jan 2023 08:26:01 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id C4E57E95; Sun, 29 Jan 2023 09:25:08 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz C4E57E95 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1674980758; bh=pLizHV3VOzyjL1m4zB1zP1MXn3GWDVvQuhcDoXLvhNk=; h=Date:Subject:To:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=Xgtgj4dNmhmR99MUVNnFFgBwPHqZyO2hjAHlGPGZPGsiUPUFRBN23YegAHQV0OSzD QrxdiYm4qAlcIRzARjQguUSp7J9WZ7e44QYCTDuD5bHCg6grU01CGsOqTI+65jnBcc zcilLTAB3Zq1PDoBSvRSZ2I9r4c9uK7B48rej71A= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 9FA8DF80570; Sun, 29 Jan 2023 09:23:18 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 2BA1EF804B2; Sun, 29 Jan 2023 07:55:33 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 34C68F80171 for ; Sun, 29 Jan 2023 07:55:11 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 34C68F80171 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=WSChR8rq DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1674975313; x=1706511313; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=pLizHV3VOzyjL1m4zB1zP1MXn3GWDVvQuhcDoXLvhNk=; b=WSChR8rqKhaUX5cSGU2HUelaPls01LAKy2XKDWSFNWNjWuKxaKwZsPJr qLaAna3iER/JyyELztkEO1e6ExrnxNwauC3aXM0PCrWUs6Tis82klV8YU IeCTdaUSK/BwfzcCNcbXjgqP7pT4P85Qkh45aU0c7BphophdrcLGTHGyx gFjOIa7ETGR+KnVYjXlpJ0MTDROu0y1ki+ejDA8tn9FEZ4aopRS5dwOvZ QKZlVvav41vqAY1gpJjXQX3CLZKD89xwxYQSIAXPe7Ra8DEvA2bKRqrH2 I5AGqt2d1GvAqQx5LzUas6Z8qazpqKcitI+uLmcrKzGBRplF1+y/j/toe w==; X-IronPort-AV: E=McAfee;i="6500,9779,10604"; a="327385521" X-IronPort-AV: E=Sophos;i="5.97,254,1669104000"; d="scan'208";a="327385521" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jan 2023 22:55:07 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10604"; a="806297526" X-IronPort-AV: E=Sophos;i="5.97,254,1669104000"; d="scan'208";a="806297526" Received: from zhoufuro-mobl.ccr.corp.intel.com (HELO [10.254.211.56]) ([10.254.211.56]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jan 2023 22:55:02 -0800 Message-ID: <7c1d80b6-5db3-9955-0a67-908455bd77fa@linux.intel.com> Date: Sun, 29 Jan 2023 14:54:43 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [RFC PATCH v2 07/22] ASoC: Add SOC USB APIs for adding an USB backend To: Greg KH , Wesley Cheng References: <20230126031424.14582-1-quic_wcheng@quicinc.com> <20230126031424.14582-8-quic_wcheng@quicinc.com> Content-Language: en-US From: Zhou Furong In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Mailman-Approved-At: Sun, 29 Jan 2023 09:23:11 +0100 X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, linux-usb@vger.kernel.org, bgoswami@quicinc.com, mathias.nyman@intel.com, Thinh.Nguyen@synopsys.com, andersson@kernel.org, tiwai@suse.com, lgirdwood@gmail.com, robh+dt@kernel.org, broonie@kernel.org, srinivas.kandagatla@linaro.org, agross@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-arm-msm@vger.kernel.org, quic_plai@quicinc.com, linux-kernel@vger.kernel.org, quic_jackp@quicinc.com Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" >> +void *snd_soc_usb_get_priv_data(struct device *usbdev) >> +{ >> + struct snd_soc_usb *ctx; >> + >> + if (!usbdev) >> + return NULL; > > How could usbdev ever be NULL? The method is exported to public, valid check should be reasonable as someone may call it by mistake > >> + >> + ctx = snd_soc_find_usb_ctx(usbdev); >> + >> + return ctx ? ctx->priv_data : NULL; >> +} >> +EXPORT_SYMBOL_GPL(snd_soc_usb_get_priv_data); >> +