All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] package/boost: disable logs with riscv32
@ 2021-05-21 20:03 Fabrice Fontaine
  2021-05-25 19:26 ` Arnout Vandecappelle
  2021-06-09 20:55 ` Peter Korsgaard
  0 siblings, 2 replies; 5+ messages in thread
From: Fabrice Fontaine @ 2021-05-21 20:03 UTC (permalink / raw)
  To: buildroot

boost logs can't be built with riscv32 because it unconditionally uses
__NR_futex:

libs/log/src/event.cpp: In member function 'void boost::log::v2_mt_posix::aux::futex_based_event::wait()':
libs/log/src/event.cpp:38:29: error: '__NR_futex' was not declared in this scope
   38 | #define BOOST_LOG_SYS_FUTEX __NR_futex
      |                             ^~~~~~~~~~

Fixes:
 - http://autobuild.buildroot.org/results/8c8135fd7c0517c66c9b3975c494da6d7934cc1b

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/azmq/Config.in  | 3 +++
 package/boost/Config.in | 3 +++
 2 files changed, 6 insertions(+)

diff --git a/package/azmq/Config.in b/package/azmq/Config.in
index 37131a260a..6751d533a4 100644
--- a/package/azmq/Config.in
+++ b/package/azmq/Config.in
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_AZMQ
 	bool "azmq"
+	depends on !BR2_RISCV_32 # boost-log
 	depends on BR2_INSTALL_LIBSTDCPP
 	depends on BR2_TOOLCHAIN_HAS_ATOMIC
 	depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL # boost-log
@@ -22,9 +23,11 @@ config BR2_PACKAGE_AZMQ
 	  https://github.com/zeromq/azmq
 
 comment "azmq needs a toolchain w/ C++11, wchar and NPTL"
+	depends on !BR2_RISCV_32
 	depends on BR2_TOOLCHAIN_SUPPORTS_ALWAYS_LOCKFREE_ATOMIC_INTS
 	depends on !(BR2_INSTALL_LIBSTDCPP && BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 \
 		&& BR2_USE_WCHAR && BR2_TOOLCHAIN_HAS_THREADS_NPTL)
 
 comment "azmq needs exception_ptr"
+	depends on !BR2_RISCV_32
 	depends on BR2_TOOLCHAIN_HAS_GCC_BUG_64735
diff --git a/package/boost/Config.in b/package/boost/Config.in
index 3e96e1ede3..75bb81600a 100644
--- a/package/boost/Config.in
+++ b/package/boost/Config.in
@@ -240,6 +240,7 @@ comment "boost-locale needs a toolchain not affected by GCC bug 64735"
 
 config BR2_PACKAGE_BOOST_LOG
 	bool "boost-log"
+	depends on !BR2_RISCV_32
 	depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL
 	depends on BR2_TOOLCHAIN_SUPPORTS_ALWAYS_LOCKFREE_ATOMIC_INTS # boost-atomic
 	depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_64735 # boost-thread
@@ -253,10 +254,12 @@ config BR2_PACKAGE_BOOST_LOG
 	  Logging library.
 
 comment "boost-log needs a toolchain w/ NPTL"
+	depends on !BR2_RISCV_32
 	depends on BR2_TOOLCHAIN_SUPPORTS_ALWAYS_LOCKFREE_ATOMIC_INTS
 	depends on !BR2_TOOLCHAIN_HAS_THREADS_NPTL
 
 comment "boost-log needs a toolchain not affected by GCC bug 64735"
+	depends on !BR2_RISCV_32
 	depends on BR2_TOOLCHAIN_HAS_GCC_BUG_64735
 
 config BR2_PACKAGE_BOOST_MATH
-- 
2.30.2

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [Buildroot] [PATCH 1/1] package/boost: disable logs with riscv32
  2021-05-21 20:03 [Buildroot] [PATCH 1/1] package/boost: disable logs with riscv32 Fabrice Fontaine
@ 2021-05-25 19:26 ` Arnout Vandecappelle
  2021-05-27  6:10   ` Fabrice Fontaine
  2021-06-09 20:55 ` Peter Korsgaard
  1 sibling, 1 reply; 5+ messages in thread
From: Arnout Vandecappelle @ 2021-05-25 19:26 UTC (permalink / raw)
  To: buildroot



On 21/05/2021 22:03, Fabrice Fontaine wrote:
> boost logs can't be built with riscv32 because it unconditionally uses
> __NR_futex:
> 
> libs/log/src/event.cpp: In member function 'void boost::log::v2_mt_posix::aux::futex_based_event::wait()':
> libs/log/src/event.cpp:38:29: error: '__NR_futex' was not declared in this scope
>    38 | #define BOOST_LOG_SYS_FUTEX __NR_futex
>       |                             ^~~~~~~~~~

 There seems to be a similar issue in boost/atomic/detail/futex.hpp, e.g. [1].
Could you handle that as well?


 Regards,
 Arnout


[1]
http://autobuild.buildroot.net/results/6aa/6aa7ac8b14c3ba4f674d541fabb4476680b299a7/build-end.log


> 
> Fixes:
>  - http://autobuild.buildroot.org/results/8c8135fd7c0517c66c9b3975c494da6d7934cc1b
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/azmq/Config.in  | 3 +++
>  package/boost/Config.in | 3 +++
>  2 files changed, 6 insertions(+)
> 
> diff --git a/package/azmq/Config.in b/package/azmq/Config.in
> index 37131a260a..6751d533a4 100644
> --- a/package/azmq/Config.in
> +++ b/package/azmq/Config.in
> @@ -1,5 +1,6 @@
>  config BR2_PACKAGE_AZMQ
>  	bool "azmq"
> +	depends on !BR2_RISCV_32 # boost-log
>  	depends on BR2_INSTALL_LIBSTDCPP
>  	depends on BR2_TOOLCHAIN_HAS_ATOMIC
>  	depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL # boost-log
> @@ -22,9 +23,11 @@ config BR2_PACKAGE_AZMQ
>  	  https://github.com/zeromq/azmq
>  
>  comment "azmq needs a toolchain w/ C++11, wchar and NPTL"
> +	depends on !BR2_RISCV_32
>  	depends on BR2_TOOLCHAIN_SUPPORTS_ALWAYS_LOCKFREE_ATOMIC_INTS
>  	depends on !(BR2_INSTALL_LIBSTDCPP && BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 \
>  		&& BR2_USE_WCHAR && BR2_TOOLCHAIN_HAS_THREADS_NPTL)
>  
>  comment "azmq needs exception_ptr"
> +	depends on !BR2_RISCV_32
>  	depends on BR2_TOOLCHAIN_HAS_GCC_BUG_64735
> diff --git a/package/boost/Config.in b/package/boost/Config.in
> index 3e96e1ede3..75bb81600a 100644
> --- a/package/boost/Config.in
> +++ b/package/boost/Config.in
> @@ -240,6 +240,7 @@ comment "boost-locale needs a toolchain not affected by GCC bug 64735"
>  
>  config BR2_PACKAGE_BOOST_LOG
>  	bool "boost-log"
> +	depends on !BR2_RISCV_32>  	depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL
>  	depends on BR2_TOOLCHAIN_SUPPORTS_ALWAYS_LOCKFREE_ATOMIC_INTS # boost-atomic
>  	depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_64735 # boost-thread
> @@ -253,10 +254,12 @@ config BR2_PACKAGE_BOOST_LOG
>  	  Logging library.
>  
>  comment "boost-log needs a toolchain w/ NPTL"
> +	depends on !BR2_RISCV_32
>  	depends on BR2_TOOLCHAIN_SUPPORTS_ALWAYS_LOCKFREE_ATOMIC_INTS
>  	depends on !BR2_TOOLCHAIN_HAS_THREADS_NPTL
>  
>  comment "boost-log needs a toolchain not affected by GCC bug 64735"
> +	depends on !BR2_RISCV_32
>  	depends on BR2_TOOLCHAIN_HAS_GCC_BUG_64735
>  
>  config BR2_PACKAGE_BOOST_MATH

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Buildroot] [PATCH 1/1] package/boost: disable logs with riscv32
  2021-05-25 19:26 ` Arnout Vandecappelle
@ 2021-05-27  6:10   ` Fabrice Fontaine
  2021-05-27  7:45     ` Arnout Vandecappelle
  0 siblings, 1 reply; 5+ messages in thread
From: Fabrice Fontaine @ 2021-05-27  6:10 UTC (permalink / raw)
  To: buildroot

Hi Arnout,

Le mar. 25 mai 2021 ? 21:27, Arnout Vandecappelle <arnout@mind.be> a ?crit :
>
>
>
> On 21/05/2021 22:03, Fabrice Fontaine wrote:
> > boost logs can't be built with riscv32 because it unconditionally uses
> > __NR_futex:
> >
> > libs/log/src/event.cpp: In member function 'void boost::log::v2_mt_posix::aux::futex_based_event::wait()':
> > libs/log/src/event.cpp:38:29: error: '__NR_futex' was not declared in this scope
> >    38 | #define BOOST_LOG_SYS_FUTEX __NR_futex
> >       |                             ^~~~~~~~~~
>
>  There seems to be a similar issue in boost/atomic/detail/futex.hpp, e.g. [1].
The link that you've given is also raised by log, not atomic:

    - log                      : building

libs/log/src/event.cpp:38:29: error: '__NR_futex' was not declared in this scope
   38 | #define BOOST_LOG_SYS_FUTEX __NR_futex
      |                             ^~~~~~~~~~
> Could you handle that as well?
>
>
>  Regards,
>  Arnout
>
>
> [1]
> http://autobuild.buildroot.net/results/6aa/6aa7ac8b14c3ba4f674d541fabb4476680b299a7/build-end.log
>
>
> >
> > Fixes:
> >  - http://autobuild.buildroot.org/results/8c8135fd7c0517c66c9b3975c494da6d7934cc1b
> >
> > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> > ---
> >  package/azmq/Config.in  | 3 +++
> >  package/boost/Config.in | 3 +++
> >  2 files changed, 6 insertions(+)
> >
> > diff --git a/package/azmq/Config.in b/package/azmq/Config.in
> > index 37131a260a..6751d533a4 100644
> > --- a/package/azmq/Config.in
> > +++ b/package/azmq/Config.in
> > @@ -1,5 +1,6 @@
> >  config BR2_PACKAGE_AZMQ
> >       bool "azmq"
> > +     depends on !BR2_RISCV_32 # boost-log
> >       depends on BR2_INSTALL_LIBSTDCPP
> >       depends on BR2_TOOLCHAIN_HAS_ATOMIC
> >       depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL # boost-log
> > @@ -22,9 +23,11 @@ config BR2_PACKAGE_AZMQ
> >         https://github.com/zeromq/azmq
> >
> >  comment "azmq needs a toolchain w/ C++11, wchar and NPTL"
> > +     depends on !BR2_RISCV_32
> >       depends on BR2_TOOLCHAIN_SUPPORTS_ALWAYS_LOCKFREE_ATOMIC_INTS
> >       depends on !(BR2_INSTALL_LIBSTDCPP && BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 \
> >               && BR2_USE_WCHAR && BR2_TOOLCHAIN_HAS_THREADS_NPTL)
> >
> >  comment "azmq needs exception_ptr"
> > +     depends on !BR2_RISCV_32
> >       depends on BR2_TOOLCHAIN_HAS_GCC_BUG_64735
> > diff --git a/package/boost/Config.in b/package/boost/Config.in
> > index 3e96e1ede3..75bb81600a 100644
> > --- a/package/boost/Config.in
> > +++ b/package/boost/Config.in
> > @@ -240,6 +240,7 @@ comment "boost-locale needs a toolchain not affected by GCC bug 64735"
> >
> >  config BR2_PACKAGE_BOOST_LOG
> >       bool "boost-log"
> > +     depends on !BR2_RISCV_32>       depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL
> >       depends on BR2_TOOLCHAIN_SUPPORTS_ALWAYS_LOCKFREE_ATOMIC_INTS # boost-atomic
> >       depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_64735 # boost-thread
> > @@ -253,10 +254,12 @@ config BR2_PACKAGE_BOOST_LOG
> >         Logging library.
> >
> >  comment "boost-log needs a toolchain w/ NPTL"
> > +     depends on !BR2_RISCV_32
> >       depends on BR2_TOOLCHAIN_SUPPORTS_ALWAYS_LOCKFREE_ATOMIC_INTS
> >       depends on !BR2_TOOLCHAIN_HAS_THREADS_NPTL
> >
> >  comment "boost-log needs a toolchain not affected by GCC bug 64735"
> > +     depends on !BR2_RISCV_32
> >       depends on BR2_TOOLCHAIN_HAS_GCC_BUG_64735
> >
> >  config BR2_PACKAGE_BOOST_MATH
>
>
>
Best Regards,

Fabrice

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Buildroot] [PATCH 1/1] package/boost: disable logs with riscv32
  2021-05-27  6:10   ` Fabrice Fontaine
@ 2021-05-27  7:45     ` Arnout Vandecappelle
  0 siblings, 0 replies; 5+ messages in thread
From: Arnout Vandecappelle @ 2021-05-27  7:45 UTC (permalink / raw)
  To: buildroot



On 27/05/2021 08:10, Fabrice Fontaine wrote:
> Hi Arnout,
> 
> Le mar. 25 mai 2021 ? 21:27, Arnout Vandecappelle <arnout@mind.be> a ?crit :
>>
>>
>>
>> On 21/05/2021 22:03, Fabrice Fontaine wrote:
>>> boost logs can't be built with riscv32 because it unconditionally uses
>>> __NR_futex:
>>>
>>> libs/log/src/event.cpp: In member function 'void boost::log::v2_mt_posix::aux::futex_based_event::wait()':
>>> libs/log/src/event.cpp:38:29: error: '__NR_futex' was not declared in this scope
>>>    38 | #define BOOST_LOG_SYS_FUTEX __NR_futex
>>>       |                             ^~~~~~~~~~
>>
>>  There seems to be a similar issue in boost/atomic/detail/futex.hpp, e.g. [1].
> The link that you've given is also raised by log, not atomic:
> 
>     - log                      : building
> 
> libs/log/src/event.cpp:38:29: error: '__NR_futex' was not declared in this scope
>    38 | #define BOOST_LOG_SYS_FUTEX __NR_futex
>       |                             ^~~~~~~~~~

 Ah, my bad. atomic/detail/futex.h has pretty much the same code, but it also
defines BOOST_ATOMIC_DETAIL_HAS_FUTEX and its users check that.


 Applied to master, thanks.

 Regards,
 Arnout

>> Could you handle that as well?
>>
>>
>>  Regards,
>>  Arnout
>>
>>
>> [1]
>> http://autobuild.buildroot.net/results/6aa/6aa7ac8b14c3ba4f674d541fabb4476680b299a7/build-end.log
>>
>>
>>>
>>> Fixes:
>>>  - http://autobuild.buildroot.org/results/8c8135fd7c0517c66c9b3975c494da6d7934cc1b
>>>
>>> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
>>> ---
>>>  package/azmq/Config.in  | 3 +++
>>>  package/boost/Config.in | 3 +++
>>>  2 files changed, 6 insertions(+)
>>>
>>> diff --git a/package/azmq/Config.in b/package/azmq/Config.in
>>> index 37131a260a..6751d533a4 100644
>>> --- a/package/azmq/Config.in
>>> +++ b/package/azmq/Config.in
>>> @@ -1,5 +1,6 @@
>>>  config BR2_PACKAGE_AZMQ
>>>       bool "azmq"
>>> +     depends on !BR2_RISCV_32 # boost-log
>>>       depends on BR2_INSTALL_LIBSTDCPP
>>>       depends on BR2_TOOLCHAIN_HAS_ATOMIC
>>>       depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL # boost-log
>>> @@ -22,9 +23,11 @@ config BR2_PACKAGE_AZMQ
>>>         https://github.com/zeromq/azmq
>>>
>>>  comment "azmq needs a toolchain w/ C++11, wchar and NPTL"
>>> +     depends on !BR2_RISCV_32
>>>       depends on BR2_TOOLCHAIN_SUPPORTS_ALWAYS_LOCKFREE_ATOMIC_INTS
>>>       depends on !(BR2_INSTALL_LIBSTDCPP && BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 \
>>>               && BR2_USE_WCHAR && BR2_TOOLCHAIN_HAS_THREADS_NPTL)
>>>
>>>  comment "azmq needs exception_ptr"
>>> +     depends on !BR2_RISCV_32
>>>       depends on BR2_TOOLCHAIN_HAS_GCC_BUG_64735
>>> diff --git a/package/boost/Config.in b/package/boost/Config.in
>>> index 3e96e1ede3..75bb81600a 100644
>>> --- a/package/boost/Config.in
>>> +++ b/package/boost/Config.in
>>> @@ -240,6 +240,7 @@ comment "boost-locale needs a toolchain not affected by GCC bug 64735"
>>>
>>>  config BR2_PACKAGE_BOOST_LOG
>>>       bool "boost-log"
>>> +     depends on !BR2_RISCV_32>       depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL
>>>       depends on BR2_TOOLCHAIN_SUPPORTS_ALWAYS_LOCKFREE_ATOMIC_INTS # boost-atomic
>>>       depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_64735 # boost-thread
>>> @@ -253,10 +254,12 @@ config BR2_PACKAGE_BOOST_LOG
>>>         Logging library.
>>>
>>>  comment "boost-log needs a toolchain w/ NPTL"
>>> +     depends on !BR2_RISCV_32
>>>       depends on BR2_TOOLCHAIN_SUPPORTS_ALWAYS_LOCKFREE_ATOMIC_INTS
>>>       depends on !BR2_TOOLCHAIN_HAS_THREADS_NPTL
>>>
>>>  comment "boost-log needs a toolchain not affected by GCC bug 64735"
>>> +     depends on !BR2_RISCV_32
>>>       depends on BR2_TOOLCHAIN_HAS_GCC_BUG_64735
>>>
>>>  config BR2_PACKAGE_BOOST_MATH
>>
>>
>>
> Best Regards,
> 
> Fabrice
> 

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Buildroot] [PATCH 1/1] package/boost: disable logs with riscv32
  2021-05-21 20:03 [Buildroot] [PATCH 1/1] package/boost: disable logs with riscv32 Fabrice Fontaine
  2021-05-25 19:26 ` Arnout Vandecappelle
@ 2021-06-09 20:55 ` Peter Korsgaard
  1 sibling, 0 replies; 5+ messages in thread
From: Peter Korsgaard @ 2021-06-09 20:55 UTC (permalink / raw)
  To: buildroot

>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > boost logs can't be built with riscv32 because it unconditionally uses
 > __NR_futex:

 > libs/log/src/event.cpp: In member function 'void boost::log::v2_mt_posix::aux::futex_based_event::wait()':
 > libs/log/src/event.cpp:38:29: error: '__NR_futex' was not declared in this scope
 >    38 | #define BOOST_LOG_SYS_FUTEX __NR_futex
 >       |                             ^~~~~~~~~~

 > Fixes:
 >  - http://autobuild.buildroot.org/results/8c8135fd7c0517c66c9b3975c494da6d7934cc1b

 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Committed to 2021.02.x, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2021-06-09 20:55 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-21 20:03 [Buildroot] [PATCH 1/1] package/boost: disable logs with riscv32 Fabrice Fontaine
2021-05-25 19:26 ` Arnout Vandecappelle
2021-05-27  6:10   ` Fabrice Fontaine
2021-05-27  7:45     ` Arnout Vandecappelle
2021-06-09 20:55 ` Peter Korsgaard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.