All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sagi Grimberg <sagi@grimberg.me>
To: Josef Bacik <jbacik@fb.com>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
	Kernel Team <Kernel-team@fb.com>
Subject: Re: [PATCH] nbd: use an idr to keep track of nbd devices
Date: Mon, 16 Jan 2017 23:29:50 +0200	[thread overview]
Message-ID: <7c2ddd83-5d09-5ffb-3c39-524d17c24796@grimberg.me> (raw)
In-Reply-To: <1484442837.7132.1@smtp.office365.com>

Hey Josef,

> I'm going to use it the same way loop does, there will be a
> /dev/nbd-control where you can say ADD, REMOVE, and GET_NEXT. I need the
> search functionality to see if we are adding something that already
> exists, and to see what is the next unused device that can be used for a
> connection.  Looking at the ida api it does not appear I can do that. If
> I'm wrong then please point out an example I can look at, because I
> haven't been able to find one.  Thanks,

Nope, ida doesn't have search functionality. Having said that, will it
suffice to have the idr tree without a separate data structure? because
the tree mutation under idr_for_each is not allowed. For example,
I'd expect that nbd module unload will iterate over the existing
devices and destroy them which requires a separate tracking of
them, also, I think that the idr user needs to take care of locking
(unlike ida).

  reply	other threads:[~2017-01-16 21:29 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-13 19:04 [PATCH] nbd: use an idr to keep track of nbd devices Josef Bacik
2017-01-13 22:30 ` Jens Axboe
2017-01-13 22:40 ` Sagi Grimberg
2017-01-14  1:18   ` Josef Bacik
2017-01-14 21:10     ` Sagi Grimberg
2017-01-15  1:13       ` Josef Bacik
2017-01-16 21:29         ` Sagi Grimberg [this message]
2017-01-17  0:17           ` Josef Bacik
2017-02-01 21:11 Josef Bacik
2017-02-02  1:36 ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7c2ddd83-5d09-5ffb-3c39-524d17c24796@grimberg.me \
    --to=sagi@grimberg.me \
    --cc=Kernel-team@fb.com \
    --cc=jbacik@fb.com \
    --cc=linux-block@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.