From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.9 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B49E0C47092 for ; Mon, 31 May 2021 00:52:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7EF03611AB for ; Mon, 31 May 2021 00:52:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229915AbhEaAy2 (ORCPT ); Sun, 30 May 2021 20:54:28 -0400 Received: from mga18.intel.com ([134.134.136.126]:16281 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229887AbhEaAy1 (ORCPT ); Sun, 30 May 2021 20:54:27 -0400 IronPort-SDR: Ob4lgGooz+d4tR2E4OR3u2fQPZxlVlfKCyFhQBKSy6w0Ff7AFnm1cGHawOVe/TJ7T6Y/dDlcrj 0t+amLsnxqFA== X-IronPort-AV: E=McAfee;i="6200,9189,10000"; a="190632004" X-IronPort-AV: E=Sophos;i="5.83,236,1616482800"; d="scan'208";a="190632004" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 May 2021 17:52:48 -0700 IronPort-SDR: LNN+Vit3cFlunU+54UbsQAk0XE1QQZyir78WkRN4Ni9nHHsVeoni8fX+VX/ZOTz0iUvk9NmhvE dIS7D/H6SkDg== X-IronPort-AV: E=Sophos;i="5.83,236,1616482800"; d="scan'208";a="444785294" Received: from shao2-debian.sh.intel.com (HELO [10.239.13.11]) ([10.239.13.11]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 May 2021 17:52:46 -0700 Subject: Re: [kbuild-all] Re: [PATCH 2/3] crypto: hisilicon/sec - add fallback tfm supporting for XTS mode To: "yekai(A)" , kernel test robot , herbert@gondor.apana.org.au Cc: kbuild-all@lists.01.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, wangzhou1@hisilicon.com References: <1622202126-19237-3-git-send-email-yekai13@huawei.com> <202105282256.hUBoOJ3Z-lkp@intel.com> From: Rong Chen Message-ID: <7c435436-cf38-7c09-9141-8410a8c18cc8@intel.com> Date: Mon, 31 May 2021 08:51:30 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On 5/29/21 5:22 PM, yekai(A) wrote: > > > On 2021/5/28 22:13, kernel test robot wrote: >> Hi Kai, >> >> Thank you for the patch! Yet something to improve: >> >> [auto build test ERROR on cryptodev/master] >> [also build test ERROR on crypto/master linux/master linus/master >> v5.13-rc3 next-20210528] >> [If your patch is applied to the wrong git tree, kindly drop us a note. >> And when submitting patch, we suggest to use '--base' as documented in >> https://git-scm.com/docs/git-format-patch] >> >> url: >> https://github.com/0day-ci/linux/commits/Kai-Ye/crypto-hisilicon-supports-new-skciphers-for-new-hardware/20210528-194644 >> base: >> https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git >> master >> config: ia64-allmodconfig (attached as .config) >> compiler: ia64-linux-gcc (GCC) 9.3.0 >> reproduce (this is a W=1 build): >>         wget >> https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross >> -O ~/bin/make.cross >>         chmod +x ~/bin/make.cross >>         # >> https://github.com/0day-ci/linux/commit/60bae5ed49c53ea90c82125a8295fb72833a3b68 >>         git remote add linux-review https://github.com/0day-ci/linux >>         git fetch --no-tags linux-review >> Kai-Ye/crypto-hisilicon-supports-new-skciphers-for-new-hardware/20210528-194644 >>         git checkout 60bae5ed49c53ea90c82125a8295fb72833a3b68 >>         # save the attached .config to linux build tree >>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 >> make.cross ARCH=ia64 >> >> If you fix the issue, kindly add following tag as appropriate >> Reported-by: kernel test robot >> >> All errors (new ones prefixed by >>): >> >>    drivers/crypto/hisilicon/sec2/sec_crypto.c: In function >> 'sec_aead_crypto': >>>> drivers/crypto/hisilicon/sec2/sec_crypto.c:1751:40: error: 'sk_req' >>>> undeclared (first use in this function); did you mean 'a_req'? >>     1751 |   return sec_skcipher_soft_crypto(ctx, sk_req, encrypt); >>          |                                        ^~~~~~ >>          |                                        a_req >>    drivers/crypto/hisilicon/sec2/sec_crypto.c:1751:40: note: each >> undeclared identifier is reported only once for each function it >> appears in >> >> >> vim +1751 drivers/crypto/hisilicon/sec2/sec_crypto.c >> >>   1733 >>   1734    static int sec_aead_crypto(struct aead_request *a_req, bool >> encrypt) >>   1735    { >>   1736        struct crypto_aead *tfm = crypto_aead_reqtfm(a_req); >>   1737        struct sec_req *req = aead_request_ctx(a_req); >>   1738        struct sec_ctx *ctx = crypto_aead_ctx(tfm); >>   1739        int ret; >>   1740 >>   1741        req->flag = a_req->base.flags; >>   1742        req->aead_req.aead_req = a_req; >>   1743        req->c_req.encrypt = encrypt; >>   1744        req->ctx = ctx; >>   1745 >>   1746        ret = sec_aead_param_check(ctx, req); >>   1747        if (unlikely(ret)) >>   1748            return -EINVAL; >>   1749 >>   1750        if (unlikely(ctx->c_ctx.fallback)) >>> 1751            return sec_skcipher_soft_crypto(ctx, sk_req, encrypt); >>   1752 >>   1753        return ctx->req_op->process(ctx, req); >>   1754    } >>   1755 >> >> --- >> 0-DAY CI Kernel Test Service, Intel Corporation >> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org >> > > > You shouldn't git am this patchset directly, because this patchset > depends on previous patchset. > the series is "crypto: hisilicon - add new type of sqe for Kunpeng930", > the patchwork is > https://patchwork.kernel.org/project/linux-crypto/list/?series=490143, > thank you > Kai Hi Kai, Thanks for the clarification, it could be very helpful for us if '--base' for git format-patch used or there is a patchwork link in cover letter file. Best Regards, Rong Chen From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============9123937303426511183==" MIME-Version: 1.0 From: Rong Chen To: kbuild-all@lists.01.org Subject: Re: [PATCH 2/3] crypto: hisilicon/sec - add fallback tfm supporting for XTS mode Date: Mon, 31 May 2021 08:51:30 +0800 Message-ID: <7c435436-cf38-7c09-9141-8410a8c18cc8@intel.com> In-Reply-To: List-Id: --===============9123937303426511183== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On 5/29/21 5:22 PM, yekai(A) wrote: > > > On 2021/5/28 22:13, kernel test robot wrote: >> Hi Kai, >> >> Thank you for the patch! Yet something to improve: >> >> [auto build test ERROR on cryptodev/master] >> [also build test ERROR on crypto/master linux/master linus/master = >> v5.13-rc3 next-20210528] >> [If your patch is applied to the wrong git tree, kindly drop us a note. >> And when submitting patch, we suggest to use '--base' as documented in >> https://git-scm.com/docs/git-format-patch] >> >> url: = >> https://github.com/0day-ci/linux/commits/Kai-Ye/crypto-hisilicon-support= s-new-skciphers-for-new-hardware/20210528-194644 >> base: = >> https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.gi= t = >> master >> config: ia64-allmodconfig (attached as .config) >> compiler: ia64-linux-gcc (GCC) 9.3.0 >> reproduce (this is a W=3D1 build): >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 wget = >> https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross = >> -O ~/bin/make.cross >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 chmod +x ~/bin/make.cross >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 # = >> https://github.com/0day-ci/linux/commit/60bae5ed49c53ea90c82125a8295fb72= 833a3b68 >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 git remote add linux-review h= ttps://github.com/0day-ci/linux >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 git fetch --no-tags linux-rev= iew = >> Kai-Ye/crypto-hisilicon-supports-new-skciphers-for-new-hardware/20210528= -194644 >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 git checkout 60bae5ed49c53ea9= 0c82125a8295fb72833a3b68 >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 # save the attached .config t= o linux build tree >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 COMPILER_INSTALL_PATH=3D$HOME= /0day COMPILER=3Dgcc-9.3.0 = >> make.cross ARCH=3Dia64 >> >> If you fix the issue, kindly add following tag as appropriate >> Reported-by: kernel test robot >> >> All errors (new ones prefixed by >>): >> >> =C2=A0=C2=A0 drivers/crypto/hisilicon/sec2/sec_crypto.c: In function = >> 'sec_aead_crypto': >>>> drivers/crypto/hisilicon/sec2/sec_crypto.c:1751:40: error: 'sk_req' = >>>> undeclared (first use in this function); did you mean 'a_req'? >> =C2=A0=C2=A0=C2=A0 1751 |=C2=A0=C2=A0 return sec_skcipher_soft_crypto(ct= x, sk_req, encrypt); >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ^~~~~~ >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 a_req >> =C2=A0=C2=A0 drivers/crypto/hisilicon/sec2/sec_crypto.c:1751:40: note: e= ach = >> undeclared identifier is reported only once for each function it = >> appears in >> >> >> vim +1751 drivers/crypto/hisilicon/sec2/sec_crypto.c >> >> =C2=A0 1733 >> =C2=A0 1734=C2=A0=C2=A0=C2=A0 static int sec_aead_crypto(struct aead_req= uest *a_req, bool = >> encrypt) >> =C2=A0 1735=C2=A0=C2=A0=C2=A0 { >> =C2=A0 1736=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 struct crypto_aead= *tfm =3D crypto_aead_reqtfm(a_req); >> =C2=A0 1737=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 struct sec_req *re= q =3D aead_request_ctx(a_req); >> =C2=A0 1738=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 struct sec_ctx *ct= x =3D crypto_aead_ctx(tfm); >> =C2=A0 1739=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 int ret; >> =C2=A0 1740 >> =C2=A0 1741=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 req->flag =3D a_re= q->base.flags; >> =C2=A0 1742=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 req->aead_req.aead= _req =3D a_req; >> =C2=A0 1743=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 req->c_req.encrypt= =3D encrypt; >> =C2=A0 1744=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 req->ctx =3D ctx; >> =C2=A0 1745 >> =C2=A0 1746=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ret =3D sec_aead_p= aram_check(ctx, req); >> =C2=A0 1747=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (unlikely(ret)) >> =C2=A0 1748=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 return -EINVAL; >> =C2=A0 1749 >> =C2=A0 1750=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (unlikely(ctx->= c_ctx.fallback)) >>> 1751=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 = return sec_skcipher_soft_crypto(ctx, sk_req, encrypt); >> =C2=A0 1752 >> =C2=A0 1753=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return ctx->req_op= ->process(ctx, req); >> =C2=A0 1754=C2=A0=C2=A0=C2=A0 } >> =C2=A0 1755 >> >> --- >> 0-DAY CI Kernel Test Service, Intel Corporation >> https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org >> > > > You shouldn't git am this patchset directly, because this patchset = > depends on previous patchset. > the series is "crypto: hisilicon - add new type of sqe for Kunpeng930", > the patchwork is = > https://patchwork.kernel.org/project/linux-crypto/list/?series=3D490143, > thank you > Kai Hi Kai, Thanks for the clarification, it could be very helpful for us if = '--base' for git format-patch used or there is a patchwork link in cover letter file. Best Regards, Rong Chen --===============9123937303426511183==--