From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A4CEC433F5 for ; Wed, 9 Feb 2022 15:48:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236266AbiBIPs2 (ORCPT ); Wed, 9 Feb 2022 10:48:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59730 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236279AbiBIPsZ (ORCPT ); Wed, 9 Feb 2022 10:48:25 -0500 Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [IPv6:2a00:1450:4864:20::12d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E28B1C05CB82; Wed, 9 Feb 2022 07:48:28 -0800 (PST) Received: by mail-lf1-x12d.google.com with SMTP id i34so5057964lfv.2; Wed, 09 Feb 2022 07:48:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:subject:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=82DwdajpDNDBqVPVvon+Lp7fZFYchqTwnP7OnaqMXhA=; b=ZOkWhnlTBnzqrCpWvyLu4YD7jOCU7hGFKGq6WCfRVdhxmTbBTYIQG8rMNK93Kuf10u 1ZzuxSt8qLrH/DHbop68m20FsgNUQBBJZQet7nDoNej3g7GDVjLaXArFIRy3Xp3dZ8PI oGVVrR1548ktVnF4a8IZK+6mgLS+8KpaGogK3XwYJoReaZ9N4gWaDOIz4aGP91gGUeaC rGeO3HC/i3L0oV6fDRw0dKedzCghrlk5X6d/cqD8ncs4Munz7zBKtlQtSEGVgdBkfg5r mjYm4Yr95o6wCrb8+Vf4nqQO8QkOOcI1viia+oVy6pXgCSEusij2UzqN4/CUFUpXA7YT E6iA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:subject:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=82DwdajpDNDBqVPVvon+Lp7fZFYchqTwnP7OnaqMXhA=; b=HVCvqzSENLWpifCYGS47JwZNpEyQ4wZaRZ8D8MP2Pf8AlaBWWcTMtuZP8sZLuZP5Oq qbZD5vDsGqw3fUUx9qrAfKf/oJVljxDPHcNZsCuRvB0qEIY6KFZuJuQH0P7m+Kq0NSFy p/HCDB6nmSgY1Deo3mNJ4W7/z8RwXZ9aUZcHU7FkStqsfyhL6IR3K0dqNYFBBTo/x9t1 Y083afP9KUTsH5cyjFUH9jzTdEskCpGB3g7fWnu9CilDwHWHH1TJoTtfO5hIUZw0RSHC hNMe+2lDSsHE9/497y4sYHHCxfcbzqHXdhr9yGMTbpYlaFn3HP34xAnASLWjj4PgDsRe cT7Q== X-Gm-Message-State: AOAM531+LND9D78pfPQzipNeFGsOMjw+dNM5o0VAcGIxaUB0z8cOupPB hcqo7mPWqpY8A8hxm4HHmCguwzK+CWJaqg== X-Google-Smtp-Source: ABdhPJzOm978Gkpt9GdyeIqflw6RUzXCclEoSV+vfQH7V5jKfnEkSPwqXRFfDJFIqi8RsajP0cS8Ug== X-Received: by 2002:a05:6512:33ce:: with SMTP id d14mr2058147lfg.264.1644421706987; Wed, 09 Feb 2022 07:48:26 -0800 (PST) Received: from [192.168.1.103] ([178.176.73.27]) by smtp.gmail.com with ESMTPSA id d20sm2521958ljl.25.2022.02.09.07.48.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Feb 2022 07:48:26 -0800 (PST) From: Sergei Shtylyov Subject: Re: [PATCH 2/3] i2c: sh_mobile: Use platform_get_irq_optional() to get the interrupt To: Arnd Bergmann Cc: Geert Uytterhoeven , Lad Prabhakar , Rob Herring , Nicolas Saenz Julienne , Florian Fainelli , Ray Jui , Scott Branden , bcm-kernel-feedback-list , Chris Brandt , Wolfram Sang , Linux I2C , linux-rpi-kernel , Linux ARM , Linux Kernel Mailing List , Linux-Renesas , Prabhakar , Linux-sh list References: <20211218165258.16716-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20211218165258.16716-3-prabhakar.mahadev-lad.rj@bp.renesas.com> <042a2183-3f04-088c-1861-656de870337d@gmail.com> Message-ID: <7c47ce67-88ee-9cba-3356-a530b0d3e657@gmail.com> Date: Wed, 9 Feb 2022 18:48:24 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-sh@vger.kernel.org On 2/9/22 6:18 PM, Arnd Bergmann wrote: > On Wed, Feb 9, 2022 at 4:11 PM Sergei Shtylyov > wrote: >> >> On 2/8/22 3:31 PM, Arnd Bergmann wrote: >> >> [...] >>>>> I might have missed something, but it seems the only user of IRQ 0 on >>>>> SuperH is smsc911x Ethernet in arch/sh/boards/board-apsh4a3a.c and >>>>> arch/sh/boards/board-apsh4ad0a.c, which use evt2irq(0x200). >>>>> These should have been seeing the "0 is an invalid IRQ number" >>>>> warning splat since it was introduced in commit a85a6c86c25be2d2 >>>>> ("driver core: platform: Clarify that IRQ 0 is invalid"). Or not: >>>> >>>> Warning or no warning, 0 is still returned. :-/ >>>> My attempt to put an end to this has stuck waiting a review from the IRQ >>>> people... >>> >>> I had another look at this after you asked about it on IRC. I don't >>> know much SH assembly, but I suspect IRQ 0 has not been delivered Neither do I, sigh... I do know the instuctions are 16-bit and so there are no immediate opperands... :-) >>> since 2009 after 1e1030dccb10 ("sh: nmi_debug support."). On a >> >> Mhm... this commit changes the SH3 code while SH778x are SH4A, no? > > This code is shared between both: > > arch/sh/kernel/cpu/sh4/Makefile:common-y += $(addprefix > ../sh3/, entry.o ex.o) Ah, quite convoluted! :-) So you mean thet broke the delivery of EVT 0x200 when mucking with NMI? > Arnd MBR, Sergey From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B73DBC433F5 for ; Wed, 9 Feb 2022 15:49:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:References:Cc:To:Subject:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=1PlZPEKraxEE9bH/+rgLoRjKxgU/q9w5YCvBc+GcTZ4=; b=zMSs+dXliAVwFsN/w2U4sBXeNh BoKMb2XzwXVSRmJZQtY40z0LiL0xwfdKWQ11Ocf5VfX/W6V0x/whMTFnNPYoRMEAmrIOz+vnMWHJb NzSRwuIOl1OkMn4jiimkvT68W/g5MUT4Ry7JfkYNkvtjw3W/oCRxVD/htVwMGMz0HTwkRalkiaAcF mOZ1sAS+9k3qADjeea7HyV4gZ1aVx8+VXxiJHAvBN2THiyvVT2y9mYWT4PR5dh20jnk3Rd63ubl8X 4fqYXXE282vqkGRMtch1TxesmmnUNPIODqDgW/P6+Mayqo/9YjJ0ZlqL7itQliSMfQZcojsWFs8Az t7suoIBw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nHpCu-000guB-33; Wed, 09 Feb 2022 15:48:36 +0000 Received: from mail-lf1-x132.google.com ([2a00:1450:4864:20::132]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nHpCm-000grt-MV; Wed, 09 Feb 2022 15:48:30 +0000 Received: by mail-lf1-x132.google.com with SMTP id k13so4983821lfg.9; Wed, 09 Feb 2022 07:48:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:subject:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=82DwdajpDNDBqVPVvon+Lp7fZFYchqTwnP7OnaqMXhA=; b=ZOkWhnlTBnzqrCpWvyLu4YD7jOCU7hGFKGq6WCfRVdhxmTbBTYIQG8rMNK93Kuf10u 1ZzuxSt8qLrH/DHbop68m20FsgNUQBBJZQet7nDoNej3g7GDVjLaXArFIRy3Xp3dZ8PI oGVVrR1548ktVnF4a8IZK+6mgLS+8KpaGogK3XwYJoReaZ9N4gWaDOIz4aGP91gGUeaC rGeO3HC/i3L0oV6fDRw0dKedzCghrlk5X6d/cqD8ncs4Munz7zBKtlQtSEGVgdBkfg5r mjYm4Yr95o6wCrb8+Vf4nqQO8QkOOcI1viia+oVy6pXgCSEusij2UzqN4/CUFUpXA7YT E6iA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:subject:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=82DwdajpDNDBqVPVvon+Lp7fZFYchqTwnP7OnaqMXhA=; b=YHqo6aZx3NDQ98oN5wRwjiTXUdA8mltpg9eHYsHnoKeNg0GsYhRBmbLbLRC0miLtgs 1ZuOu1cPYzkmH813G3le280AteYm6c9t21jdpzndCTrosESdnJjb1uk8wn0inH+xnF/z 6mPwIibW4rI6LTUblghKKAO3Nd52Hy5+MWanCg7A094A8Mxa5keEYjeevMVSr1rZvZ/H jBbqNrm4hgthwcTWdSlGyv+tvzehLrqEn0SnlXThFzXzJcBIlwJEHBgc6eFrvbP7ULmJ PABgjzoss0e97CELdwVgeR6RtOcMXyFkF039HoY/yuuSTZ+714Qqak0psbq7VTF/gqm7 Gl+Q== X-Gm-Message-State: AOAM532+3wB3NlpCmCP7DNd8ofhyZvOJ8K20a6heeCd9QdfT0QXH55pr DHUyXRJFrDTQ2kaxfXTnS3c= X-Google-Smtp-Source: ABdhPJzOm978Gkpt9GdyeIqflw6RUzXCclEoSV+vfQH7V5jKfnEkSPwqXRFfDJFIqi8RsajP0cS8Ug== X-Received: by 2002:a05:6512:33ce:: with SMTP id d14mr2058147lfg.264.1644421706987; Wed, 09 Feb 2022 07:48:26 -0800 (PST) Received: from [192.168.1.103] ([178.176.73.27]) by smtp.gmail.com with ESMTPSA id d20sm2521958ljl.25.2022.02.09.07.48.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Feb 2022 07:48:26 -0800 (PST) From: Sergei Shtylyov Subject: Re: [PATCH 2/3] i2c: sh_mobile: Use platform_get_irq_optional() to get the interrupt To: Arnd Bergmann Cc: Geert Uytterhoeven , Lad Prabhakar , Rob Herring , Nicolas Saenz Julienne , Florian Fainelli , Ray Jui , Scott Branden , bcm-kernel-feedback-list , Chris Brandt , Wolfram Sang , Linux I2C , linux-rpi-kernel , Linux ARM , Linux Kernel Mailing List , Linux-Renesas , Prabhakar , Linux-sh list References: <20211218165258.16716-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20211218165258.16716-3-prabhakar.mahadev-lad.rj@bp.renesas.com> <042a2183-3f04-088c-1861-656de870337d@gmail.com> Message-ID: <7c47ce67-88ee-9cba-3356-a530b0d3e657@gmail.com> Date: Wed, 9 Feb 2022 18:48:24 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220209_074828_814778_A5349140 X-CRM114-Status: GOOD ( 16.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2/9/22 6:18 PM, Arnd Bergmann wrote: > On Wed, Feb 9, 2022 at 4:11 PM Sergei Shtylyov > wrote: >> >> On 2/8/22 3:31 PM, Arnd Bergmann wrote: >> >> [...] >>>>> I might have missed something, but it seems the only user of IRQ 0 on >>>>> SuperH is smsc911x Ethernet in arch/sh/boards/board-apsh4a3a.c and >>>>> arch/sh/boards/board-apsh4ad0a.c, which use evt2irq(0x200). >>>>> These should have been seeing the "0 is an invalid IRQ number" >>>>> warning splat since it was introduced in commit a85a6c86c25be2d2 >>>>> ("driver core: platform: Clarify that IRQ 0 is invalid"). Or not: >>>> >>>> Warning or no warning, 0 is still returned. :-/ >>>> My attempt to put an end to this has stuck waiting a review from the IRQ >>>> people... >>> >>> I had another look at this after you asked about it on IRC. I don't >>> know much SH assembly, but I suspect IRQ 0 has not been delivered Neither do I, sigh... I do know the instuctions are 16-bit and so there are no immediate opperands... :-) >>> since 2009 after 1e1030dccb10 ("sh: nmi_debug support."). On a >> >> Mhm... this commit changes the SH3 code while SH778x are SH4A, no? > > This code is shared between both: > > arch/sh/kernel/cpu/sh4/Makefile:common-y += $(addprefix > ../sh3/, entry.o ex.o) Ah, quite convoluted! :-) So you mean thet broke the delivery of EVT 0x200 when mucking with NMI? > Arnd MBR, Sergey _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel