All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: Andrew Jones <drjones@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-arm@nongnu.org, f4bug@amsat.org,
	alex.bennee@linaro.org
Subject: Re: [PATCH] tests/avocado: Prefer max cpu type when using AArch64 virt machine
Date: Fri, 3 Jun 2022 08:34:16 -0700	[thread overview]
Message-ID: <7c4ecea9-3c63-e429-eb6f-44cb32cca147@linaro.org> (raw)
In-Reply-To: <20220603150536.pt5jwmoeoqfkeixu@gator>

On 6/3/22 08:05, Andrew Jones wrote:
> On Fri, Jun 03, 2022 at 06:56:41AM -0700, Richard Henderson wrote:
>> On 6/3/22 02:25, Andrew Jones wrote:
>>> The max cpu type is the best default cpu type for tests to use
>>> when specifying the cpu type for AArch64 mach-virt. Switch all
>>> tests to it.
>>
>> This won't work without further changes.
>>
>>> @@ -147,7 +147,7 @@ def test_aarch64_virt(self):
>>>            """
>>>            :avocado: tags=arch:aarch64
>>>            :avocado: tags=machine:virt
>>> -        :avocado: tags=cpu:cortex-a53
>>> +        :avocado: tags=cpu:max
>>>            """
>>>            kernel_url = ('https://archives.fedoraproject.org/pub/archive/fedora'
>>>                          '/linux/releases/29/Everything/aarch64/os/images/pxeboot'
>>
>> For a release this old, we'll see the kernel bugs wrt FEAT_LPA/FEAT_LPA2.
>> See 11593544df6f ("tests/avocado: update aarch64_virt test to exercise -cpu max")
> 
> Thanks Richard. How about for each test with guest kernels which don't
> work, I add a comment about LPA2 and use '-cpu max,lpa2=off' instead?

I would prefer to test new kernels with max, where we might actually test the newer 
features.  Perhaps keep one older kernel test around, to make sure we don't regress, but 
don't pretend that it can test more than what it was built for.


r~


      reply	other threads:[~2022-06-03 15:36 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-03  9:25 [PATCH] tests/avocado: Prefer max cpu type when using AArch64 virt machine Andrew Jones
2022-06-03  9:55 ` Andrew Jones
2022-06-03 10:07 ` Cornelia Huck
2022-06-03 10:18   ` Andrew Jones
2022-06-03 13:56 ` Richard Henderson
2022-06-03 15:05   ` Andrew Jones
2022-06-03 15:34     ` Richard Henderson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7c4ecea9-3c63-e429-eb6f-44cb32cca147@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=alex.bennee@linaro.org \
    --cc=drjones@redhat.com \
    --cc=f4bug@amsat.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.