From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ale.deltatee.com (ale.deltatee.com [207.54.116.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B3E59210DA7AF for ; Thu, 30 Aug 2018 12:17:53 -0700 (PDT) References: <20180830185352.3369-1-logang@deltatee.com> <20180830185352.3369-8-logang@deltatee.com> From: Logan Gunthorpe Message-ID: <7c5b9d2c-d94e-582c-f1d7-0827dbb7df7c@deltatee.com> Date: Thu, 30 Aug 2018 13:17:40 -0600 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US Subject: Re: [PATCH v5 07/13] block: Add PCI P2P flag for request queue and check support for requests List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Jens Axboe , linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-nvme@lists.infradead.org, linux-rdma@vger.kernel.org, linux-nvdimm@lists.01.org, linux-block@vger.kernel.org Cc: =?UTF-8?Q?Christian_K=c3=b6nig?= , Benjamin Herrenschmidt , Alex Williamson , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Jason Gunthorpe , Bjorn Helgaas , Max Gurtovoy , Christoph Hellwig List-ID: On 30/08/18 01:11 PM, Jens Axboe wrote: > On 8/30/18 12:53 PM, Logan Gunthorpe wrote: >> QUEUE_FLAG_PCI_P2P is introduced meaning a driver's request queue >> supports targeting P2P memory. >> >> When a request is submitted we check if PCI P2PDMA memory is assigned >> to the first page in the bio. If it is, we ensure the queue it's >> submitted to supports it, and enforce REQ_NOMERGE. > > I think this belongs in the caller - both the validity check, and > passing in NOMERGE for this type of request. I don't want to impose > this overhead on everything, for a pretty niche case. Well, the point was to prevent driver writers from doing the wrong thing. The WARN_ON would be a bit pointless in the driver if we rely on the driver to either do the right thing or add the WARN_ON themselves. If I'm going to change anything I'd drop the warning entirely and move the NO_MERGE back into the caller... Note: the check will be compiled out if the kernel does not support PCI P2P. Logan _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ale.deltatee.com ([207.54.116.67]:40596 "EHLO ale.deltatee.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727098AbeH3XVd (ORCPT ); Thu, 30 Aug 2018 19:21:33 -0400 To: Jens Axboe , linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-nvme@lists.infradead.org, linux-rdma@vger.kernel.org, linux-nvdimm@lists.01.org, linux-block@vger.kernel.org Cc: Stephen Bates , Christoph Hellwig , Keith Busch , Sagi Grimberg , Bjorn Helgaas , Jason Gunthorpe , Max Gurtovoy , Dan Williams , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Benjamin Herrenschmidt , Alex Williamson , =?UTF-8?Q?Christian_K=c3=b6nig?= References: <20180830185352.3369-1-logang@deltatee.com> <20180830185352.3369-8-logang@deltatee.com> From: Logan Gunthorpe Message-ID: <7c5b9d2c-d94e-582c-f1d7-0827dbb7df7c@deltatee.com> Date: Thu, 30 Aug 2018 13:17:40 -0600 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Subject: Re: [PATCH v5 07/13] block: Add PCI P2P flag for request queue and check support for requests Sender: linux-block-owner@vger.kernel.org List-Id: linux-block@vger.kernel.org On 30/08/18 01:11 PM, Jens Axboe wrote: > On 8/30/18 12:53 PM, Logan Gunthorpe wrote: >> QUEUE_FLAG_PCI_P2P is introduced meaning a driver's request queue >> supports targeting P2P memory. >> >> When a request is submitted we check if PCI P2PDMA memory is assigned >> to the first page in the bio. If it is, we ensure the queue it's >> submitted to supports it, and enforce REQ_NOMERGE. > > I think this belongs in the caller - both the validity check, and > passing in NOMERGE for this type of request. I don't want to impose > this overhead on everything, for a pretty niche case. Well, the point was to prevent driver writers from doing the wrong thing. The WARN_ON would be a bit pointless in the driver if we rely on the driver to either do the right thing or add the WARN_ON themselves. If I'm going to change anything I'd drop the warning entirely and move the NO_MERGE back into the caller... Note: the check will be compiled out if the kernel does not support PCI P2P. Logan From mboxrd@z Thu Jan 1 00:00:00 1970 From: Logan Gunthorpe Subject: Re: [PATCH v5 07/13] block: Add PCI P2P flag for request queue and check support for requests Date: Thu, 30 Aug 2018 13:17:40 -0600 Message-ID: <7c5b9d2c-d94e-582c-f1d7-0827dbb7df7c@deltatee.com> References: <20180830185352.3369-1-logang@deltatee.com> <20180830185352.3369-8-logang@deltatee.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-nvdimm-bounces-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org Sender: "Linux-nvdimm" To: Jens Axboe , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org, linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: =?UTF-8?Q?Christian_K=c3=b6nig?= , Benjamin Herrenschmidt , Alex Williamson , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Jason Gunthorpe , Bjorn Helgaas , Max Gurtovoy , Christoph Hellwig List-Id: linux-rdma@vger.kernel.org On 30/08/18 01:11 PM, Jens Axboe wrote: > On 8/30/18 12:53 PM, Logan Gunthorpe wrote: >> QUEUE_FLAG_PCI_P2P is introduced meaning a driver's request queue >> supports targeting P2P memory. >> >> When a request is submitted we check if PCI P2PDMA memory is assigned >> to the first page in the bio. If it is, we ensure the queue it's >> submitted to supports it, and enforce REQ_NOMERGE. > > I think this belongs in the caller - both the validity check, and > passing in NOMERGE for this type of request. I don't want to impose > this overhead on everything, for a pretty niche case. Well, the point was to prevent driver writers from doing the wrong thing. The WARN_ON would be a bit pointless in the driver if we rely on the driver to either do the right thing or add the WARN_ON themselves. If I'm going to change anything I'd drop the warning entirely and move the NO_MERGE back into the caller... Note: the check will be compiled out if the kernel does not support PCI P2P. Logan From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: To: Jens Axboe , linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-nvme@lists.infradead.org, linux-rdma@vger.kernel.org, linux-nvdimm@lists.01.org, linux-block@vger.kernel.org References: <20180830185352.3369-1-logang@deltatee.com> <20180830185352.3369-8-logang@deltatee.com> From: Logan Gunthorpe Message-ID: <7c5b9d2c-d94e-582c-f1d7-0827dbb7df7c@deltatee.com> Date: Thu, 30 Aug 2018 13:17:40 -0600 MIME-Version: 1.0 In-Reply-To: Subject: Re: [PATCH v5 07/13] block: Add PCI P2P flag for request queue and check support for requests List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sagi Grimberg , =?UTF-8?Q?Christian_K=c3=b6nig?= , Benjamin Herrenschmidt , Alex Williamson , Stephen Bates , Keith Busch , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Jason Gunthorpe , Bjorn Helgaas , Max Gurtovoy , Dan Williams , Christoph Hellwig Content-Type: text/plain; charset="us-ascii" Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+bjorn=helgaas.com@lists.infradead.org List-ID: On 30/08/18 01:11 PM, Jens Axboe wrote: > On 8/30/18 12:53 PM, Logan Gunthorpe wrote: >> QUEUE_FLAG_PCI_P2P is introduced meaning a driver's request queue >> supports targeting P2P memory. >> >> When a request is submitted we check if PCI P2PDMA memory is assigned >> to the first page in the bio. If it is, we ensure the queue it's >> submitted to supports it, and enforce REQ_NOMERGE. > > I think this belongs in the caller - both the validity check, and > passing in NOMERGE for this type of request. I don't want to impose > this overhead on everything, for a pretty niche case. Well, the point was to prevent driver writers from doing the wrong thing. The WARN_ON would be a bit pointless in the driver if we rely on the driver to either do the right thing or add the WARN_ON themselves. If I'm going to change anything I'd drop the warning entirely and move the NO_MERGE back into the caller... Note: the check will be compiled out if the kernel does not support PCI P2P. Logan _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme From mboxrd@z Thu Jan 1 00:00:00 1970 From: logang@deltatee.com (Logan Gunthorpe) Date: Thu, 30 Aug 2018 13:17:40 -0600 Subject: [PATCH v5 07/13] block: Add PCI P2P flag for request queue and check support for requests In-Reply-To: References: <20180830185352.3369-1-logang@deltatee.com> <20180830185352.3369-8-logang@deltatee.com> Message-ID: <7c5b9d2c-d94e-582c-f1d7-0827dbb7df7c@deltatee.com> On 30/08/18 01:11 PM, Jens Axboe wrote: > On 8/30/18 12:53 PM, Logan Gunthorpe wrote: >> QUEUE_FLAG_PCI_P2P is introduced meaning a driver's request queue >> supports targeting P2P memory. >> >> When a request is submitted we check if PCI P2PDMA memory is assigned >> to the first page in the bio. If it is, we ensure the queue it's >> submitted to supports it, and enforce REQ_NOMERGE. > > I think this belongs in the caller - both the validity check, and > passing in NOMERGE for this type of request. I don't want to impose > this overhead on everything, for a pretty niche case. Well, the point was to prevent driver writers from doing the wrong thing. The WARN_ON would be a bit pointless in the driver if we rely on the driver to either do the right thing or add the WARN_ON themselves. If I'm going to change anything I'd drop the warning entirely and move the NO_MERGE back into the caller... Note: the check will be compiled out if the kernel does not support PCI P2P. Logan